This passes existing X86 test but I'm not sure if it handles all type
legalization cases it needs to.
Alternative to D89200
Paths
| Differential D89222
[X86][SelectionDAG] Add SADDO_CARRY and SSUBO_CARRY to support multipart signed add/sub overflow legalization. ClosedPublic Authored by craig.topper on Oct 12 2020, 12:54 AM.
Details
Diff Detail
Unit TestsFailed Event TimelineComment Actions Add support for expanding SADDO_CARRY and SSUBO_CARRY in type legalizer. craig.topper retitled this revision from [X86][SelectionDAG] WIP Add SADDO_CARRY and SSUBO_CARRY to support multipart signed add/sub overflow legalization. to [X86][SelectionDAG] Add SADDO_CARRY and SSUBO_CARRY to support multipart signed add/sub overflow legalization..Oct 12 2020, 4:22 PM This revision was not accepted when it landed; it landed in state Needs Review.Oct 13 2020, 12:01 AM This revision was landed with ongoing or failed builds. Closed by commit rG1687a8d83b70: [X86][SelectionDAG] Add SADDO_CARRY and SSUBO_CARRY to support multipart signed… (authored by craig.topper). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 297507 llvm/include/llvm/CodeGen/ISDOpcodes.h
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
llvm/lib/Target/X86/X86ISelLowering.cpp
llvm/test/CodeGen/X86/known-bits.ll
llvm/test/CodeGen/X86/sadd_sat.ll
llvm/test/CodeGen/X86/sadd_sat_plus.ll
llvm/test/CodeGen/X86/sadd_sat_vec.ll
llvm/test/CodeGen/X86/ssub_sat.ll
llvm/test/CodeGen/X86/ssub_sat_plus.ll
llvm/test/CodeGen/X86/ssub_sat_vec.ll
llvm/test/CodeGen/X86/vec_saddo.ll
llvm/test/CodeGen/X86/vec_ssubo.ll
|
clang-format not found in user's PATH; not linting file.