Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[CodeGen] Postprocess PHI nodes for callbr
AbandonedPublic
Actions

Authored by void on Oct 5 2020, 2:37 AM.

Details

Reviewers

nickdesaulniers
jyknight
craig.topper
efriedma

Summary

When processing PHI nodes after a callbr, we need to make sure that the
PHI nodes on the default branch are resolved after the callbr (inserted
after INLINEASM_BR). The PHI node values on the indirect branches are
processed before the INLINEASM_BR.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	1,170 ms	linux > libarcher.parallel::parallel-nosuppression.c

Event Timeline

void created this revision.Oct 5 2020, 2:37 AM

Herald added a project: Restricted Project. · View Herald TranscriptOct 5 2020, 2:37 AM

Herald added subscribers: llvm-commits, pengfei, hiraditya. · View Herald Transcript

void requested review of this revision.Oct 5 2020, 2:37 AM

Harbormaster completed remote builds in B73963: Diff 296126.Oct 5 2020, 2:39 AM

test?

Add testcase.

In D88813#2312195, @nickdesaulniers wrote:

test?

Done.

Harbormaster completed remote builds in B74045: Diff 296257.Oct 5 2020, 12:34 PM

Update with missing elements so that it works.

@jyknight This doesn't have the loop refactored like you asked for. I'll work on that today.

Harbormaster completed remote builds in B74047: Diff 296259.Oct 5 2020, 12:49 PM

test case looks reasonable (I haven't run it pre-patch to see what goes wrong yet). Just curious, is this CL related to D88823?

In D88813#2312627, @nickdesaulniers wrote:

test case looks reasonable (I haven't run it pre-patch to see what goes wrong yet). Just curious, is this CL related to D88823?

No. I thought so, but they're different issues.

void abandoned this revision.Apr 6 2023, 2:29 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 2:29 PM