Async execute operation can take async arguments as dependencies.
Change async.execute custom parser/printer format to use %value as %unwrapped: !async.value<!type> sytax.
Paths
| Differential D88601
[MLIR] Add async token/value arguments to async.execute op ClosedPublic Authored by ezhulenev on Sep 30 2020, 11:37 AM.
Details Summary Async execute operation can take async arguments as dependencies. Change async.execute custom parser/printer format to use %value as %unwrapped: !async.value<!type> sytax.
Diff Detail
Event TimelineHerald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptSep 30 2020, 11:37 AM This revision now requires changes to proceed.Sep 30 2020, 11:40 AM
ezhulenev marked 2 inline comments as done. Comment ActionsUse namespace qualifiers to implement previously declared functions in Async.cpp
ezhulenev marked 2 inline comments as done. Comment ActionsCleanup includes + use isa for type matching ezhulenev marked an inline comment as done. Comment ActionsHandle parser.resolveOperands failure in async.execute op parsing
ezhulenev marked 9 inline comments as done. Comment ActionsUpdate async.execute op syntax
ezhulenev marked 4 inline comments as done. Comment ActionsDon't forget to check ParseResult and fix indentation.
This revision is now accepted and ready to land.Oct 9 2020, 8:52 AM Closed by commit rG4e69a52952bd: [MLIR] Add async token/value arguments to async.execute op (authored by ezhulenev). · Explain WhyOct 9 2020, 8:52 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 297041 mlir/include/mlir/Dialect/Async/IR/Async.h
mlir/include/mlir/Dialect/Async/IR/AsyncBase.td
mlir/include/mlir/Dialect/Async/IR/AsyncOps.td
mlir/lib/Dialect/Async/IR/Async.cpp
mlir/test/Dialect/Async/ops.mlir |
Mega-nit: I think this indentation is off