Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Would it make sense to set random seed to something fixed to make this more reproducible?
| clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp | ||
|---|---|---|
| 3 | nit: this is supposed to be one-line comment, I think. | |
| 23 | There are few lint warnings in this file. Please address them. | |
| 74 | These should not be comments. | |
Still a couple of lint warnings, otherwise LGTM
| clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp | ||
|---|---|---|
| 75 | Move this out of the loop. Right now we re-generate "random" dataset, but it's always the same dataset ;-) | |
Addressed comments.
| clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp | ||
|---|---|---|
| 75 | I added it inside the loop since there is only one state right now. But probably moving it out makes it more meaningful. | |
nit: this is supposed to be one-line comment, I think.