Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Would it make sense to set random seed to something fixed to make this more reproducible?
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp | ||
---|---|---|
2 ↗ | (On Diff #295479) | nit: this is supposed to be one-line comment, I think. |
22 ↗ | (On Diff #295479) | There are few lint warnings in this file. Please address them. |
73 ↗ | (On Diff #295479) | These should not be comments. |
Comment Actions
Still a couple of lint warnings, otherwise LGTM
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp | ||
---|---|---|
74 ↗ | (On Diff #295797) | Move this out of the loop. Right now we re-generate "random" dataset, but it's always the same dataset ;-) |
Comment Actions
Addressed comments.
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp | ||
---|---|---|
74 ↗ | (On Diff #295797) | I added it inside the loop since there is only one state right now. But probably moving it out makes it more meaningful. |
clang-format: please reformat the code