Page MenuHomePhabricator

[mlir] Fix shared libs build
ClosedPublic

Authored by awarzynski on Sep 29 2020, 6:23 AM.

Details

Summary

The following change causes the shared libraries build
(BUILD_SHARED_LIBS=On) to fail:

This patch will fix that.

Diff Detail

Event Timeline

awarzynski created this revision.Sep 29 2020, 6:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2020, 6:23 AM
awarzynski requested review of this revision.Sep 29 2020, 6:23 AM
ftynse accepted this revision.Sep 29 2020, 6:25 AM
This revision is now accepted and ready to land.Sep 29 2020, 6:25 AM

Hello,

https://reviews.llvm.org/D88351 has caused our Flang buildbots to start failing:

These buildbots are not in production yet (still connected to the staging master), so no notifications are sent.

We build with BUILD_SHARED_LIBS=ON and that's what stopped working. I'm not familiar with this code-base, so there might be a better solution. Do let me know and I'll update the patch. Ta!

This revision was automatically updated to reflect the committed changes.

Thanks for the fix!