This is an archive of the discontinued LLVM Phabricator instance.

Differential D88484

[mlir] Fix shared libs build
ClosedPublic

Authored by awarzynski on Sep 29 2020, 6:23 AM.

Details

Reviewers
jdoerfert
mehdi_amini
kiranchandramohan
ftynse
Commits
rG6199219bbd82: [mlir] Fix shared libs build
Summary

The following change causes the shared libraries build
(BUILD_SHARED_LIBS=On) to fail:

This patch will fix that.

Diff Detail

Event Timeline

awarzynski created this revision.Sep 29 2020, 6:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2020, 6:23 AM
Herald added subscribers: tatianashp, msifontes, jurahul and 14 others. · View Herald Transcript
awarzynski requested review of this revision.Sep 29 2020, 6:23 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptSep 29 2020, 6:23 AM
Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
awarzynski added reviewers: mehdi_amini, kiranchandramohan.Sep 29 2020, 6:24 AM
ftynse accepted this revision.Sep 29 2020, 6:25 AM
This revision is now accepted and ready to land.Sep 29 2020, 6:25 AM
Harbormaster completed remote builds in B73324: Diff 294954.Sep 29 2020, 6:28 AM
awarzynski added a comment.Sep 29 2020, 6:28 AM

Hello,

https://reviews.llvm.org/D88351 has caused our Flang buildbots to start failing:

These buildbots are not in production yet (still connected to the staging master), so no notifications are sent.

We build with BUILD_SHARED_LIBS=ON and that's what stopped working. I'm not familiar with this code-base, so there might be a better solution. Do let me know and I'll update the patch. Ta!

Closed by commit rG6199219bbd82: [mlir] Fix shared libs build (authored by awarzynski). · Explain WhySep 29 2020, 6:31 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rG6199219bbd82: [mlir] Fix shared libs build.
mehdi_amini added a comment.Sep 29 2020, 10:30 AM

Thanks for the fix!

awarzynski mentioned this in D103540: [flang] Enabling flang to build with BUILD_SHARED_LIBS=On.Jun 4 2021, 9:42 AM

Revision Contents

PathSize
mlir/
lib/
Target/
2 lines

Diff 294956

mlir/lib/Target/CMakeLists.txt

Show All 10 Linesadd_mlir_translation_library(MLIRTargetLLVMIRModuleTranslation
LINK_COMPONENTS LINK_COMPONENTS
Core Core
FrontendOpenMP FrontendOpenMP
TransformUtils TransformUtils
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRLLVMIR MLIRLLVMIR
MLIROpenMP
MLIRLLVMIRTransforms MLIRLLVMIRTransforms
MLIRTranslation MLIRTranslation
) )
add_mlir_translation_library(MLIRTargetAVX512 add_mlir_translation_library(MLIRTargetAVX512
LLVMIR/LLVMAVX512Intr.cpp LLVMIR/LLVMAVX512Intr.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
Show All 19 Linesadd_mlir_translation_library(MLIRTargetLLVMIR
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR
LINK_COMPONENTS LINK_COMPONENTS
Core Core
IRReader IRReader
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIROpenMP
MLIRTargetLLVMIRModuleTranslation MLIRTargetLLVMIRModuleTranslation
) )
add_mlir_translation_library(MLIRTargetNVVMIR add_mlir_translation_library(MLIRTargetNVVMIR
LLVMIR/ConvertToNVVMIR.cpp LLVMIR/ConvertToNVVMIR.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Target/LLVMIR
Show All 34 Lines