This is an archive of the discontinued LLVM Phabricator instance.

[clang][Sema] Use enumerator instead of hard-coded constant
ClosedPublic

Authored by miyuki on Sep 23 2020, 9:51 AM.

Download Raw Diff

Details

Reviewers

compnerd
aaron.ballman

Commits

rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant

Summary

Sema::DiagnoseSwiftName uses the constant 12 instead of the
corresponding enumerator ExpectedFunctionWithProtoType. This is
fragile and will fail if a new value gets added in the middle of the
enum.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

miyuki created this revision.Sep 23 2020, 9:51 AM

Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2020, 9:51 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

miyuki requested review of this revision.Sep 23 2020, 9:51 AM

Harbormaster completed remote builds in B72681: Diff 293778.Sep 23 2020, 10:32 AM

Good catch, LGTM!

This revision is now accepted and ready to land.Sep 23 2020, 1:09 PM

This revision was landed with ongoing or failed builds.Sep 24 2020, 2:24 AM

Closed by commit rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant (authored by miyuki). · Explain Why

This revision was automatically updated to reflect the committed changes.

miyuki added a commit: rG8cc842a95072: [clang][Sema] Use enumerator instead of hard-coded constant.

Revision Contents

Path

Size

clang/

lib/

Sema/

SemaDeclAttr.cpp

2 lines

Diff 293778

clang/lib/Sema/SemaDeclAttr.cpp

This file is larger than 256 KB, so syntax highlighting is disabled by default.

Show First 20 Lines • Show All 5,857 Lines • ▼ Show 20 Lines	if (const auto *Method = dyn_cast<ObjCMethodDecl>(D)) {
Params = Method->parameters().slice(0, ParamCount);		Params = Method->parameters().slice(0, ParamCount);
} else {		} else {
const auto *F = cast<FunctionDecl>(D);		const auto *F = cast<FunctionDecl>(D);

ParamCount = F->getNumParams();		ParamCount = F->getNumParams();
Params = F->parameters();		Params = F->parameters();

if (!F->hasWrittenPrototype()) {		if (!F->hasWrittenPrototype()) {
Diag(Loc, diag::warn_attribute_wrong_decl_type) << AL		Diag(Loc, diag::warn_attribute_wrong_decl_type) << AL
		Lint: Pre-merge checks Inline Actions clang-format: please reformat the code - Diag(Loc, diag::warn_attribute_wrong_decl_type) << AL - << ExpectedFunctionWithProtoType; + Diag(Loc, diag::warn_attribute_wrong_decl_type) + << AL << ExpectedFunctionWithProtoType; Lint: Pre-merge checks: clang-format: please reformat the code ``` - Diag(Loc, diag…
<< /* non-K&R-style functions */12;		<< ExpectedFunctionWithProtoType;
return false;		return false;
}		}
}		}

unsigned SwiftParamCount;		unsigned SwiftParamCount;
bool IsSingleParamInit;		bool IsSingleParamInit;
if (!validateSwiftFunctionName(*this, AL, Loc, Name,		if (!validateSwiftFunctionName(*this, AL, Loc, Name,
SwiftParamCount, IsSingleParamInit))		SwiftParamCount, IsSingleParamInit))
▲ Show 20 Lines • Show All 2,432 Lines • Show Last 20 Lines