Details
Details
- Reviewers
uweigand jonpa - Commits
- rG179e15d53acd: [SystemZ] Optimize bcmp calls (PR47420)
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?
If it is really ok to pass bcmp to visitMemCmpCall(), I think a comment on that specifies this would be nice, both for visitMemCmpCall() and EmitTargetCodeForMemcmp().
Comment Actions
X86 emits same inline codegen for cmp and memcmp:
https://godbolt.org/z/W4dE1z
Right, I will adjust to make it more clear.
Comment Actions
Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?
There are already many test cases for memcmp->bcmp transform so I dont see a need for it.
Comment Actions
Right, I will adjust to make it more clear.
I still think it would be nice to mention this in SelectionDAGTargetInfo.h (in the comment for EmitTargetCodeForMemcmp()) as well...?