Differential D87955

[MLIR][NFC] Adopt use of BlockRange in place of ArrayRef<Block *>
ClosedPublic
Actions

Authored by jurahul on Sep 18 2020, 4:40 PM.

Details

Reviewers

mravishankar
antiagainst
rriddle
mehdi_amini

Commits

rGa6ae6950173a: [MLIR][NFC] Adopt use of BlockRange in place of ArrayRef<Block *>

Summary

Use BlockRange in ODS generated builders as well as other places throughout the code

Depends On D87944

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jurahul created this revision.Sep 18 2020, 4:40 PM

Herald added a reviewer: mravishankar. · View Herald TranscriptSep 18 2020, 4:40 PM

Herald added a reviewer: antiagainst. · View Herald Transcript

Herald added a reviewer: rriddle. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: tatianashp, ThomasRaoux, AlexeySotkin and 14 others. · View Herald Transcript

jurahul requested review of this revision.Sep 18 2020, 4:40 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptSep 18 2020, 4:40 PM

Harbormaster completed remote builds in B72259: Diff 292925.Sep 18 2020, 5:06 PM

Thanks!

This revision is now accepted and ready to land.Sep 18 2020, 5:32 PM

Closed by commit rGa6ae6950173a: [MLIR][NFC] Adopt use of BlockRange in place of ArrayRef<Block *> (authored by jurahul). · Explain WhySep 23 2020, 9:22 AM

This revision was automatically updated to reflect the committed changes.

jurahul added a commit: rGa6ae6950173a: [MLIR][NFC] Adopt use of BlockRange in place of ArrayRef<Block *>.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

PDLInterp/

IR/

PDLInterpOps.td

10 lines

IR/

OperationSupport.h

7 lines

lib/

Dialect/

SPIRV/

Serialization/

7 lines

IR/

OperationSupport.cpp

4 lines

tools/

mlir-tblgen/

OpDefinitionsGen.cpp

18 lines

Diff 292925

mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td

Loading...

mlir/include/mlir/IR/OperationSupport.h

Loading...

mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp

Loading...

mlir/lib/IR/OperationSupport.cpp

Loading...

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Loading...