Page MenuHomePhabricator

[mlir][spirv] Add GroupNonUniformBroadcastOp
ClosedPublic

Authored by abialas on Sep 15 2020, 5:47 AM.

Details

Summary

Added GroupNonUniformBroadcastOp to spirv dialect.

Diff Detail

Unit TestsFailed

TimeTest
460 mswindows > LLVM.DebugInfo::debuglineinfo-path.ll
Script: -- : 'RUN: at line 7'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\llc.exe -mtriple=x86_64-pc-windows-gnu -O0 -filetype=obj -o C:\ws\w32-1\llvm-project\premerge-checks\build\test\DebugInfo\Output\debuglineinfo-path.ll.tmp < C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\debuglineinfo-path.ll
140 mswindows > LLVM.DebugInfo::symbolize-build-id.test
Script: -- : 'RUN: at line 1'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\yaml2obj.exe C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\symbolize-build-id.test -o C:\ws\w32-1\llvm-project\premerge-checks\build\test\DebugInfo\Output\symbolize-build-id.test.tmp
50 mswindows > LLVM.DebugInfo::symbolize-gnu-debuglink.test
Script: -- : 'RUN: at line 1'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\llvm-symbolizer.exe --obj=C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo/Inputs/dwarfdump-test.elf-x86-64.debuglink 0x40113f | c:\ws\w32-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\symbolize-gnu-debuglink.test
130 mswindows > LLVM.DebugInfo::symbolize.test
Script: -- : 'RUN: at line 1'; echo "C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo/Inputs/dwarfdump-test.elf-x86-64 0x40113f" > C:\ws\w32-1\llvm-project\premerge-checks\build\test\DebugInfo\Output\symbolize.test.tmp.input
170 mswindows > LLVM.DebugInfo/X86::2011-09-26-GlobalVarContext.ll
Script: -- : 'RUN: at line 1'; c:\ws\w32-1\llvm-project\premerge-checks\build\bin\llc.exe -mtriple=x86_64-pc-linux-gnu C:\ws\w32-1\llvm-project\premerge-checks\llvm\test\DebugInfo\X86\2011-09-26-GlobalVarContext.ll -o C:\ws\w32-1\llvm-project\premerge-checks\build\test\DebugInfo\X86\Output\2011-09-26-GlobalVarContext.ll.tmp -filetype=obj
View Full Test Results (10 Failed)

Event Timeline

abialas created this revision.Sep 15 2020, 5:47 AM
abialas requested review of this revision.Sep 15 2020, 5:47 AM
ThomasRaoux accepted this revision.Sep 15 2020, 7:55 AM
ThomasRaoux added inline comments.
mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
2064

I think you can remove both cast.

This revision is now accepted and ready to land.Sep 15 2020, 7:55 AM
abialas updated this revision to Diff 291944.Sep 15 2020, 8:24 AM

removed static_casts

Thanks Thomas for the review, may I ask you to push this change to llvm master?
Btw, to not bother you again with this, is there a process to get RW access to the repo so I can push future changes on my own?

Thanks Thomas for the review, may I ask you to push this change to llvm master?
Btw, to not bother you again with this, is there a process to get RW access to the repo so I can push future changes on my own?

Sure, I'll push it in a bit. You can obtain commit access by following the process described here:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

This revision was automatically updated to reflect the committed changes.