Page MenuHomePhabricator

Hazem (HazemAbdelhafez)
User

Projects

User does not belong to any projects.

User Details

User Since
May 21 2020, 2:18 PM (7 w, 2 d)

Recent Activity

Fri, Jul 3

Hazem added inline comments to D82671: [mlir][spirv] Add MatrixTimesMatrix operation.
Fri, Jul 3, 10:44 AM · Restricted Project

Thu, Jul 2

Hazem updated the diff for D82671: [mlir][spirv] Add MatrixTimesMatrix operation.
  • add helpers for the matrix type
  • update verification methods for matrix operations using the new helpers
Thu, Jul 2, 5:17 PM · Restricted Project

Tue, Jun 30

Hazem added inline comments to D82671: [mlir][spirv] Add MatrixTimesMatrix operation.
Tue, Jun 30, 8:39 AM · Restricted Project

Fri, Jun 26

Hazem created D82671: [mlir][spirv] Add MatrixTimesMatrix operation.
Fri, Jun 26, 12:02 PM · Restricted Project

Mon, Jun 22

Hazem added a comment to D82308: [mlir][spirv] Add TransposeOp.

Is the build failing because of this flag

Mon, Jun 22, 6:49 PM · Restricted Project
Hazem created D82308: [mlir][spirv] Add TransposeOp.
Mon, Jun 22, 8:35 AM · Restricted Project

Fri, Jun 19

Hazem added a comment to D81763: [mlir][spirv] Enhance AccessChainOp index type handling.

After submitting this patch, do you know how can I update the documentation? (https://mlir.llvm.org/docs/Dialects/SPIR-V/#spvaccesschain-spirvaccesschainop)

Fri, Jun 19, 10:52 AM · Restricted Project

Wed, Jun 17

Hazem added a comment to D81763: [mlir][spirv] Enhance AccessChainOp index type handling.

I fixed it now. Thanks!

Wed, Jun 17, 5:49 PM · Restricted Project
Hazem updated the diff for D81763: [mlir][spirv] Enhance AccessChainOp index type handling.
  • Fix unintentional files remove from patch
Wed, Jun 17, 4:44 PM · Restricted Project
Hazem committed rG55d53d4f5448: [mlir][spirv] Add MatrixTimesScalar operation (authored by Hazem).
[mlir][spirv] Add MatrixTimesScalar operation
Wed, Jun 17, 3:41 PM
Hazem closed D81677: [mlir][spirv] Add MatrixTimesScalar operation.
Wed, Jun 17, 3:41 PM · Restricted Project
Hazem added a comment to D81677: [mlir][spirv] Add MatrixTimesScalar operation.

LGTM!

Wed, Jun 17, 3:39 PM · Restricted Project
Hazem added a comment to D81763: [mlir][spirv] Enhance AccessChainOp index type handling.

Does anyone know why the pre-merge test fails? It is pointing out to line "mlir/lib/Dialect/SPIRV/SPIRVOps.cpp:798" and it is not clear to me from the diagnostics what is the problem that needs to be fixed. Thanks!

Wed, Jun 17, 2:02 PM · Restricted Project
Hazem updated the diff for D81763: [mlir][spirv] Enhance AccessChainOp index type handling.
  • address revision comments
Wed, Jun 17, 9:40 AM · Restricted Project

Tue, Jun 16

Hazem added inline comments to D81677: [mlir][spirv] Add MatrixTimesScalar operation.
Tue, Jun 16, 11:00 AM · Restricted Project
Hazem added inline comments to D81677: [mlir][spirv] Add MatrixTimesScalar operation.
Tue, Jun 16, 10:26 AM · Restricted Project

Mon, Jun 15

Hazem added inline comments to D81677: [mlir][spirv] Add MatrixTimesScalar operation.
Mon, Jun 15, 7:19 PM · Restricted Project
Hazem added a comment to D81677: [mlir][spirv] Add MatrixTimesScalar operation.

Hey @Hazem , did you forget to push new changes? I'm still seeing the old commits.

Mon, Jun 15, 7:19 PM · Restricted Project
Hazem updated the diff for D81677: [mlir][spirv] Add MatrixTimesScalar operation.
  • address revision comments
Mon, Jun 15, 7:19 PM · Restricted Project
Hazem added inline comments to D81677: [mlir][spirv] Add MatrixTimesScalar operation.
Mon, Jun 15, 11:31 AM · Restricted Project
Hazem added inline comments to D81677: [mlir][spirv] Add MatrixTimesScalar operation.
Mon, Jun 15, 11:31 AM · Restricted Project
Hazem added a comment to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

I am not sure I am following up, can someone explain to me why we needed to revert this change and then add "bits/stdint-uintn.h" in the first place? The link (http://lab.llvm.org:8011/builders/mlir-windows/builds/3068) to the initial change that caused the original issue wasn't related to this particular patch. Or maybe I misunderstood the messages.

Since the build failed right after it was committed, and reverted it fixed the build, that seems like a good indication that it was related :)

Mon, Jun 15, 9:13 AM · Restricted Project
Hazem added a comment to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

I am not sure I am following up, can someone explain to me why we needed to revert this change and then add "bits/stdint-uintn.h" in the first place? The link (http://lab.llvm.org:8011/builders/mlir-windows/builds/3068) to the initial change that caused the original issue wasn't related to this particular patch. Or maybe I misunderstood the messages.

GCC and MSVC is not happy with this->decoration < other.decoration. Enum classes will not implicitly convert to integers. I changed to static_cast<uint32_t>(this->decoration) < static_cast<uint32_t>(other.decoration) to fix.

Mon, Jun 15, 9:13 AM · Restricted Project

Fri, Jun 12

Hazem created D81763: [mlir][spirv] Enhance AccessChainOp index type handling.
Fri, Jun 12, 1:42 PM · Restricted Project
Hazem added a comment to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

I am not sure I am following up, can someone explain to me why we needed to revert this change and then add "bits/stdint-uintn.h" in the first place? The link (http://lab.llvm.org:8011/builders/mlir-windows/builds/3068) to the initial change that caused the original issue wasn't related to this particular patch. Or maybe I misunderstood the messages.

Fri, Jun 12, 9:45 AM · Restricted Project

Jun 11 2020

Hazem updated the diff for D81677: [mlir][spirv] Add MatrixTimesScalar operation.
  • remove unintentionally added include line
Jun 11 2020, 12:07 PM · Restricted Project
Hazem created D81677: [mlir][spirv] Add MatrixTimesScalar operation.
Jun 11 2020, 11:32 AM · Restricted Project

Jun 10 2020

Hazem added a comment to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

@antigainst, I made all the changes but I am failing the build I believe because of llvm::hash_value method in clang-tidy, do you know how can I workaround this? the function has to be defined this way.

Jun 10 2020, 10:32 AM · Restricted Project
Hazem updated the diff for D81426: [mlir][spirv] modify structure type member decoration and layout information handling.
  • Addressing more revision comments
Jun 10 2020, 9:17 AM · Restricted Project
Hazem added inline comments to D81426: [mlir][spirv] modify structure type member decoration and layout information handling.
Jun 10 2020, 8:43 AM · Restricted Project

Jun 8 2020

Hazem updated the diff for D81426: [mlir][spirv] modify structure type member decoration and layout information handling.
  • address few nits after revision review
Jun 8 2020, 2:58 PM · Restricted Project
Hazem updated the diff for D81426: [mlir][spirv] modify structure type member decoration and layout information handling.

Updating D81426: [mlir][spirv] modify structure type member decoration and layout information handling

Jun 8 2020, 1:51 PM · Restricted Project
Hazem created D81426: [mlir][spirv] modify structure type member decoration and layout information handling.
Jun 8 2020, 1:51 PM · Restricted Project

Jun 4 2020

Hazem updated the diff for D80837: [MLIR][SPIRV] Add flat, location, and noperspective decorations.
  • rename decorations test file and edit CHECK string values to reflect what the tests actually check
Jun 4 2020, 3:31 PM · Restricted Project, Restricted Project
Herald updated subscribers of D80837: [MLIR][SPIRV] Add flat, location, and noperspective decorations.
Jun 4 2020, 2:57 PM · Restricted Project, Restricted Project

May 29 2020

Hazem created D80837: [MLIR][SPIRV] Add flat, location, and noperspective decorations.
May 29 2020, 2:14 PM · Restricted Project, Restricted Project

May 28 2020

Hazem added a comment to D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect.

Do you have commit access to llvm-project mono repo? Let me know if not then I can land this for you.

May 28 2020, 5:38 PM · Restricted Project, Restricted Project
Hazem updated the diff for D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect.

Updating D80594: [MLIR][SPIRV] Addressed revision changes requested, and removed decorators to another CL as requested.

May 28 2020, 12:05 PM · Restricted Project, Restricted Project

May 27 2020

Hazem added a comment to D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect.

Did a glance through of this. Mostly looks fine to me. Only question is the decorations added here dont seem to be related to the matrix type as such. If so can we split those into two separate CLs. And also I dont see any test for the roundtrip through SPIR-V binary for those decorations....

May 27 2020, 11:56 AM · Restricted Project, Restricted Project
Hazem added inline comments to D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect.
May 27 2020, 8:05 AM · Restricted Project, Restricted Project

May 26 2020

Hazem retitled D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect from [MLIR][SPIRV] Adding several decorators manually to support ser/des of recent version shaders. to [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect.
May 26 2020, 3:50 PM · Restricted Project, Restricted Project
Hazem created D80594: [MLIR][SPIRV] Adding new data type and decorators to SPIRV Dialect.
May 26 2020, 3:19 PM · Restricted Project, Restricted Project