Page MenuHomePhabricator

[mlir][spirv] Add GroupNonUniformBroadcastOp
ClosedPublic

Authored by abialas on Sep 15 2020, 5:47 AM.

Details

Summary

Added GroupNonUniformBroadcastOp to spirv dialect.

Diff Detail

Event Timeline

abialas created this revision.Sep 15 2020, 5:47 AM
abialas requested review of this revision.Sep 15 2020, 5:47 AM
ThomasRaoux accepted this revision.Sep 15 2020, 7:55 AM
ThomasRaoux added inline comments.
mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
2064

I think you can remove both cast.

This revision is now accepted and ready to land.Sep 15 2020, 7:55 AM
abialas updated this revision to Diff 291944.Sep 15 2020, 8:24 AM

removed static_casts

Thanks Thomas for the review, may I ask you to push this change to llvm master?
Btw, to not bother you again with this, is there a process to get RW access to the repo so I can push future changes on my own?

Thanks Thomas for the review, may I ask you to push this change to llvm master?
Btw, to not bother you again with this, is there a process to get RW access to the repo so I can push future changes on my own?

Sure, I'll push it in a bit. You can obtain commit access by following the process described here:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

This revision was automatically updated to reflect the committed changes.