Page MenuHomePhabricator

abialas (Artur Bialas)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2020, 4:58 AM (94 w, 1 d)

Recent Activity

Nov 10 2020

abialas committed rG3035e676a388: [mlir][spirv] Add VectorInsertDynamicOp and vector.insertelement lowering (authored by abialas).
[mlir][spirv] Add VectorInsertDynamicOp and vector.insertelement lowering
Nov 10 2020, 12:50 AM
abialas closed D90927: [mlir][spirv] Add VectorInsertDynamicOp and vector.insertelement lowering.
Nov 10 2020, 12:50 AM · Restricted Project

Nov 8 2020

abialas updated the diff for D90927: [mlir][spirv] Add VectorInsertDynamicOp and vector.insertelement lowering.

Added changes requested by Thomas

Nov 8 2020, 11:33 PM · Restricted Project

Nov 6 2020

abialas requested review of D90927: [mlir][spirv] Add VectorInsertDynamicOp and vector.insertelement lowering.
Nov 6 2020, 3:17 AM · Restricted Project

Nov 4 2020

abialas committed rGf9dca1039a4a: [mlir][spirv] Add VectorExtractDynamicOp and vector.extractelement lowering (authored by abialas).
[mlir][spirv] Add VectorExtractDynamicOp and vector.extractelement lowering
Nov 4 2020, 11:28 PM
abialas committed rG1938b61bda50: [mlir][spirv] Allow usage of vector size 8 and 16 with Vector16 capability (authored by abialas).
[mlir][spirv] Allow usage of vector size 8 and 16 with Vector16 capability
Nov 4 2020, 11:27 PM
abialas closed D90679: [mlir][spirv] Add VectorExtractDynamicOp and vector.extractelement lowering.
Nov 4 2020, 11:27 PM · Restricted Project
abialas closed D90683: [mlir][spirv] Allow usage of vector size 8 and 16 with Vector16 capability.
Nov 4 2020, 11:27 PM · Restricted Project
abialas updated the diff for D90679: [mlir][spirv] Add VectorExtractDynamicOp and vector.extractelement lowering.

moved tests to composite-ops

Nov 4 2020, 4:52 AM · Restricted Project
abialas updated the diff for D90679: [mlir][spirv] Add VectorExtractDynamicOp and vector.extractelement lowering.

Thank You for the comments! Added requested changes. I wanted to keep this change not dependent on the Vector16 change, so did not add the unit test for VectorExtractDynamicOp with vector sizes 8 or 16, but verified that it is working in our use cases.

Nov 4 2020, 2:27 AM · Restricted Project
abialas updated the diff for D90683: [mlir][spirv] Allow usage of vector size 8 and 16 with Vector16 capability.

Thank You for the review. Added requested changes, except testing in availability.mlir. As this is test type required capability it is not being kicked there when checking particular ops, similar to Int8 or Float16. I added one more test for this in vce-deduction.mlir

Nov 4 2020, 1:26 AM · Restricted Project

Nov 3 2020

abialas requested review of D90683: [mlir][spirv] Allow usage of vector size 8 and 16 with Vector16 capability.
Nov 3 2020, 6:19 AM · Restricted Project
abialas requested review of D90679: [mlir][spirv] Add VectorExtractDynamicOp and vector.extractelement lowering.
Nov 3 2020, 5:15 AM · Restricted Project

Sep 25 2020

abialas committed rG396e7f454893: [mlir][SCFToGPU] LaunchOp propagate optional attributes (authored by abialas).
[mlir][SCFToGPU] LaunchOp propagate optional attributes
Sep 25 2020, 12:22 AM
abialas closed D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .
Sep 25 2020, 12:22 AM · Restricted Project

Sep 24 2020

abialas updated the diff for D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .

added simple test

Sep 24 2020, 3:12 AM · Restricted Project
abialas requested review of D88203: [mlir][SCFToGPU] LaunchOp propagate optional attributes .
Sep 24 2020, 2:04 AM · Restricted Project

Sep 17 2020

abialas added a reverting change for rG9d54b166c2e5: This is a test commit: rG5a733468e094: Revert "This is a test commit".
Sep 17 2020, 11:45 PM
abialas committed rG5a733468e094: Revert "This is a test commit" (authored by abialas).
Revert "This is a test commit"
Sep 17 2020, 11:45 PM
abialas committed rG9d54b166c2e5: This is a test commit (authored by abialas).
This is a test commit
Sep 17 2020, 11:45 PM

Sep 16 2020

abialas added a comment to D87688: [mlir][spirv] Add GroupNonUniformBroadcastOp.

Thanks Thomas for the review, may I ask you to push this change to llvm master?
Btw, to not bother you again with this, is there a process to get RW access to the repo so I can push future changes on my own?

Sep 16 2020, 10:39 PM · Restricted Project

Sep 15 2020

abialas updated the diff for D87688: [mlir][spirv] Add GroupNonUniformBroadcastOp.

removed static_casts

Sep 15 2020, 8:24 AM · Restricted Project
abialas requested review of D87688: [mlir][spirv] Add GroupNonUniformBroadcastOp.
Sep 15 2020, 5:47 AM · Restricted Project

Sep 2 2020

abialas added a comment to D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.

Thanks Thomas, good catch. Please take a look at the updated version. If it looks good, may I ask you to push this change to llvm master?

Sep 2 2020, 4:02 AM · Restricted Project
abialas updated the diff for D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.

added changes from code review

Sep 2 2020, 4:01 AM · Restricted Project

Sep 1 2020

abialas updated the diff for D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.
Sep 1 2020, 5:41 AM · Restricted Project

Aug 31 2020

abialas requested review of D86876: [mlir][spirv] Add block read and write from SPV_INTEL_subgroups.
Aug 31 2020, 6:26 AM · Restricted Project

Aug 10 2020

abialas added a comment to D85435: [mlir][spirv] Add OpGroupBroadcast.

I added remaining changes requested. Regarding the CHECK-* format I believe it is consistent with other tests.
Since I do not have rw access to llvm repo, may I ask someone to push this change to trunk?

Aug 10 2020, 1:18 AM · Restricted Project
abialas updated the diff for D85435: [mlir][spirv] Add OpGroupBroadcast.

Changes after code review

Aug 10 2020, 1:14 AM · Restricted Project

Aug 7 2020

abialas added a comment to D85435: [mlir][spirv] Add OpGroupBroadcast.

We also need tests for roundtripping the serialization to SPIR-V binary. Please see this section : https://mlir.llvm.org/docs/Dialects/SPIR-V/#add-a-new-op

"Tests for the op’s custom assembly form and verification should be added to the proper file in test/Dialect/SPIRV/.

The generated op will automatically gain the logic for (de)serialization. However, tests still need to be coupled with the change to make sure no surprises. Serialization tests live in test/Dialect/SPIRV/Serialization."

Aug 7 2020, 1:13 AM · Restricted Project
abialas updated the diff for D85435: [mlir][spirv] Add OpGroupBroadcast.

Changes added after code review

Aug 7 2020, 1:09 AM · Restricted Project

Aug 6 2020

abialas requested review of D85435: [mlir][spirv] Add OpGroupBroadcast.
Aug 6 2020, 8:32 AM · Restricted Project