Page MenuHomePhabricator
Differential D87138

[analyzer][NFC] Introduce refactoring of PthreadLockChecker
ClosedPublic
Actions

Authored by ASDenysPetrov on Sep 4 2020, 5:33 AM.

Details

Reviewers
steakhal
vsavchenko
xazax.hun
NoQ
baloghadamsoftware
martong
Commits
rGe67405141836: [analyzer] [NFC] Introduce refactoring of PthreadLockChecker
Summary
  • Change capitalization of some names due to LLVM naming rules.
  • Change names of some variables to make more speaking.
  • Rework similar bug reports into one common function.

Prepare code for the next patches to reduce unrelated changes.

Diff Detail

Event Timeline

ASDenysPetrov created this revision.Sep 4 2020, 5:33 AM
Herald added subscribers: cfe-commits, martong, Charusso and 7 others. · View Herald TranscriptSep 4 2020, 5:33 AM
ASDenysPetrov requested review of this revision.Sep 4 2020, 5:33 AM
Harbormaster completed remote builds in B70647: Diff 289922.Sep 4 2020, 6:10 AM
martong accepted this revision.Sep 4 2020, 6:16 AM

This seems to be a total non-functional-change. Please include [NFC] next time with a similar refactoring. Otherwise, Looks good to me, thanks!

This revision is now accepted and ready to land.Sep 4 2020, 6:16 AM
ASDenysPetrov retitled this revision from [analyzer] Introduce refactoring of PthreadLockChecker to [analyzer][NFC] Introduce refactoring of PthreadLockChecker.Sep 4 2020, 8:14 AM
In D87138#2256360, @martong wrote:

This seems to be a total non-functional-change. Please include [NFC] next time with a similar refactoring. Otherwise, Looks good to me, thanks!

Thanks! Added [NFC] to the title.

ASDenysPetrov added a child revision: D87146: [analyzer] Implement shared semantics checks for XNU functions in PthreadLockChecker.Sep 4 2020, 8:25 AM
steakhal accepted this revision.Sep 7 2020, 8:21 AM

Seems fine to me.

Closed by commit rGe67405141836: [analyzer] [NFC] Introduce refactoring of PthreadLockChecker (authored by ASDenysPetrov). · Explain WhySep 8 2020, 6:04 AM
This revision was automatically updated to reflect the committed changes.
ASDenysPetrov added a commit: rGe67405141836: [analyzer] [NFC] Introduce refactoring of PthreadLockChecker.

Revision Contents
Changeset List

PathSize
clang/
lib/
StaticAnalyzer/
Checkers/
271 lines

Diff 290463

View Options

clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp

Loading...