Added support to OpSubgroupBlockReadINTEL and OpSubgroupBlockWriteINTEL
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/include/mlir/Dialect/SPIRV/SPIRVGroupOps.td | ||
---|---|---|
228 | Are you missing the buffer type? (ex: "StorageBuffer") | |
mlir/lib/Dialect/SPIRV/SPIRVOps.cpp | ||
2056 | The description mentions: Result Type may be a scalar or vector type, and its component type must be equal to the type pointed to by Ptr. The type of Ptr must be a pointer type, and must point to a scalar type. Here it looks like if the data is a vector we would expect the pointer to be a pointer of elementType which would be a pointer of vector. | |
2074–2077 | Same problem as above here, this verification function would check that pointer points to a type matching the destination type. This is consistent with the parser but not with the description. It might be worth adding a test for the vector case to make sure you have what you want. |
Thanks Thomas, good catch. Please take a look at the updated version. If it looks good, may I ask you to push this change to llvm master?
Are you missing the buffer type? (ex: "StorageBuffer")