Page MenuHomePhabricator

Fix operator!= for Dialects.
ClosedPublic

Authored by fedelebron on Aug 28 2020, 1:06 PM.

Details

Summary

Currently the global operator!=(bool, bool) is selected due to the implicit bool
conversion operator. Since this is never the desired semantics, we give it a
standard operator!= and make the bool conversion explicit.

Depends On D86809

Diff Detail

Event Timeline

fedelebron created this revision.Aug 28 2020, 1:06 PM
Herald added a project: Restricted Project. · View Herald Transcript
fedelebron requested review of this revision.Aug 28 2020, 1:06 PM
rriddle accepted this revision.Aug 28 2020, 1:09 PM
rriddle added inline comments.
mlir/include/mlir/TableGen/Dialect.h
69–71

nit: I'd just drop this newline.

This revision is now accepted and ready to land.Aug 28 2020, 1:09 PM
This revision was automatically updated to reflect the committed changes.