Page MenuHomePhabricator

Make struct dialects have the same field name as everything else, 'dialect'.
ClosedPublic

Authored by fedelebron on Aug 28 2020, 1:03 PM.

Details

Summary

Also make the behavior of getting a dialect more forgiving, in the case where
there isn't a dialect associated with an attribute.

Depends On D86807

Diff Detail

Event Timeline

fedelebron created this revision.Aug 28 2020, 1:03 PM
Herald added a project: Restricted Project. · View Herald Transcript
fedelebron requested review of this revision.Aug 28 2020, 1:03 PM
rriddle added inline comments.Aug 28 2020, 1:10 PM
mlir/lib/TableGen/Attribute.cpp
129–134

MLIR variable names should be camelCase, here and below.

131

nit: Drop the trivial braces here.

mehdi_amini accepted this revision.Aug 28 2020, 1:26 PM

LGTM (with River's nit addressed), thanks!

This revision is now accepted and ready to land.Aug 28 2020, 1:26 PM
fedelebron marked 2 inline comments as done.

Lint fixes.

Changes done :)

mlir/lib/TableGen/Attribute.cpp
129–134

Ah interesting, this differs from LLVM's style, from whence this code came.

Fixing some targets.

This revision was landed with ongoing or failed builds.Sep 10 2020, 12:13 PM
This revision was automatically updated to reflect the committed changes.