This patch helps make the debug_abbrev_offset field optional. We don't
need to calculate the value of this field in the future.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
For some reason, I didn't get any email notification about this review. Could you let me know if there are any other patches you want me to review, please?
llvm/lib/ObjectYAML/DWARFEmitter.cpp | ||
---|---|---|
99 | We should probably not be using report_fatal_error here. Either an Expected needs returning up the stack, or this should be an assertion, depending on whether a user input could reach this case or not. | |
450–456 | I might be misremembering the llvm-dev conversation, but I think the style is if any level of an if statement requires braces, they all do (i.e. please add them to the inner if). | |
455 | Please add a comment saying why it's okay to consumeError here rather than report it. |
We should probably not be using report_fatal_error here. Either an Expected needs returning up the stack, or this should be an assertion, depending on whether a user input could reach this case or not.