Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[DWARFYAML] Abbrev codes in a new abbrev table should start from 1 (by default).
ClosedPublic
Actions

Authored by Higuoxing on Aug 25 2020, 8:47 AM.

Details

Reviewers

jhenderson
grimar
MaskRay
• espindola

Commits

rGf20e6c725385: [DWARFYAML] Abbrev codes in a new abbrev table should start from 1 (by default).

Summary

The abbrev codes in a new abbrev table should start from 1 (by default),
rather than inherit the value from the code in the previous table.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Higuoxing created this revision.Aug 25 2020, 8:47 AM

Herald added a reviewer: • espindola. · View Herald TranscriptAug 25 2020, 8:47 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, hiraditya, emaste. · View Herald Transcript

Higuoxing requested review of this revision.Aug 25 2020, 8:47 AM

Harbormaster completed remote builds in B69459: Diff 287684.Aug 25 2020, 9:33 AM

Higuoxing added a child revision: D86614: [DWARFYAML] Make the debug_abbrev_offset field optional..Aug 26 2020, 5:23 AM

LGTM!

This revision is now accepted and ready to land.Aug 27 2020, 12:45 AM

Closed by commit rGf20e6c725385: [DWARFYAML] Abbrev codes in a new abbrev table should start from 1 (by default). (authored by Higuoxing). · Explain WhyAug 28 2020, 6:18 AM

This revision was automatically updated to reflect the committed changes.

Higuoxing added a commit: rGf20e6c725385: [DWARFYAML] Abbrev codes in a new abbrev table should start from 1 (by default)..

Revision Contents
Changeset List

Path

Size

llvm/

lib/

ObjectYAML/

DWARFEmitter.cpp

2 lines

test/

tools/

yaml2obj/

ELF/

DWARF/

debug-abbrev.yaml

15 lines

Diff 288592

View Options

llvm/lib/ObjectYAML/DWARFEmitter.cpp