This is an archive of the discontinued LLVM Phabricator instance.

Differential D85766

[mlir][linalg][NFC] Remove extra semi-colon causing warnings
ClosedPublic

Authored by clementval on Aug 11 2020, 11:31 AM.

Details

Reviewers
mehdi_amini
nicolasvasilache
rriddle
Commits
rG0e70a127a942: [mlir][linalg][NFC] Remove extra semi-colon causing warnings
Summary

Extra semi-colon causes bunch of warnings with GCC 9.2.0

[1354/1516] Building CXX object tools/mlir/lib/Dialect/Linalg/IR/CMakeFiles/obj.MLIRLinalgOps.dir/LinalgOps.cpp.o
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1306:35: warning: extra ';' [-Wpedantic]
 1306 | CANONICALIZERS_AND_FOLDERS(ConvOp);
      |                                   ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1307:41: warning: extra ';' [-Wpedantic]
 1307 | CANONICALIZERS_AND_FOLDERS(PoolingMaxOp);
      |                                         ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1308:41: warning: extra ';' [-Wpedantic]
 1308 | CANONICALIZERS_AND_FOLDERS(PoolingMinOp);
      |                                         ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1309:41: warning: extra ';' [-Wpedantic]
 1309 | CANONICALIZERS_AND_FOLDERS(PoolingSumOp);
      |                                         ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1310:35: warning: extra ';' [-Wpedantic]
 1310 | CANONICALIZERS_AND_FOLDERS(CopyOp);
      |                                   ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1311:35: warning: extra ';' [-Wpedantic]
 1311 | CANONICALIZERS_AND_FOLDERS(FillOp);
      |                                   ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1312:38: warning: extra ';' [-Wpedantic]
 1312 | CANONICALIZERS_AND_FOLDERS(GenericOp);
      |                                      ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1313:45: warning: extra ';' [-Wpedantic]
 1313 | CANONICALIZERS_AND_FOLDERS(IndexedGenericOp);
      |                                             ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1318:42: warning: extra ';' [-Wpedantic]
 1318 | CANONICALIZERS_AND_FOLDERS(BatchMatmulOp);
      |                                          ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1319:34: warning: extra ';' [-Wpedantic]
 1319 | CANONICALIZERS_AND_FOLDERS(DotOp);
      |                                  ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1320:37: warning: extra ';' [-Wpedantic]
 1320 | CANONICALIZERS_AND_FOLDERS(MatmulOp);
      |                                     ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1321:37: warning: extra ';' [-Wpedantic]
 1321 | CANONICALIZERS_AND_FOLDERS(MatvecOp);
      |                                     ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1322:36: warning: extra ';' [-Wpedantic]
 1322 | CANONICALIZERS_AND_FOLDERS(ConvWOp);
      |                                    ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1323:38: warning: extra ';' [-Wpedantic]
 1323 | CANONICALIZERS_AND_FOLDERS(ConvNWCOp);
      |                                      ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1324:38: warning: extra ';' [-Wpedantic]
 1324 | CANONICALIZERS_AND_FOLDERS(ConvNCWOp);
      |                                      ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1325:37: warning: extra ';' [-Wpedantic]
 1325 | CANONICALIZERS_AND_FOLDERS(ConvHWOp);
      |                                     ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1326:39: warning: extra ';' [-Wpedantic]
 1326 | CANONICALIZERS_AND_FOLDERS(ConvNHWCOp);
      |                                       ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1327:39: warning: extra ';' [-Wpedantic]
 1327 | CANONICALIZERS_AND_FOLDERS(ConvNCHWOp);
      |                                       ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1328:38: warning: extra ';' [-Wpedantic]
 1328 | CANONICALIZERS_AND_FOLDERS(ConvDHWOp);
      |                                      ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1329:40: warning: extra ';' [-Wpedantic]
 1329 | CANONICALIZERS_AND_FOLDERS(ConvNDHWCOp);
      |                                        ^
/home/4vn/versioning/llvm-project/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:1330:40: warning: extra ';' [-Wpedantic]
 1330 | CANONICALIZERS_AND_FOLDERS(ConvNCDHWOp);
      |                                        ^

Diff Detail

Unit TestsFailed

TimeTest
330 mslinux > LLVM.CodeGen/AMDGPU/GlobalISel::andn2.ll
340 mslinux > LLVM.CodeGen/AMDGPU/GlobalISel::orn2.ll
430 mslinux > LLVM.CodeGen/AMDGPU/GlobalISel::xnor.ll
420 mswindows > LLVM.CodeGen/AMDGPU/GlobalISel::andn2.ll
390 mswindows > LLVM.CodeGen/AMDGPU/GlobalISel::orn2.ll
View Full Test Results (6 Failed)

Event Timeline

clementval created this revision.Aug 11 2020, 11:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2020, 11:31 AM
Herald added subscribers: msifontes, jurahul, Kayjukh and 10 others. · View Herald Transcript
clementval requested review of this revision.Aug 11 2020, 11:31 AM
Herald added subscribers: limo1996, stephenneuendorffer. · View Herald TranscriptAug 11 2020, 11:31 AM
clementval edited the summary of this revision. (Show Details)Aug 11 2020, 11:32 AM
clementval retitled this revision from [mlir][linalg][NFC] Remove exta semi-colon causing warnings to [mlir][linalg][NFC] Remove extra semi-colon causing warnings.Aug 11 2020, 11:41 AM
Harbormaster completed remote builds in B67971: Diff 284831.Aug 11 2020, 1:20 PM
rriddle accepted this revision.Aug 11 2020, 10:57 PM
This revision is now accepted and ready to land.Aug 11 2020, 10:57 PM
mehdi_amini accepted this revision.Aug 12 2020, 2:19 AM
This revision was landed with ongoing or failed builds.Aug 12 2020, 8:44 AM
Closed by commit rG0e70a127a942: [mlir][linalg][NFC] Remove extra semi-colon causing warnings (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG0e70a127a942: [mlir][linalg][NFC] Remove extra semi-colon causing warnings.

Revision Contents

PathSize
mlir/
lib/
Dialect/
Linalg/
IR/
42 lines

Diff 284831

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Show First 20 Lines • Show All 1,297 Lines • ▼ Show 20 Lines void XXX::getCanonicalizationPatterns(OwningRewritePatternList &results, \
results.insert<EraseDeadLinalgOp>(); \ results.insert<EraseDeadLinalgOp>(); \
} \ } \
\ \
LogicalResult XXX::fold(ArrayRef<Attribute>, \ LogicalResult XXX::fold(ArrayRef<Attribute>, \
SmallVectorImpl<OpFoldResult> &) { \ SmallVectorImpl<OpFoldResult> &) { \
return foldMemRefCast(*this); \ return foldMemRefCast(*this); \
} }
CANONICALIZERS_AND_FOLDERS(ConvOp); CANONICALIZERS_AND_FOLDERS(ConvOp)
CANONICALIZERS_AND_FOLDERS(PoolingMaxOp); CANONICALIZERS_AND_FOLDERS(PoolingMaxOp)
CANONICALIZERS_AND_FOLDERS(PoolingMinOp); CANONICALIZERS_AND_FOLDERS(PoolingMinOp)
CANONICALIZERS_AND_FOLDERS(PoolingSumOp); CANONICALIZERS_AND_FOLDERS(PoolingSumOp)
CANONICALIZERS_AND_FOLDERS(CopyOp); CANONICALIZERS_AND_FOLDERS(CopyOp)
CANONICALIZERS_AND_FOLDERS(FillOp); CANONICALIZERS_AND_FOLDERS(FillOp)
CANONICALIZERS_AND_FOLDERS(GenericOp); CANONICALIZERS_AND_FOLDERS(GenericOp)
CANONICALIZERS_AND_FOLDERS(IndexedGenericOp); CANONICALIZERS_AND_FOLDERS(IndexedGenericOp)
#include "mlir/Dialect/Linalg/IR/LinalgNamedStructuredOps.cpp.inc" #include "mlir/Dialect/Linalg/IR/LinalgNamedStructuredOps.cpp.inc"
// TODO: Determine whether we can generate the folders and verifiers. // TODO: Determine whether we can generate the folders and verifiers.
CANONICALIZERS_AND_FOLDERS(BatchMatmulOp); CANONICALIZERS_AND_FOLDERS(BatchMatmulOp)
CANONICALIZERS_AND_FOLDERS(DotOp); CANONICALIZERS_AND_FOLDERS(DotOp)
CANONICALIZERS_AND_FOLDERS(MatmulOp); CANONICALIZERS_AND_FOLDERS(MatmulOp)
CANONICALIZERS_AND_FOLDERS(MatvecOp); CANONICALIZERS_AND_FOLDERS(MatvecOp)
CANONICALIZERS_AND_FOLDERS(ConvWOp); CANONICALIZERS_AND_FOLDERS(ConvWOp)
CANONICALIZERS_AND_FOLDERS(ConvNWCOp); CANONICALIZERS_AND_FOLDERS(ConvNWCOp)
CANONICALIZERS_AND_FOLDERS(ConvNCWOp); CANONICALIZERS_AND_FOLDERS(ConvNCWOp)
CANONICALIZERS_AND_FOLDERS(ConvHWOp); CANONICALIZERS_AND_FOLDERS(ConvHWOp)
CANONICALIZERS_AND_FOLDERS(ConvNHWCOp); CANONICALIZERS_AND_FOLDERS(ConvNHWCOp)
CANONICALIZERS_AND_FOLDERS(ConvNCHWOp); CANONICALIZERS_AND_FOLDERS(ConvNCHWOp)
CANONICALIZERS_AND_FOLDERS(ConvDHWOp); CANONICALIZERS_AND_FOLDERS(ConvDHWOp)
CANONICALIZERS_AND_FOLDERS(ConvNDHWCOp); CANONICALIZERS_AND_FOLDERS(ConvNDHWCOp)
CANONICALIZERS_AND_FOLDERS(ConvNCDHWOp); CANONICALIZERS_AND_FOLDERS(ConvNCDHWOp)