This is an archive of the discontinued LLVM Phabricator instance.

[SVE] Lower fixed length vector integer subtract operations.
ClosedPublic

Authored by paulwalker-arm on Aug 10 2020, 10:07 AM.

Diff Detail

Event Timeline

paulwalker-arm requested review of this revision.Aug 10 2020, 10:07 AM
efriedma added inline comments.Aug 10 2020, 10:24 AM
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
3633

Is the change to ISD::ADD here related somehow?

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
3633

Only in that ADD and SUB should look pretty much identical and I didn't want to copy the "useSVE..." test, which I probably shouldn't have added in the first place for ADD.

Should I move this change into a separate patch?

efriedma accepted this revision.Aug 10 2020, 11:52 AM

It's fine. LGTM

This revision is now accepted and ready to land.Aug 10 2020, 11:52 AM