This is an archive of the discontinued LLVM Phabricator instance.

Differential D85515

[llvm-readobj] - Remove 3 excessive test cases.
ClosedPublic

Authored by grimar on Aug 7 2020, 3:49 AM.

Details

Reviewers
jhenderson
MaskRay
atanasyan
• espindola
Commits
rGcfd2ee29e0e2: [llvm-readobj] - Remove 3 excessive test cases.
Summary

This patch does the following:

  1. Removes mips-options.test and the corresponding Inputs/mips-options.elf-mips64el binary:

This is a test that checks that --dynamic-table is able to print the DT_MIPS_OPTIONS tag.
We are testing it in dynamic-tags-machine-specific.test already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L235)

  1. Removes mips-rld-map-rel.test and the corresponding Inputs/mips-rld-map-rel.elf-mipsel binary.

This is a test that checks that --dynamic-table is able to print the DT_MIPS_RLD_MAP_REL tag.
We are testing it in dynamic-tags-machine-specific.test already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L257)

  1. Removes ppc64-glink.test test and the corresponding Inputs/ppc64.exe binary.

This is a test that checks that --dynamic-table is able to print the DT_PPC64_GLINK tag.
We are testing it in dynamic-tags-machine-specific.test already.
(https://github.com/llvm/llvm-project/blob/master/llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test#L337)

Diff Detail

Event Timeline

grimar created this revision.Aug 7 2020, 3:49 AM
Herald added a reviewer: • espindola. · View Herald TranscriptAug 7 2020, 3:49 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, rupprecht, kbarton and 4 others. · View Herald Transcript
grimar requested review of this revision.Aug 7 2020, 3:49 AM
Herald added a subscriber: • wuzish. · View Herald TranscriptAug 7 2020, 3:49 AM
grimar added subscribers: grimar, evgeny777, ikudrin.Aug 7 2020, 3:49 AM
atanasyan accepted this revision.Aug 7 2020, 4:40 AM

LGTM

This revision is now accepted and ready to land.Aug 7 2020, 4:40 AM
Closed by commit rGcfd2ee29e0e2: [llvm-readobj] - Remove 3 excessive test cases. (authored by grimar). · Explain WhyAug 9 2020, 1:09 AM
This revision was automatically updated to reflect the committed changes.
grimar added a commit: rGcfd2ee29e0e2: [llvm-readobj] - Remove 3 excessive test cases..
Herald added a subscriber: jrtc27. · View Herald TranscriptAug 9 2020, 1:09 AM

Revision Contents

Diff 284176

llvm/test/tools/llvm-readobj/ELF/Inputs/mips-options.elf-mips64el

  • This binary file was deleted.

llvm/test/tools/llvm-readobj/ELF/Inputs/mips-rld-map-rel.elf-mipsel

  • This binary file was deleted.

llvm/test/tools/llvm-readobj/ELF/Inputs/ppc64.exe

  • This binary file was deleted.

llvm/test/tools/llvm-readobj/ELF/mips-options.test

  • This file was deleted.
## Check DT_MIPS_OPTIONS .dynamic section tag reading
# RUN: llvm-readobj --dynamic-table %p/Inputs/mips-options.elf-mips64el | \
# RUN: FileCheck %s
# CHECK: DynamicSection [ (14 entries)
# CHECK-NEXT: Tag Type Name/Value
# CHECK-NEXT: 0x0000000000000004 HASH 0x158
# CHECK-NEXT: 0x0000000000000005 STRTAB 0x1C0
# CHECK-NEXT: 0x0000000000000006 SYMTAB 0x178
# CHECK-NEXT: 0x000000000000000A STRSZ 7 (bytes)
# CHECK-NEXT: 0x000000000000000B SYMENT 24 (bytes)
# CHECK-NEXT: 0x0000000070000001 MIPS_RLD_VERSION 1
# CHECK-NEXT: 0x0000000070000005 MIPS_FLAGS NOTPOT
# CHECK-NEXT: 0x0000000070000006 MIPS_BASE_ADDRESS 0x0
# CHECK-NEXT: 0x000000007000000A MIPS_LOCAL_GOTNO 2
# CHECK-NEXT: 0x0000000070000011 MIPS_SYMTABNO 3
# CHECK-NEXT: 0x0000000070000013 MIPS_GOTSYM 0x3
# CHECK-NEXT: 0x0000000000000003 PLTGOT 0x2000
# CHECK-NEXT: 0x0000000070000029 MIPS_OPTIONS 0x1000
# CHECK-NEXT: 0x0000000000000000 NULL 0x0
# CHECK-NEXT: ]

llvm/test/tools/llvm-readobj/ELF/mips-rld-map-rel.test

  • This file was deleted.
## Check DT_MIPS_RLD_MAP_REL .dynamic section tag reading
# RUN: llvm-readobj --dynamic-table %p/Inputs/mips-rld-map-rel.elf-mipsel | \
# RUN: FileCheck %s
# CHECK: DynamicSection [ (16 entries)
# CHECK-NEXT: Tag Type Name/Value
# CHECK-NEXT: 0x00000004 HASH 0x220
# CHECK-NEXT: 0x00000005 STRTAB 0x2FC
# CHECK-NEXT: 0x00000006 SYMTAB 0x25C
# CHECK-NEXT: 0x0000000A STRSZ 72 (bytes)
# CHECK-NEXT: 0x0000000B SYMENT 16 (bytes)
# CHECK-NEXT: 0x70000035 MIPS_RLD_MAP_REL 0x101E0
# CHECK-NEXT: 0x00000015 DEBUG 0x0
# CHECK-NEXT: 0x00000003 PLTGOT 0x10390
# CHECK-NEXT: 0x70000001 MIPS_RLD_VERSION 1
# CHECK-NEXT: 0x70000005 MIPS_FLAGS NOTPOT
# CHECK-NEXT: 0x70000006 MIPS_BASE_ADDRESS 0x0
# CHECK-NEXT: 0x7000000A MIPS_LOCAL_GOTNO 2
# CHECK-NEXT: 0x70000011 MIPS_SYMTABNO 10
# CHECK-NEXT: 0x70000012 MIPS_UNREFEXTNO 15
# CHECK-NEXT: 0x70000013 MIPS_GOTSYM 0xA
# CHECK-NEXT: 0x00000000 NULL 0x0
# CHECK-NEXT: ]

llvm/test/tools/llvm-readobj/ELF/ppc64-glink.test

  • This file was deleted.
# Check DT_PPC64_GLINK dynamic tag.
RUN: llvm-readobj --dynamic-table %p/Inputs/ppc64.exe | FileCheck %s
CHECK: Format: elf64-powerpc
CHECK: Arch: powerpc64le
CHECK: AddressSize: 64bit
CHECK: DynamicSection [ (25 entries)
CHECK-NEXT: Tag Type Name/Value
CHECK: 0x0000000070000000 PPC64_GLINK 0x10000830
llvm/test/tools/llvm-readobj/ELF/Inputs/mips-rld-map-rel.elf-mipsel