This is an archive of the discontinued LLVM Phabricator instance.

Differential D84959

[NewPM][LVI] Abandon LVI after CVP
ClosedPublic

Authored by nikic on Jul 30 2020, 11:01 AM.

Details

Reviewers
asbirlea
aeubanks
ychen
tejohnson
Commits
rG25af353b0e74: [NewPM][LVI] Abandon LVI after CVP
Summary

As mentioned on D70376, LVI can currently cause performance issues when running under NewPM. The root problem is that, unlike the legacy pass manager, NewPM will not immediately discard the LVI analysis if the following pass does not need it. This is a problem, because LVI has a high memory requirement, and mass invalidation of LVI values is very inefficient. LVI should only be alive during passes that actively interact with it.

This patch addresses the issue by explicitly abandoning LVI after CVP, which gets us back to the LegacyPM behavior.

I don't think something like this is done anywhere else, so I'm wondering whether this kind of explicit abandonment of analysis passes under NewPM is acceptable.

Diff Detail

Unit TestsFailed

TimeTest
150 mslinux > Clang.CodeGen::thinlto-distributed-newpm.ll
1,100 mslinux > libFuzzer.libFuzzer::fuzzer-runs.test
630 mslinux > libomp.tasking::omp_task_red_taskloop.c
6,180 mswindows > Clang.CodeGen::thinlto-distributed-newpm.ll

Event Timeline

nikic created this revision.Jul 30 2020, 11:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2020, 11:01 AM
Herald added subscribers: llvm-commits, dexonsmith, steven_wu, hiraditya. · View Herald Transcript
nikic requested review of this revision.Jul 30 2020, 11:01 AM
aeubanks added inline comments.Jul 30 2020, 11:04 AM
llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
89

can we skip this option and update the pipeline tests?

tejohnson added a comment.Jul 30 2020, 11:17 AM

Thanks for the fix! I tend to agree with @aeubanks comment that it might be better to make this unconditional and change the tests (and the comment "Any invalidation that shows up here is a bug" that shows up at the top of at least one of the pipeline tests - it should probably just say something like "Any invalidation that shows up in a non-abandoned analysis is a bug".

Harbormaster completed remote builds in B66431: Diff 281986.Jul 30 2020, 11:49 AM
nikic added a comment.Jul 30 2020, 12:02 PM

Here is how updating one of the tests would look like: https://gist.github.com/nikic/577dead281f1aee10b492c3fc7130f5b

This would look nice if it only printed when an analysis actually gets invalidated, but I feel that the large number of "Invalidating all non-preserved analyses for" messages make this test worse.

tejohnson accepted this revision.Jul 30 2020, 12:31 PM
In D84959#2185560, @nikic wrote:

Here is how updating one of the tests would look like: https://gist.github.com/nikic/577dead281f1aee10b492c3fc7130f5b

This would look nice if it only printed when an analysis actually gets invalidated, but I feel that the large number of "Invalidating all non-preserved analyses for" messages make this test worse.

Agree that is ugly. I'm ok with using the option then. The patch LGTM (but looks like it needs a clang format). Please wait to see if @aeubanks has any more comments.

This revision is now accepted and ready to land.Jul 30 2020, 12:31 PM
aeubanks added a comment.Jul 30 2020, 1:03 PM

Hmm I wonder if we can just delete the "Invalidating all non-preserved analyses for" log statement, since "Invalidating analysis: FooAnalysis" does get printed when an analysis is actually invalidated. Or maybe at least only print it only when any analyses are actually invalidated (as you said). I'll take a quick look.

Also, looks like thinlto-distributed-newpm.ll is failing.

aeubanks mentioned this in D84981: [NewPM] Don't print 'Invalidating all non-preserved analyses'.Jul 30 2020, 1:55 PM
aeubanks added a comment.Jul 30 2020, 2:05 PM
In D84959#2185767, @aeubanks wrote:

Hmm I wonder if we can just delete the "Invalidating all non-preserved analyses for" log statement, since "Invalidating analysis: FooAnalysis" does get printed when an analysis is actually invalidated. Or maybe at least only print it only when any analyses are actually invalidated (as you said). I'll take a quick look.

Also, looks like thinlto-distributed-newpm.ll is failing.

Sorry, I think I misunderstood the issue. LazyValueAnalysis is actually being invalidated, right? So "Invalidating all non-preserved analyses for" would get printed regardless if we went with the option of only printing it when an analysis is actually invalidated.
What about removing all "Invalidating all non-preserved analyses for" and checking that there's no "Invalidating analysis: " aside from LazyValueAnalysis? That's probably worse than this solution...

asbirlea added a comment.Jul 30 2020, 5:53 PM

The additional debug print with "Invalidating all non-preserved analyses for" seems too noisy and not informative.
+1 on rebasing this without the no-lvi-abandon flag on D84981.

aeubanks added a comment.Jul 30 2020, 7:52 PM
In D84959#2186342, @asbirlea wrote:

The additional debug print with "Invalidating all non-preserved analyses for" seems too noisy and not informative.
+1 on rebasing this without the no-lvi-abandon flag on D84981.

It's been submitted now.

nikic updated this revision to Diff 282254.Jul 31 2020, 10:06 AM
nikic edited the summary of this revision. (Show Details)

Drop -lvi-no-abandon flag, update pipeline tests.

nikic added inline comments.Jul 31 2020, 10:07 AM
llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
244

The test diffs looks reasonable to me now, apart from this part. Is this expected?

aeubanks added inline comments.Jul 31 2020, 12:02 PM
llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
244

That is weird, I'll take a look.

tejohnson added inline comments.Jul 31 2020, 12:10 PM
llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
244

I was just looking at this. The message "Clearing all analysis results for: <possibly invalidated loop>" comes from the callsite to AnalysisManager<IRUnitT, ExtraArgTs...>::clear from LoopAnalysisManagerFunctionProxy::Result::invalidate. Looking at the conditions for that call, I'm guessing that the following is no longer true:
PAC.preservedSet<AllAnalysesOn<Function>>()
since the abandon() call will remove that ID from the preserved set.

So it is probably "expected" by the code change here. Not sure if there is a way to avoid it, i.e. is that code overly conservative.

aeubanks added a comment.Jul 31 2020, 12:17 PM

I had a random thought, maybe CVP itself shouldn't be invalidating LVI, but rather it should be explicitly invalidated in PassBuilder::buildFunctionSimplificationPipeline() with a InvalidateAnalysisPass<LazyValueAnalysis>. Since the description mentions that this is based on the knowledge that no passes after CVP will use LVI. ???

llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
244

DominatorTree::invalid() checks PAC.preserved() || PAC.preservedSet<AllAnalysesOn<Function>>() || PAC.preservedSet<CFGAnalyses>(). Even though PAC.preservedSet<AllAnalysesOn<Function>>() will be false, PAC.preserved() should still be true.

aeubanks added inline comments.Jul 31 2020, 12:32 PM
llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
244

Oh sorry, now I see what you mean, yes this is expected.
I don't follow the reasoning in the comments, but that's a different issue :)

aeubanks accepted this revision.Jul 31 2020, 12:51 PM
In D84959#2188060, @aeubanks wrote:

I had a random thought, maybe CVP itself shouldn't be invalidating LVI, but rather it should be explicitly invalidated in PassBuilder::buildFunctionSimplificationPipeline() with a InvalidateAnalysisPass<LazyValueAnalysis>. Since the description mentions that this is based on the knowledge that no passes after CVP will use LVI. ???

I'm not super familiar with the details, but if LVI should really always created on demand then immediately invalidated after CVP, then this lgtm.

tejohnson added a comment.Jul 31 2020, 1:24 PM
In D84959#2188097, @aeubanks wrote:
In D84959#2188060, @aeubanks wrote:

I had a random thought, maybe CVP itself shouldn't be invalidating LVI, but rather it should be explicitly invalidated in PassBuilder::buildFunctionSimplificationPipeline() with a InvalidateAnalysisPass<LazyValueAnalysis>. Since the description mentions that this is based on the knowledge that no passes after CVP will use LVI. ???

I'm not super familiar with the details, but if LVI should really always created on demand then immediately invalidated after CVP, then this lgtm.

Yeah I was pondering the same thing (since it looks like CVP is invoked twice per function), but presumably intermediate passes may hit the update compile time issue described in D70376. So I think for now this is a good approach to address the regression?

nikic added a comment.Aug 1 2020, 12:55 AM

I don't really know what the tradeoff would be between using abandon() here and using InvalidateAnalysisPass. I went with this variant as @asbirlea indicated in https://reviews.llvm.org/D70376#2151283 that this would be preferred, as InvalidateAnalysisPass is really more intended for testing purposes.

tejohnson accepted this revision.Aug 1 2020, 9:30 AM
In D84959#2188870, @nikic wrote:

I don't really know what the tradeoff would be between using abandon() here and using InvalidateAnalysisPass. I went with this variant as @asbirlea indicated in https://reviews.llvm.org/D70376#2151283 that this would be preferred, as InvalidateAnalysisPass is really more intended for testing purposes.

Yep, agree this is a good approach for now at least. Since the require is in CVP, logically it makes sense to abandon it there too. The only advantage of doing it in the pass pipeline setup would be if it made sense to abandoning it once after both CVP invocations, but that might not avoid the memory and compile time issues.

asbirlea added a comment.Aug 1 2020, 11:37 AM

This is ok to check in to resolve the regression.
I'll go back and check if that invalidate is overly conservative, but don't block in it.

Closed by commit rG25af353b0e74: [NewPM][LVI] Abandon LVI after CVP (authored by nikic). · Explain WhyAug 1 2020, 2:52 PM
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rG25af353b0e74: [NewPM][LVI] Abandon LVI after CVP.
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2020, 2:52 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ychen mentioned this in D85109: [NewPM] Clear abandoned analyses set when preserveSet is called.Aug 3 2020, 12:36 AM
ychen mentioned this in D85676: [NewPM] collapsing nested pass mangers of the same type.Aug 10 2020, 11:41 AM
ychen mentioned this in rG2c94d88e0769: [NewPM] collapsing nested pass mangers of the same type.Oct 4 2020, 3:58 PM

Revision Contents

Diff 281986

llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp

Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines
STATISTIC(NumShlNSW, "Number of no-signed-wrap deductions for shl"); STATISTIC(NumShlNSW, "Number of no-signed-wrap deductions for shl");
STATISTIC(NumShlNUW, "Number of no-unsigned-wrap deductions for shl"); STATISTIC(NumShlNUW, "Number of no-unsigned-wrap deductions for shl");
STATISTIC(NumOverflows, "Number of overflow checks removed"); STATISTIC(NumOverflows, "Number of overflow checks removed");
STATISTIC(NumSaturating, STATISTIC(NumSaturating,
"Number of saturating arithmetics converted to normal arithmetics"); "Number of saturating arithmetics converted to normal arithmetics");
static cl::opt<bool> DontAddNoWrapFlags("cvp-dont-add-nowrap-flags", cl::init(false)); static cl::opt<bool> DontAddNoWrapFlags("cvp-dont-add-nowrap-flags", cl::init(false));
// Allows disabling LVI abandoning for pipeline tests.
static cl::opt<bool> NoLVIAbandon(
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-static cl::opt<bool> NoLVIAbandon(
-    "no-lvi-abandon",
-    cl::desc("Do not abandon LVI after CVP"),
-    cl::init(false), cl::Hidden);
+static cl::opt<bool> NoLVIAbandon("no-lvi-abandon",
+                                  cl::desc("Do not abandon LVI after CVP"),
+                                  cl::init(false), cl::Hidden);
Lint: Pre-merge checks: clang-format: please reformat the code ``` -static cl::opt<bool> NoLVIAbandon( - "no-lvi…
aeubanksUnsubmitted
Not Done
ReplyInline Actions

can we skip this option and update the pipeline tests?

aeubanks: can we skip this option and update the pipeline tests?
"no-lvi-abandon",
cl::desc("Do not abandon LVI after CVP"),
cl::init(false), cl::Hidden);
namespace { namespace {
class CorrelatedValuePropagation : public FunctionPass { class CorrelatedValuePropagation : public FunctionPass {
public: public:
static char ID; static char ID;
CorrelatedValuePropagation(): FunctionPass(ID) { CorrelatedValuePropagation(): FunctionPass(ID) {
initializeCorrelatedValuePropagationPass(*PassRegistry::getPassRegistry()); initializeCorrelatedValuePropagationPass(*PassRegistry::getPassRegistry());
▲ Show 20 Lines • Show All 872 Lines • ▼ Show 20 Lines
PreservedAnalyses PreservedAnalyses
CorrelatedValuePropagationPass::run(Function &F, FunctionAnalysisManager &AM) { CorrelatedValuePropagationPass::run(Function &F, FunctionAnalysisManager &AM) {
LazyValueInfo *LVI = &AM.getResult<LazyValueAnalysis>(F); LazyValueInfo *LVI = &AM.getResult<LazyValueAnalysis>(F);
DominatorTree *DT = &AM.getResult<DominatorTreeAnalysis>(F); DominatorTree *DT = &AM.getResult<DominatorTreeAnalysis>(F);
bool Changed = runImpl(F, LVI, DT, getBestSimplifyQuery(AM, F)); bool Changed = runImpl(F, LVI, DT, getBestSimplifyQuery(AM, F));
if (!Changed)
return PreservedAnalyses::all();
PreservedAnalyses PA; PreservedAnalyses PA;
if (!Changed) {
PA = PreservedAnalyses::all();
} else {
PA.preserve<GlobalsAA>(); PA.preserve<GlobalsAA>();
PA.preserve<DominatorTreeAnalysis>(); PA.preserve<DominatorTreeAnalysis>();
PA.preserve<LazyValueAnalysis>(); PA.preserve<LazyValueAnalysis>();
}
// Keeping LVI alive is expensive, both because it uses a lot of memory, and
// because invalidating values in LVI is expensive. While CVP does preserve
// LVI, we know that passes after JumpThreading+CVP will not need the result
// of this analysis, so we forcefully discard it early.
if (!NoLVIAbandon)
PA.abandon<LazyValueAnalysis>();
return PA; return PA;
} }

llvm/test/Other/new-pm-defaults.ll

; The IR below was crafted so as: ; The IR below was crafted so as:
; 1) To have a loop, so we create a loop pass manager ; 1) To have a loop, so we create a loop pass manager
; 2) To be "immutable" in the sense that no pass in the standard ; 2) To be "immutable" in the sense that no pass in the standard
; pipeline will modify it. ; pipeline will modify it.
; Since no transformations take place, we don't expect any analyses ; Since no transformations take place, we don't expect any analyses
; to be invalidated. ; to be invalidated.
; Any invalidation that shows up here is a bug, unless we started modifying ; Any invalidation that shows up here is a bug, unless we started modifying
; the IR, in which case we need to make it immutable harder. ; the IR, in which case we need to make it immutable harder.
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='default<O1>' -S %s 2>&1 \ ; RUN: -passes='default<O1>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O1 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O1 \
; RUN: --check-prefix=%llvmcheckext ; RUN: --check-prefix=%llvmcheckext
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='default<O2>' -S %s 2>&1 \ ; RUN: -passes='default<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O2 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O2 \
; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext ; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext ; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='default<Os>' -S %s 2>&1 \ ; RUN: -passes='default<Os>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-Os \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-Os \
; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext ; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='default<Oz>' -S %s 2>&1 \ ; RUN: -passes='default<Oz>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-Oz \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-Oz \
; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext ; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='lto-pre-link<O2>' -S %s 2>&1 \ ; RUN: -passes='lto-pre-link<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O2 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O2 \
; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=CHECK-O23SZ --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-O2-LTO ; RUN: --check-prefix=CHECK-O2-LTO
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-peephole='no-op-function' \ ; RUN: -passes-ep-peephole='no-op-function' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-PEEPHOLE --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-PEEPHOLE --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-late-loop-optimizations='no-op-loop' \ ; RUN: -passes-ep-late-loop-optimizations='no-op-loop' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-LOOP-LATE --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-LOOP-LATE --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-loop-optimizer-end='no-op-loop' \ ; RUN: -passes-ep-loop-optimizer-end='no-op-loop' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-LOOP-END --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-LOOP-END --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-scalar-optimizer-late='no-op-function' \ ; RUN: -passes-ep-scalar-optimizer-late='no-op-function' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-SCALAR-LATE --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-SCALAR-LATE --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-cgscc-optimizer-late='no-op-cgscc' \ ; RUN: -passes-ep-cgscc-optimizer-late='no-op-cgscc' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-CGSCC-LATE --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-CGSCC-LATE --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-vectorizer-start='no-op-function' \ ; RUN: -passes-ep-vectorizer-start='no-op-function' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-VECTORIZER-START --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-VECTORIZER-START --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-pipeline-start='no-op-module' \ ; RUN: -passes-ep-pipeline-start='no-op-module' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-PIPELINE-START --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-PIPELINE-START --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-pipeline-start='no-op-module' \ ; RUN: -passes-ep-pipeline-start='no-op-module' \
; RUN: -passes='lto-pre-link<O3>' -S %s 2>&1 \ ; RUN: -passes='lto-pre-link<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-PIPELINE-START --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-PIPELINE-START --check-prefix=CHECK-O23SZ
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-optimizer-last='no-op-function' \ ; RUN: -passes-ep-optimizer-last='no-op-function' \
; RUN: -passes='default<O3>' -S %s 2>&1 \ ; RUN: -passes='default<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \ ; RUN: | FileCheck %s --check-prefix=CHECK-O --check-prefix=CHECK-O3 \
; RUN: --check-prefix=%llvmcheckext \ ; RUN: --check-prefix=%llvmcheckext \
; RUN: --check-prefix=CHECK-EP-OPTIMIZER-LAST --check-prefix=CHECK-O23SZ ; RUN: --check-prefix=CHECK-EP-OPTIMIZER-LAST --check-prefix=CHECK-O23SZ
; CHECK-O: Running analysis: PassInstrumentationAnalysis ; CHECK-O: Running analysis: PassInstrumentationAnalysis
; CHECK-O-NEXT: Starting llvm::Module pass manager run. ; CHECK-O-NEXT: Starting llvm::Module pass manager run.
▲ Show 20 Lines • Show All 226 Lines • Show Last 20 Lines

llvm/test/Other/new-pm-thinlto-defaults.ll

; The IR below was crafted so as: ; The IR below was crafted so as:
; 1) To have a loop, so we create a loop pass manager ; 1) To have a loop, so we create a loop pass manager
; 2) To be "immutable" in the sense that no pass in the standard ; 2) To be "immutable" in the sense that no pass in the standard
; pipeline will modify it. ; pipeline will modify it.
; Since no transformations take place, we don't expect any analyses ; Since no transformations take place, we don't expect any analyses
; to be invalidated. ; to be invalidated.
; Any invalidation that shows up here is a bug, unless we started modifying ; Any invalidation that shows up here is a bug, unless we started modifying
; the IR, in which case we need to make it immutable harder. ; the IR, in which case we need to make it immutable harder.
; ;
; Prelink pipelines: ; Prelink pipelines:
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto-pre-link<O1>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O1>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-O1 ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-O1
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-O2 ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-O2
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto-pre-link<O3>,name-anon-globals' -S -passes-ep-pipeline-start='no-op-module' %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O3>,name-anon-globals' -S -passes-ep-pipeline-start='no-op-module' %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-O3,CHECK-EP-PIPELINE-START ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-O3,CHECK-EP-PIPELINE-START
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto-pre-link<Os>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<Os>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-Os ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-Os
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto-pre-link<Oz>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<Oz>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-Oz ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O-NODIS,CHECK-PRELINK-Oz
; RUN: opt -disable-verify -debug-pass-manager -new-pm-debug-info-for-profiling \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -new-pm-debug-info-for-profiling \
; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-DIS,CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O2 ; RUN: | FileCheck %s --check-prefixes=CHECK-DIS,CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-PRELINK-O,CHECK-PRELINK-O2
; ;
; Postlink pipelines: ; Postlink pipelines:
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<O1>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O1>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O1 ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O1
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<O2>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O2 ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O2
; RUN: opt -disable-verify -debug-pass-manager -passes-ep-pipeline-start='no-op-module' \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-pipeline-start='no-op-module' \
; RUN: -passes='thinlto<O3>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O3 ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O3
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<Os>' -S %s 2>&1 \ ; RUN: -passes='thinlto<Os>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-Os ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-Os
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<Oz>' -S %s 2>&1 \ ; RUN: -passes='thinlto<Oz>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-Oz ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-Oz
; RUN: opt -disable-verify -debug-pass-manager -new-pm-debug-info-for-profiling \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -new-pm-debug-info-for-profiling \
; RUN: -passes='thinlto<O2>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O2 ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-POSTLINK-O,%llvmcheckext,CHECK-POSTLINK-O2
; ;
; CHECK-O: Running analysis: PassInstrumentationAnalysis ; CHECK-O: Running analysis: PassInstrumentationAnalysis
; CHECK-O-NEXT: Starting llvm::Module pass manager run. ; CHECK-O-NEXT: Starting llvm::Module pass manager run.
; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> ; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>
; CHECK-O-NEXT: Starting llvm::Module pass manager run. ; CHECK-O-NEXT: Starting llvm::Module pass manager run.
; CHECK-O-NEXT: Running pass: ForceFunctionAttrsPass ; CHECK-O-NEXT: Running pass: ForceFunctionAttrsPass
▲ Show 20 Lines • Show All 235 Lines • Show Last 20 Lines

llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll

; Validate ThinLTO post link pipeline when we have instrumentation PGO ; Validate ThinLTO post link pipeline when we have instrumentation PGO
; ;
; Postlink pipelines: ; Postlink pipelines:
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<O1>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O1>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<O2>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager -passes-ep-pipeline-start='no-op-module' \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-pipeline-start='no-op-module' \
; RUN: -passes='thinlto<O3>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<Os>' -S %s 2>&1 \ ; RUN: -passes='thinlto<Os>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes='thinlto<Oz>' -S %s 2>&1 \ ; RUN: -passes='thinlto<Oz>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager -new-pm-debug-info-for-profiling \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -new-pm-debug-info-for-profiling \
; RUN: -passes='thinlto<O2>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; ;
; CHECK-O: Running analysis: PassInstrumentationAnalysis ; CHECK-O: Running analysis: PassInstrumentationAnalysis
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> ; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
; CHECK-O-NEXT: Running pass: ForceFunctionAttrsPass ; CHECK-O-NEXT: Running pass: ForceFunctionAttrsPass
▲ Show 20 Lines • Show All 261 Lines • Show Last 20 Lines

llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll

; Validate ThinLTO postlink pipeline when we have Sample PGO ; Validate ThinLTO postlink pipeline when we have Sample PGO
; ;
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto<O1>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O1>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto<O2>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager -passes-ep-pipeline-start='no-op-module' \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -passes-ep-pipeline-start='no-op-module' \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto<O3>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O3>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto<Os>' -S %s 2>&1 \ ; RUN: -passes='thinlto<Os>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto<Oz>' -S %s 2>&1 \ ; RUN: -passes='thinlto<Oz>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager -new-pm-debug-info-for-profiling \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -new-pm-debug-info-for-profiling \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto<O2>' -S %s 2>&1 \ ; RUN: -passes='thinlto<O2>' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,%llvmcheckext --dump-input=fail
; ;
; CHECK-O: Running analysis: PassInstrumentationAnalysis ; CHECK-O: Running analysis: PassInstrumentationAnalysis
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> ; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
▲ Show 20 Lines • Show All 238 Lines • Show Last 20 Lines

llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll

; Validate ThinLTO prelink pipeline when we have instrumentation PGO ; Validate ThinLTO prelink pipeline when we have instrumentation PGO
; ;
; RUN: llvm-profdata merge %S/Inputs/new-pm-thinlto-prelink-pgo-defaults.proftext -o %t.profdata ; RUN: llvm-profdata merge %S/Inputs/new-pm-thinlto-prelink-pgo-defaults.proftext -o %t.profdata
; ;
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \ ; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \
; RUN: -passes='thinlto-pre-link<O1>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O1>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-O-NODIS,CHECK-O123 --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-O-NODIS,CHECK-O123 --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \ ; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \
; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123 --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123 --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \ ; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \
; RUN: -passes='thinlto-pre-link<O3>,name-anon-globals' -S -passes-ep-pipeline-start='no-op-module' %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O3>,name-anon-globals' -S -passes-ep-pipeline-start='no-op-module' %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123,CHECK-EP-PIPELINE-START --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123,CHECK-EP-PIPELINE-START --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \ ; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \
; RUN: -passes='thinlto-pre-link<Os>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<Os>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \ ; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \
; RUN: -passes='thinlto-pre-link<Oz>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<Oz>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager -new-pm-debug-info-for-profiling \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -new-pm-debug-info-for-profiling \
; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \ ; RUN: -pgo-kind=pgo-instr-use-pipeline -profile-file='%t.profdata' \
; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-DIS,CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O123 --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-DIS,CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O123 --dump-input=fail
; ;
; CHECK-O: Running analysis: PassInstrumentationAnalysis ; CHECK-O: Running analysis: PassInstrumentationAnalysis
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> ; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
▲ Show 20 Lines • Show All 201 Lines • ▼ Show 20 Lines
; CHECK-O-NEXT: Running pass: PrintModulePass ; CHECK-O-NEXT: Running pass: PrintModulePass
; Make sure we get the IR back out without changes when we print the module. ; Make sure we get the IR back out without changes when we print the module.
; CHECK-O-LABEL: define void @foo(i32 %n) local_unnamed_addr { ; CHECK-O-LABEL: define void @foo(i32 %n) local_unnamed_addr {
; CHECK-O-NEXT: entry: ; CHECK-O-NEXT: entry:
; CHECK-O-NEXT: br label %loop ; CHECK-O-NEXT: br label %loop
; CHECK-O: loop: ; CHECK-O: loop:
; CHECK-O-NEXT: %iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ] ; CHECK-O-NEXT: %iv = phi i32 [ 0, %entry ], [ %iv.next, %loop ]
; CHECK-O-NEXT: %iv.next = add i32 %iv, 1 ; CHECK-O-NEXT: %iv.next = add i32 %iv, 1
nikicAuthorUnsubmitted
Done
ReplyInline Actions

The test diffs looks reasonable to me now, apart from this part. Is this expected?

nikic: The test diffs looks reasonable to me now, apart from this part. Is this expected?
aeubanksUnsubmitted
Not Done
ReplyInline Actions

That is weird, I'll take a look.

aeubanks: That is weird, I'll take a look.
tejohnsonUnsubmitted
Not Done
ReplyInline Actions

I was just looking at this. The message "Clearing all analysis results for: <possibly invalidated loop>" comes from the callsite to AnalysisManager<IRUnitT, ExtraArgTs...>::clear from LoopAnalysisManagerFunctionProxy::Result::invalidate. Looking at the conditions for that call, I'm guessing that the following is no longer true:
PAC.preservedSet<AllAnalysesOn<Function>>()
since the abandon() call will remove that ID from the preserved set.

So it is probably "expected" by the code change here. Not sure if there is a way to avoid it, i.e. is that code overly conservative.

tejohnson: I was just looking at this. The message "Clearing all analysis results for: <possibly…
aeubanksUnsubmitted
Not Done
ReplyInline Actions

DominatorTree::invalid() checks PAC.preserved() || PAC.preservedSet<AllAnalysesOn<Function>>() || PAC.preservedSet<CFGAnalyses>(). Even though PAC.preservedSet<AllAnalysesOn<Function>>() will be false, PAC.preserved() should still be true.

aeubanks: `DominatorTree::invalid()` checks `PAC.preserved() || PAC.preservedSet<AllAnalysesOn<Function>>…
aeubanksUnsubmitted
Done
ReplyInline Actions

Oh sorry, now I see what you mean, yes this is expected.
I don't follow the reasoning in the comments, but that's a different issue :)

aeubanks: Oh sorry, now I see what you mean, yes this is expected. I don't follow the reasoning in the…
; CHECK-O-NEXT: tail call void @bar() ; CHECK-O-NEXT: tail call void @bar()
; CHECK-O-NEXT: %cmp = icmp eq i32 %iv, %n ; CHECK-O-NEXT: %cmp = icmp eq i32 %iv, %n
; CHECK-O-NEXT: br i1 %cmp, label %exit, label %loop ; CHECK-O-NEXT: br i1 %cmp, label %exit, label %loop
; CHECK-O: exit: ; CHECK-O: exit:
; CHECK-O-NEXT: ret void ; CHECK-O-NEXT: ret void
; CHECK-O-NEXT: } ; CHECK-O-NEXT: }
; ;
; Ignore a bunch of intervening metadata containing profile data. ; Ignore a bunch of intervening metadata containing profile data.
Show All 17 Lines

llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll

; Validate ThinLTO prelink pipeline when we have Sample PGO ; Validate ThinLTO prelink pipeline when we have Sample PGO
; ;
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto-pre-link<O1>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O1>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-O-NODIS,CHECK-O123 --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O1,CHECK-O-NODIS,CHECK-O123 --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123 --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123 --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto-pre-link<O3>,name-anon-globals' -S -passes-ep-pipeline-start='no-op-module' %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O3>,name-anon-globals' -S -passes-ep-pipeline-start='no-op-module' %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123,CHECK-EP-PIPELINE-START --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-O3,CHECK-O23SZ,CHECK-O-NODIS,CHECK-O123,CHECK-EP-PIPELINE-START --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto-pre-link<Os>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<Os>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Os,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto-pre-link<Oz>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<Oz>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-O,CHECK-Oz,CHECK-O23SZ,CHECK-O-NODIS --dump-input=fail
; RUN: opt -disable-verify -debug-pass-manager -new-pm-debug-info-for-profiling \ ; RUN: opt -disable-verify -debug-pass-manager -no-lvi-abandon \
; RUN: -new-pm-debug-info-for-profiling \
; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \ ; RUN: -pgo-kind=pgo-sample-use-pipeline -profile-file='%S/Inputs/new-pm-thinlto-samplepgo-defaults.prof' \
; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \ ; RUN: -passes='thinlto-pre-link<O2>,name-anon-globals' -S %s 2>&1 \
; RUN: | FileCheck %s --check-prefixes=CHECK-DIS,CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O123 --dump-input=fail ; RUN: | FileCheck %s --check-prefixes=CHECK-DIS,CHECK-O,CHECK-O2,CHECK-O23SZ,CHECK-O123 --dump-input=fail
; ;
; CHECK-O: Running analysis: PassInstrumentationAnalysis ; CHECK-O: Running analysis: PassInstrumentationAnalysis
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> ; CHECK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}>
; CHECK-O-NEXT: Starting {{.*}}Module pass manager run. ; CHECK-O-NEXT: Starting {{.*}}Module pass manager run.
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines