This is an archive of the discontinued LLVM Phabricator instance.

[NewPM] collapsing nested pass mangers of the same type
ClosedPublic

Authored by ychen on Aug 10 2020, 11:41 AM.

Details

Summary

This is one of the reason for extra invalidations in D84959. In
practice, I don't think we have use cases needing this. This simplifies
the pipeline a bit and prune corner cases when considering
invalidations.

Diff Detail

Event Timeline

ychen created this revision.Aug 10 2020, 11:41 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 10 2020, 11:41 AM
ychen requested review of this revision.Aug 10 2020, 11:41 AM
asbirlea accepted this revision.Aug 28 2020, 5:35 PM

Seems like a good idea. I'm curious if you saw any impact from this change.

This revision is now accepted and ready to land.Aug 28 2020, 5:35 PM
ychen added a comment.Sep 1 2020, 9:41 AM

Seems like a good idea. I'm curious if you saw any impact from this change.

Yeah, I'm curious too but I didn't measure it yet. What's the recommended ways to measure it?

This revision was landed with ongoing or failed builds.Oct 4 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.