Page MenuHomePhabricator

[analyzer] Fix out-of-tree only clang build by not relaying on private header
ClosedPublic

Authored by steakhal on Jul 30 2020, 3:31 AM.

Details

Summary

It turned out that the D78704 included a private LLVM header, which is excluded from the LLVM install target.
I'm substituting that #include with the public one by moving the necessary #define into that.
There was a discussion about this at D78704 and on the cfe-dev mailing list.

I'm also placing a note to remind others of this pitfall.

Diff Detail

Event Timeline

steakhal created this revision.Jul 30 2020, 3:31 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 30 2020, 3:31 AM
steakhal requested review of this revision.Jul 30 2020, 3:31 AM
mgorny accepted this revision.Jul 30 2020, 2:11 PM

Seems to work fine for me.

This revision is now accepted and ready to land.Jul 30 2020, 2:11 PM