Page MenuHomePhabricator

[MLIR] Forward extent tensors through shape.broadcast.
ClosedPublic

Authored by tpopp on Jul 29 2020, 3:25 AM.

Details

Summary

Allow shape.broadcast to return extent tensors when all inputs are extent tensors.

Diff Detail

Event Timeline

tpopp created this revision.Jul 29 2020, 3:25 AM
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
tpopp requested review of this revision.Jul 29 2020, 3:25 AM
herhut added a subscriber: herhut.Jul 29 2020, 6:12 AM
herhut added inline comments.
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
91–96

DBC: Can you add to the comment and stress the fact that the op may only return a tensor if we statically know that it cannot fail, either because it is guarded by a corresponding cstr_broadcastable or the construction otherwise ensures this?

frgossen accepted this revision.Jul 29 2020, 6:24 AM

Thanks

This revision was not accepted when it landed; it landed in state Needs Review.Jul 29 2020, 6:49 AM
This revision was automatically updated to reflect the committed changes.