Refactoring Slice class and function createUniversalBinary
from llvm-lipo into MachOUniversalWriter. This refactoring
is necessary so as to use the refactored code for creating
universal binaries under llvm-libtool-darwin.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tidy: LLVM_OBJECT_UNIVERSALBINARYWRITER_H -> LLVM_OBJECT_MACHOUNIVERSALWRITER_H
llvm/include/llvm/Object/MachOUniversalWriter.h | ||
---|---|---|
37 | explicit |
llvm/tools/llvm-lipo/llvm-lipo.cpp | ||
---|---|---|
46 | nit: 46, 47 can be replaced with reportError(Buf); |
llvm/tools/llvm-lipo/llvm-lipo.cpp | ||
---|---|---|
543 | What's the reason for not doing this sort inside writeUniversalBinary itself? |
llvm/tools/llvm-lipo/llvm-lipo.cpp | ||
---|---|---|
543 | Unless I'm missing something, it seems to be more natural / a better separation of concerns. |
LGTM
llvm/tools/llvm-lipo/llvm-lipo.cpp | ||
---|---|---|
543 | Got it. I was wondering because it seems like each call is doing the sorting. The separation of concerns makes sense though, and it's definitely nicer for writeUniversalBinary to not be mutating the Slices array. |
clang-tidy: warning: header guard does not follow preferred style [llvm-header-guard]
not useful