This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readelf] - Do not treat SHT_ANDROID_RELR sections the same as SHT_RELR.

Authored by grimar on Jul 23 2020, 3:49 AM.



Currently, when dumping section headers, llvm-readelf
prints "RELR" for SHT_ANDROID_RELR/SHT_RELR sections.
The behavior was introduced in D47919 and revealed in D84330.

But "SHT_ANDROID_RELR" has a different value from "SHT_RELR".
what makes the handling of the "SHT_ANDROID_RELR" inconsistent.

This patch makes llvm-readelf to print "ANDROID_RELR" instead of "RELR".

Diff Detail

Event Timeline

grimar created this revision.Jul 23 2020, 3:49 AM
Herald added a project: Restricted Project. · View Herald Transcript
jhenderson accepted this revision.Jul 23 2020, 4:31 AM

Looks good from my point of view, but others should have a chance to chime in.

This revision is now accepted and ready to land.Jul 23 2020, 4:31 AM
MaskRay accepted this revision.Jul 23 2020, 6:12 PM

Good from my point of view.