Some thoughts on how to implement this for object generation:
But if we want to break the existing practice (which could be a bigger change), we could consider using getQualNameSymbol as proxy of the MCSection.
As it is right now, if we seeking for minimum work and keep things consistent, we could set the visibility using getXCOFFSection. And if later we think it's important enough to pursue using getQualNameSymbol as proxy of the MCSection, we could do a refactoring at that time?
XCOFF::StorageMappingClass MappingClass; XCOFF::SymbolType Type; XCOFF::StorageClass StorageClass; XCOFF::VisibilityType VisibilityType = XCOFF::SYM_V_UNSPECIFIED;
in the MCSectionXCOFF class,
we need get the value of StorageClass, Type,MappingClass before we invoke the getXCOFFSection every time.
actually for the StorageClass, we can set the value of StorageClass when set the
if we want to refactor StorageClass later, I do not think we need to consistent with StorageClass in this patch. we can do NFC after this patch for StorageClass.
I don't want the setting of MCSectionXCOFF to be different for different property.