Page MenuHomePhabricator

[AIX][XCOFF] error on emit symbol visibility for XCOFF object file
ClosedPublic

Authored by daltenty on Apr 25 2022, 8:01 AM.

Details

Summary

This is a follow on to the revert of D84265 to add an error if we'd need to write a non-zero visibility type in the XCOFF object file. We can't currently do that because we lack the auxiliary header to interpret the bits in XCOFF32. This is important because we are currently working on visibility in the assembly writing path, and without this error the visibility could be silently ignored.

Diff Detail

Event Timeline

daltenty created this revision.Apr 25 2022, 8:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 8:01 AM
daltenty requested review of this revision.Apr 25 2022, 8:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2022, 8:01 AM
DiggerLin accepted this revision.Apr 25 2022, 8:46 AM
DiggerLin added inline comments.
llvm/lib/MC/XCOFFObjectWriter.cpp
681

minor. I am not sure whether it is better to "Emitting non-zero visibility are not supported yet" or not.

This revision is now accepted and ready to land.Apr 25 2022, 8:46 AM
This revision was landed with ongoing or failed builds.Apr 26 2022, 4:23 PM
This revision was automatically updated to reflect the committed changes.