Page MenuHomePhabricator

[ASTImporter] Refactor ASTImporter to support custom downstream tests
ClosedPublic

Authored by vabridgers on Jul 16 2020, 11:05 AM.

Details

Summary

The purpose of this change is to do a small refactoring of code in
ASTImporterTest.cpp by moving it to ASTImporterFixtures.h in order to
support tests of downstream custom types and minimize the "living
downstream burden" of frequent integrations from community to a
downstream repo that implements custom AST import tests.

Diff Detail

Event Timeline

vabridgers created this revision.Jul 16 2020, 11:05 AM
Herald added a reviewer: shafik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript

LGTM but I want @martong to take a look as well and accept.

@shafik, Thanks! I'll wait 'til Gabor gets a chance to review before landing. Best!

vabridgers added a subscriber: dkrupp.

Future improvement: Split ASTImporterTest.cpp into smaller parts. It is still too large.

martong accepted this revision.Jul 21 2020, 6:08 AM

Ok, LGTM! Thanks!

This revision is now accepted and ready to land.Jul 21 2020, 6:08 AM
This revision was automatically updated to reflect the committed changes.