Page MenuHomePhabricator

a.sidorin (Aleksei Sidorin)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 6:19 AM (240 w, 4 d)

Recent Activity

Oct 31 2018

a.sidorin added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

Hello everyone.
@martong : this version of patch reorders only fields and friends. No method reordering is done (I can check if it works, though, and add the feature).
@davide: Unfortunately, I was not able to reproduce the problem on Linux. Could you please provide a link to a buildbot failure or some environment description so I can reproduce the issue or, at least, take a look?

Oct 31 2018, 7:06 AM

Oct 29 2018

a.sidorin committed rL345545: [ASTImporter] Reorder fields after structure import is finished.
[ASTImporter] Reorder fields after structure import is finished
Oct 29 2018, 2:48 PM
a.sidorin committed rC345545: [ASTImporter] Reorder fields after structure import is finished.
[ASTImporter] Reorder fields after structure import is finished
Oct 29 2018, 2:48 PM
a.sidorin closed D44100: [ASTImporter] Reorder fields after structure import is finished.
Oct 29 2018, 2:48 PM

Oct 20 2018

a.sidorin committed rC344864: [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu….
[AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu…
Oct 20 2018, 3:51 PM
a.sidorin committed rL344864: [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu….
[AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu…
Oct 20 2018, 3:51 PM
a.sidorin closed D45416: [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu-extensions).
Oct 20 2018, 3:51 PM
a.sidorin committed rC344847: [NFC][Test commit] Fix typos in a comment.
[NFC][Test commit] Fix typos in a comment
Oct 20 2018, 7:49 AM
a.sidorin committed rL344847: [NFC][Test commit] Fix typos in a comment.
[NFC][Test commit] Fix typos in a comment
Oct 20 2018, 7:49 AM

Aug 22 2018

a.sidorin updated subscribers of D50616: [Fixed Point Arithmetic] FixedPointCast.

Accidentally noticed about this review via cfe-commits. @NoQ, the change in the ExprEngine looks a bit dangerous to me. Could you please check?

Aug 22 2018, 1:41 AM · Restricted Project

Aug 7 2018

a.sidorin accepted D49796: [ASTImporter] Load external Decls when getting field index..
Aug 7 2018, 8:09 AM

Aug 6 2018

a.sidorin accepted D49223: [AST] Check described template at structural equivalence check..

Hi Balazs,
I have only two nits. Otherwise, the patch is OK and can be committed without additional approval after the comments are fixed. Thank you!

Aug 6 2018, 10:21 AM · Restricted Project

Jul 11 2018

a.sidorin accepted D47946: [ASTImporter] Fix infinite recursion on function import with struct definition in parameters.

Hello Zoltán,

Jul 11 2018, 3:19 AM

Jul 2 2018

a.sidorin added a comment to D48722: [ASTImporter] Update isUsed flag at Decl import..

Whoops, sorry Balázs. Didn't look at the review author :(

Jul 2 2018, 10:50 AM
a.sidorin added a comment to D48722: [ASTImporter] Update isUsed flag at Decl import..

Hello Gabor,

Jul 2 2018, 10:49 AM

Jun 27 2018

a.sidorin added a comment to D47632: [ASTImporter] Refactor Decl creation.

Hi Gabor,

Jun 27 2018, 5:47 AM
a.sidorin requested changes to D48628: [AST] Structural equivalence of methods.

Hi Balázs,

Jun 27 2018, 5:42 AM
a.sidorin accepted D48631: [ASTImporter] Added import of CXXStdInitializerListExpr.

Looks good, thank you!

Jun 27 2018, 5:09 AM

Jun 26 2018

a.sidorin accepted D46944: [analyzer] Use sufficiently large types for index/size calculation..

Hi Bevin,

Jun 26 2018, 4:46 AM
a.sidorin accepted D47450: [ASTImporter] Use InjectedClassNameType at import of templated record..

LGTM!

Jun 26 2018, 3:14 AM
a.sidorin accepted D47459: [ASTImporter] Eliminated some unittest warnings..

Thank you!

Jun 26 2018, 2:56 AM
a.sidorin added a comment to D47632: [ASTImporter] Refactor Decl creation.

Hi Gabor!

Jun 26 2018, 2:48 AM

Jun 22 2018

a.sidorin added a comment to D47698: [ASTImporter] import macro source locations.

Hi Rafael,

Jun 22 2018, 9:04 AM
a.sidorin added a comment to D47698: [ASTImporter] import macro source locations.

Hi Rafael,

Jun 22 2018, 8:53 AM

Jun 4 2018

a.sidorin added a comment to D47532: [ASTImporter] Import the whole redecl chain of functions.

Hello Gabor,

Jun 4 2018, 11:20 AM

May 29 2018

a.sidorin requested changes to D47450: [ASTImporter] Use InjectedClassNameType at import of templated record..

You can find my comments inline.

May 29 2018, 11:43 AM
a.sidorin added a comment to D47367: [ASTImporter] Add ms compatibility to tests.

I meant that we can use this approach for testImport() too.

May 29 2018, 7:26 AM
a.sidorin abandoned D20118: Add support for injected class names and constructor initializers in C++.

This revision seems to be already committed in rC269693, without Differential Revision set.

May 29 2018, 7:24 AM · Restricted Project
a.sidorin commandeered D20118: Add support for injected class names and constructor initializers in C++.
May 29 2018, 7:19 AM · Restricted Project
a.sidorin accepted D47313: [ASTImporter] Corrected lookup at import of templated record decl.

LGTM too, thank you!
Do you need someone to commit this for you?

May 29 2018, 7:15 AM
a.sidorin updated subscribers of D46944: [analyzer] Use sufficiently large types for index/size calculation..

There are some results for clang and gcc max value for x86 and x64.
Source code:

const unsigned long long SIZE_MAX = (unsigned long long)(unsigned long)(-1);
const unsigned long long size = SIZE_MAX/2;
char arr[size+1];

Compiler output:

% g++ -c cast-comp.cpp -m32
cast-comp.cpp:6:16: error: size of array ‘arr’ is negative
 char arr[size+1];
                ^
% clang++-6.0 -c cast-comp.cpp -m32
% g++ -c cast-comp.cpp -m32        
cast-comp.cpp:6:16: error: size of array ‘arr’ is negative
 char arr[size+1];
                ^
% g++ -c cast-comp.cpp
cast-comp.cpp:6:16: error: size of array ‘arr’ is negative
 char arr[size+1];
                ^
% clang++-6.0 -c cast-comp.cpp
cast-comp.cpp:6:10: error: array is too large (9223372036854775808 elements)
char arr[size+1];
         ^~~~~~

So, clang accepts indices > SIZE_MAX/2 for x86.
For arr[size], only clang-x64 fails with error.
I think this means that we need to use LongLongTy as index type, not SizeType. @NoQ, what do you think?

May 29 2018, 6:51 AM
a.sidorin added a comment to D47367: [ASTImporter] Add ms compatibility to tests.

I think, it is overkill to test all possible combinations of the options, we should come up with something better here.

I agree with that. I think we need to test just import pairs {/*From*/no_option, /*To*/no_option}, {option_1, option1}, {option_2, option_2}, ...{option_n, option_n}.
Another option is to just turn -fno-delayed-template-parsing -fno-ms-compatibility for ASTImporter tests like it is done in some unit tests, but I'm not sure it's a correct solution.

May 29 2018, 5:01 AM
a.sidorin requested changes to D47459: [ASTImporter] Eliminated some unittest warnings..

Hello Balázs!

May 29 2018, 3:00 AM

May 28 2018

a.sidorin accepted D47445: [ASTImporter] Corrected diagnostic client handling in tests..

Looks good to me, but the approval from AST code owners is required, I think.

May 28 2018, 5:44 AM

May 25 2018

a.sidorin added inline comments to D46944: [analyzer] Use sufficiently large types for index/size calculation..
May 25 2018, 7:37 AM

May 24 2018

a.sidorin added a comment to D46950: [ASTImporter] Fix duplicate class template definitions problem.

Hm. Should we test -fms-compatibility in addition to -fdelayed-template-parsing?

May 24 2018, 10:55 AM
a.sidorin accepted D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC.

Ok, I got it, thank you!

May 24 2018, 10:43 AM

May 23 2018

a.sidorin accepted D46867: [ASTImporter] Add unit tests for structural equivalence.

Hi Gabor,

May 23 2018, 10:39 AM
a.sidorin added a comment to D46944: [analyzer] Use sufficiently large types for index/size calculation..

Hi Bevin,

May 23 2018, 10:31 AM

May 22 2018

a.sidorin added a comment to D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC.

Hi Gabor,
Could you add a test for TSK_Undeclared as well?

May 22 2018, 9:40 AM
a.sidorin accepted D47057: [ASTImporter] Fix missing implict CXXRecordDecl in ClassTemplateSpecializationDecl.

LGTM with a nit.

May 22 2018, 9:31 AM
a.sidorin accepted D46950: [ASTImporter] Fix duplicate class template definitions problem.

LGTM, thanks!

May 22 2018, 9:23 AM

May 18 2018

a.sidorin added inline comments to D47057: [ASTImporter] Fix missing implict CXXRecordDecl in ClassTemplateSpecializationDecl.
May 18 2018, 11:36 AM
a.sidorin requested changes to D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC.

(Sorry, accepted accidentially).

May 18 2018, 9:22 AM
a.sidorin accepted D47058: [ASTImporter] Fix ClassTemplateSpecialization in wrong DC.

Hi Gabor! I have a question.

May 18 2018, 9:21 AM
a.sidorin accepted D47069: [ASTImporter] Enable disabled but passing test.

Nice!

May 18 2018, 8:46 AM
a.sidorin added a reviewer for D46940: [ASTImporter] make sure that ACtx::getParents still works: aaron.ballman.
May 18 2018, 8:35 AM
a.sidorin accepted D46940: [ASTImporter] make sure that ACtx::getParents still works.

LGTM. Aaron, could you please confirm that AST changes are fine?

May 18 2018, 8:35 AM

May 16 2018

a.sidorin accepted D46958: [ASTImporter] Fix missing implict CXXRecordDecl.

So, we fail to add injected name to a CXXRecordDecl that has a described class template? Nice catch! LGTM.

May 16 2018, 9:59 AM
a.sidorin added a comment to D46950: [ASTImporter] Fix duplicate class template definitions problem.

Hello Gabor,

May 16 2018, 9:25 AM
a.sidorin added inline comments to D46944: [analyzer] Use sufficiently large types for index/size calculation..
May 16 2018, 8:57 AM
a.sidorin added inline comments to D46944: [analyzer] Use sufficiently large types for index/size calculation..
May 16 2018, 8:09 AM
a.sidorin added a comment to D46944: [analyzer] Use sufficiently large types for index/size calculation..

This is a nice extension of D16063.

May 16 2018, 8:06 AM
a.sidorin added a comment to D46940: [ASTImporter] make sure that ACtx::getParents still works.

Hello Rafael,

May 16 2018, 7:34 AM
a.sidorin added a comment to D44100: [ASTImporter] Reorder fields after structure import is finished.

Ping.

May 16 2018, 7:20 AM
a.sidorin added a comment to D46867: [ASTImporter] Add unit tests for structural equivalence.

Hello Gabor!

May 16 2018, 6:51 AM

May 15 2018

a.sidorin committed rL332338: [ASTImporter] Extend lookup logic in class templates.
[ASTImporter] Extend lookup logic in class templates
May 15 2018, 4:14 AM
a.sidorin committed rC332338: [ASTImporter] Extend lookup logic in class templates.
[ASTImporter] Extend lookup logic in class templates
May 15 2018, 4:14 AM
a.sidorin closed D46353: [ASTImporter] Extend lookup logic in class templates.
May 15 2018, 4:14 AM
a.sidorin added reviewers for D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext: rsmith, aaron.ballman.
May 15 2018, 12:51 AM
a.sidorin added a comment to D46835: [ASTImporter] Do not try to remove invisible Decls from DeclContext.

Hi Gabor,

May 15 2018, 12:51 AM

May 14 2018

a.sidorin closed D46398: [ASTImporterTest] Fix potential use-after-free.

Closed with rC332256.

May 14 2018, 11:56 PM
a.sidorin committed rL332256: [ASTImporter] Turn StringRefs back to std::strings to avoid use-after-free.
[ASTImporter] Turn StringRefs back to std::strings to avoid use-after-free
May 14 2018, 9:16 AM
a.sidorin committed rC332256: [ASTImporter] Turn StringRefs back to std::strings to avoid use-after-free.
[ASTImporter] Turn StringRefs back to std::strings to avoid use-after-free
May 14 2018, 9:16 AM
a.sidorin accepted D46353: [ASTImporter] Extend lookup logic in class templates.

should we add this new declaration to the redeclaration chain like we do it for RecordDecls?

I think, on a long term we should. Otherwise we could loose e.g. C++11 attributes which are attached to the forward declaration only.
However, I'd do that as a separate commit, because that would require some independent changes and tests, also other decl kinds like ClassTemplateSepcializationDecl may be affected as well by that.

May 14 2018, 8:32 AM
a.sidorin added a comment to D45416: [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu-extensions).

Gentle ping.

May 14 2018, 7:13 AM
a.sidorin updated the diff for D46398: [ASTImporterTest] Fix potential use-after-free.

Add forgotten context.

May 14 2018, 6:29 AM
a.sidorin updated the diff for D46398: [ASTImporterTest] Fix potential use-after-free.

After a number of attempts of Twine'ifying all Code samples, I decided to restore the initial state of this code.

May 14 2018, 6:22 AM

May 11 2018

a.sidorin resigned from D46740: [Clang Tablegen][RFC] Allow Early Textual Substitutions in `Diagnostic` messages..
May 11 2018, 1:38 AM

May 8 2018

a.sidorin committed rC331762: [ASTImporter] Properly import SourceLocations of Attrs.
[ASTImporter] Properly import SourceLocations of Attrs
May 8 2018, 5:49 AM
a.sidorin committed rL331762: [ASTImporter] Properly import SourceLocations of Attrs.
[ASTImporter] Properly import SourceLocations of Attrs
May 8 2018, 5:49 AM
a.sidorin closed D46115: [ASTImporter] properly import SrcLoc of Attr.
May 8 2018, 5:48 AM
a.sidorin accepted D46115: [ASTImporter] properly import SrcLoc of Attr.

Looks good!

May 8 2018, 2:34 AM

May 7 2018

a.sidorin added a comment to D46115: [ASTImporter] properly import SrcLoc of Attr.

Sorry, two more nits.

May 7 2018, 10:13 AM
a.sidorin added a comment to D46115: [ASTImporter] properly import SrcLoc of Attr.

Hi Rafael! Please find my comments inline.

May 7 2018, 10:10 AM

May 4 2018

a.sidorin added a comment to D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer.

Hi Rafael! I like the change.

May 4 2018, 8:59 AM
a.sidorin accepted D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.

LGTM!

May 4 2018, 6:12 AM
a.sidorin updated subscribers of D46398: [ASTImporterTest] Fix potential use-after-free.

Hi Gabor,

May 4 2018, 4:03 AM

May 3 2018

a.sidorin created D46398: [ASTImporterTest] Fix potential use-after-free.
May 3 2018, 11:00 AM
a.sidorin added a comment to D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter.

I see,t hank you. Please feel free to submit a patch - it seems like you already have a nice test case that shows the difference between two import options.

May 3 2018, 9:39 AM
a.sidorin added a comment to D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.

Hello Peter! This looks almost OK, just some minor formatting issues.

May 3 2018, 7:40 AM
a.sidorin added a comment to D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter.

Hi Rafael,

May 3 2018, 7:29 AM
a.sidorin added a comment to D46353: [ASTImporter] Extend lookup logic in class templates.

Hello Gabor,

May 3 2018, 7:15 AM
a.sidorin updated the diff for D45416: [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu-extensions).

Transform AST instead.
I don't remove analyzer guys from reviewers because the test is still for the analyzer.
@rsmith Feel free to correct me if I'm doing something wrong.

May 3 2018, 4:20 AM
a.sidorin resigned from D46351: StructurizeCFG: fix inverting conditions.

Malformed Herald rule, sorry.

May 3 2018, 1:33 AM

Apr 27 2018

a.sidorin added a comment to D44934: [analyzer] Improve the modeling of `memset()`..

Hi Henry. I had a quick look at the patch, here are some remarks.

Apr 27 2018, 11:54 AM
a.sidorin added a comment to D46115: [ASTImporter] properly import SrcLoc of Attr.

Hi all. I'm already here, invited by the Herald - just had no time to take a look (will change the script to add me as a reviewer). But thank you anyway! :)

Apr 27 2018, 9:13 AM

Apr 26 2018

a.sidorin requested changes to D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr.
Apr 26 2018, 5:25 AM

Apr 25 2018

a.sidorin added inline comments to D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call.
Apr 25 2018, 11:15 AM
a.sidorin added a comment to D46019: [ASTImporter] Fix isa cast assert.

Confirming LGTM, no objections. Thank you!

Apr 25 2018, 10:47 AM
a.sidorin updated the diff for D45416: [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu-extensions).

Add a test for CFG dump; replace static_cast with an initialization.
No test failures on check-all were observed.

Apr 25 2018, 10:27 AM
a.sidorin added a comment to D46019: [ASTImporter] Fix isa cast assert.

E->getFoundDecl().getDecl() can be null when a member expression does not involve lookup. (Note, it may involve a lookup in case of a using directive which refers to a member function in a base class template.)

Yes, a pretty weird example. Unfortunately, they are pretty common for XTU.

Apr 25 2018, 4:03 AM
a.sidorin accepted D32947: [ASTImporter] FriendDecl importing improvements.
Apr 25 2018, 2:14 AM
a.sidorin added a comment to D32947: [ASTImporter] FriendDecl importing improvements.

Looks good to me as well. Thank you!

Apr 25 2018, 2:14 AM

Apr 24 2018

a.sidorin added a comment to D46007: [analyzer] Add `TaintBugVisitor` to the ArrayBoundV2, DivideZero and VLASize..

Mostly LG.

Apr 24 2018, 10:23 AM
a.sidorin accepted D46019: [ASTImporter] Fix isa cast assert.

This LGTM, but could you please add a test?

Apr 24 2018, 10:06 AM
a.sidorin committed rC330704: [ASTImporter] Allow testing of import sequences; fix import of typedefs for….
[ASTImporter] Allow testing of import sequences; fix import of typedefs for…
Apr 24 2018, 3:15 AM
a.sidorin committed rL330704: [ASTImporter] Allow testing of import sequences; fix import of typedefs for….
[ASTImporter] Allow testing of import sequences; fix import of typedefs for…
Apr 24 2018, 3:15 AM
a.sidorin closed D44079: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls.
Apr 24 2018, 3:15 AM
a.sidorin added a comment to D45839: [analyzer] Add support for WebKit "unified sources"..

Hi Artem. Cool patch!

Apr 24 2018, 1:38 AM