Page MenuHomePhabricator

[ASTImporter] Add Visitor for TypedefNameDecl's
ClosedPublic

Authored by vabridgers on Jul 16 2020, 3:58 PM.

Details

Summary

We found a case where Typedef Name Declarations were not being added
correctly when importing builtin types. This exposed the need for a
TypedefNameDecl visitor so these types can be added by RecordDecl and
fields.

This code is covered by the ASTImporterTest cases that use the implicit
struct __NSConstantString_tag definitions.

Thanks to @martong for the debugging assist!

Depends on D83970.

Diff Detail

Event Timeline

vabridgers created this revision.Jul 16 2020, 3:58 PM
Herald added a project: Restricted Project. · View Herald Transcript

Fix lint pre-merge check

I discussed with Gabor. We don't feel comfortable landing this without a covering negative test case, so I'll work on that a little more, see what I can come up with. Thanks Gabor!

Adding negative test case that exposes the original problem.

martong accepted this revision.Jul 28 2020, 8:37 AM

LGTM! Thanks for the test!

This revision is now accepted and ready to land.Jul 28 2020, 8:37 AM