Page MenuHomePhabricator

vabridgers (Vince Bridgers)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 28 2019, 3:56 PM (25 w, 6 d)

Recent Activity

Apr 15 2020

einvbri <vince.a.bridgers@ericsson.com> committed rG789215dc0db1: [ASTImporter] Add support for importing fixed point literals (authored by vabridgers).
[ASTImporter] Add support for importing fixed point literals
Apr 15 2020, 8:46 AM
vabridgers closed D77721: [ASTImporter] Add support for importing fixed point literals.
Apr 15 2020, 8:45 AM · Restricted Project

Apr 14 2020

einvbri <vince.a.bridgers@ericsson.com> committed rG161fc1d9118f: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals. (authored by vabridgers).
[Fixed Point] [AST] Add an AST serialization code for fixed-point literals.
Apr 14 2020, 11:51 AM
vabridgers closed D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals..
Apr 14 2020, 11:51 AM · Restricted Project
vabridgers added a comment to D77721: [ASTImporter] Add support for importing fixed point literals.

Do these changes look ok to land? https://reviews.llvm.org/D57226 is pushed. Thanks!

Apr 14 2020, 11:50 AM · Restricted Project
vabridgers updated the diff for D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals..

update based on comments from rjmccall

Apr 14 2020, 4:45 AM · Restricted Project
vabridgers added a comment to D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals..

Thank you for the comments. Please do let me know when this patch is ready to land. Best!

Apr 14 2020, 4:45 AM · Restricted Project

Apr 13 2020

vabridgers updated the diff for D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals..

Address comments from rjmccall

Apr 13 2020, 8:06 PM · Restricted Project

Apr 9 2020

vabridgers added a comment to D49074: [Analyzer] Basic support for multiplication and division in the constraint manager.

ping! Any chance of this patch being accepted? This patch can help some SA false positives.

Apr 9 2020, 4:02 PM
vabridgers added a comment to D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only).

ping! Any chance of this patch being accepted? This patch can help some SA false positives.

Apr 9 2020, 4:02 PM
vabridgers updated the diff for D77721: [ASTImporter] Add support for importing fixed point literals.

Incorporate Gabor's suggestion for improving test coverage

Apr 9 2020, 11:24 AM · Restricted Project
vabridgers added a comment to D77721: [ASTImporter] Add support for importing fixed point literals.

Ahhh yes, I see. I can get this done while we're waiting on https://reviews.llvm.org/D57226 to land. Thanks Gabor!!

Apr 9 2020, 10:17 AM · Restricted Project
vabridgers updated the diff for D77721: [ASTImporter] Add support for importing fixed point literals.

Address comment from @balazske

Apr 9 2020, 3:46 AM · Restricted Project

Apr 8 2020

vabridgers updated the diff for D77721: [ASTImporter] Add support for importing fixed point literals.

Remove extraneous code :/

Apr 8 2020, 4:18 PM · Restricted Project
vabridgers updated the diff for D77721: [ASTImporter] Add support for importing fixed point literals.

Addressed comments from @balazske.
Thanks for the tips and useful starting point from @martong

Apr 8 2020, 4:18 PM · Restricted Project
vabridgers added a comment to D77721: [ASTImporter] Add support for importing fixed point literals.

@balazske, Thank you for the comments. I'll address and repost the review.

Apr 8 2020, 7:02 AM · Restricted Project
vabridgers added a comment to D77721: [ASTImporter] Add support for importing fixed point literals.

Landing this change depends on https://reviews.llvm.org/D57226 to be pushed. Please review for now, and I'll be sure to push this only after https://reviews.llvm.org/D57226 is pushed. Thanks!

Apr 8 2020, 5:23 AM · Restricted Project
vabridgers created D77721: [ASTImporter] Add support for importing fixed point literals.
Apr 8 2020, 5:23 AM · Restricted Project
vabridgers added a comment to D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals..

https://reviews.llvm.org/D77721 depends on this serialization change for fixed point literals.

Apr 8 2020, 5:23 AM · Restricted Project

Apr 7 2020

vabridgers added a comment to D77507: [clangd] Fix HitMapping assertion in Tokens.cpp.

ayup, no problem and thanks for the fix. I'll abandon this change. Best!

Apr 7 2020, 5:55 AM · Restricted Project

Apr 6 2020

vabridgers added a comment to D77507: [clangd] Fix HitMapping assertion in Tokens.cpp.

Thank you for the comments. I'll keep looking at this to find a proper fix, but any hints you may have would be greatly appreciated (debugging tips, strategies, areas of code to focus on). This code is new to me, so I may not be as efficient at tracking this down as yourself or Ilya. Best!

Apr 6 2020, 9:12 AM · Restricted Project

Apr 5 2020

vabridgers updated the diff for D77507: [clangd] Fix HitMapping assertion in Tokens.cpp.

Remove extraneous test case

Apr 5 2020, 1:53 PM · Restricted Project
vabridgers created D77507: [clangd] Fix HitMapping assertion in Tokens.cpp.
Apr 5 2020, 12:16 PM · Restricted Project

Mar 30 2020

einvbri <vince.a.bridgers@ericsson.com> committed rGdefd95ef4517: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check (authored by vabridgers).
[analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check
Mar 30 2020, 12:32 PM
vabridgers closed D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check.
Mar 30 2020, 12:31 PM · Restricted Project

Mar 29 2020

vabridgers updated the diff for D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check.

fix pre-merge lint checks

Mar 29 2020, 10:40 AM · Restricted Project
vabridgers updated the diff for D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check.

fix pre-merge lint checks

Mar 29 2020, 7:59 AM · Restricted Project
vabridgers created D77012: [analyzer] Fix StdLibraryFunctionsChecker NotNull Constraint Check.
Mar 29 2020, 6:22 AM · Restricted Project

Mar 13 2020

vabridgers added a comment to D75529: [analyzer] Limit UCharMax to min of max uchar or max int.

@Charusso -- I do not have commit access, but I will request. Thank you.

Mar 13 2020, 10:44 AM · Restricted Project

Mar 12 2020

vabridgers added a comment to D75529: [analyzer] Limit UCharMax to min of max uchar or max int.

I believe all comments have been addressed. Please let me know if there's anything else required. Thanks

Mar 12 2020, 5:43 PM · Restricted Project
vabridgers updated the diff for D75529: [analyzer] Limit UCharMax to min of max uchar or max int.

fix pre merge checkswq

Mar 12 2020, 5:43 PM · Restricted Project

Mar 11 2020

vabridgers updated the diff for D75529: [analyzer] Limit UCharMax to min of max uchar or max int.

Address Artem's comments.

Mar 11 2020, 10:45 AM · Restricted Project

Mar 9 2020

vabridgers added a comment to D75529: [analyzer] Limit UCharMax to min of max uchar or max int.

@Charusso, I cannot find a way to create a test for this change, since this was found using an architecture that supports 16-bit chars. I understand the need to create test cases for changes. In this case, I believe a rationale for accepting this change is to conform to the C Standard, and accept that upstream clang does not have a way to test for architectures supporting 16-bit characters, or otherwise "peculiar" datatypes.

Mar 9 2020, 10:13 AM · Restricted Project

Mar 3 2020

vabridgers added inline comments to D75529: [analyzer] Limit UCharMax to min of max uchar or max int.
Mar 3 2020, 9:39 AM · Restricted Project
vabridgers updated the diff for D75529: [analyzer] Limit UCharMax to min of max uchar or max int.

Address review comments

Mar 3 2020, 9:39 AM · Restricted Project
vabridgers created D75529: [analyzer] Limit UCharMax to min of max uchar or max int.
Mar 3 2020, 8:06 AM · Restricted Project

Nov 28 2019

vabridgers created D70836: [analysis] Fix value tracking for pointers to qualified types.
Nov 28 2019, 6:00 PM · Restricted Project