Page MenuHomePhabricator

vabridgers (Vince Bridgers)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 28 2019, 3:56 PM (135 w, 18 h)

Recent Activity

Tue, Jun 7

vabridgers updated the summary of D127105: [analyzer] Fix null pointer deref in CastValueChecker.
Tue, Jun 7, 8:20 AM · Restricted Project, Restricted Project
vabridgers added a comment to D127105: [analyzer] Fix null pointer deref in CastValueChecker.

I think all comments have been addressed, please let me know if I missed some detail :) Best!

Tue, Jun 7, 8:19 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D127105: [analyzer] Fix null pointer deref in CastValueChecker.

address @steakhal comments

Tue, Jun 7, 8:18 AM · Restricted Project, Restricted Project
vabridgers added inline comments to D127105: [analyzer] Fix null pointer deref in CastValueChecker.
Tue, Jun 7, 5:43 AM · Restricted Project, Restricted Project
vabridgers updated the summary of D127105: [analyzer] Fix null pointer deref in CastValueChecker.
Tue, Jun 7, 2:39 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D127105: [analyzer] Fix null pointer deref in CastValueChecker.

Use QualType::getAsString() per suggestion from martong

Tue, Jun 7, 2:37 AM · Restricted Project, Restricted Project

Mon, Jun 6

vabridgers updated the summary of D127105: [analyzer] Fix null pointer deref in CastValueChecker.
Mon, Jun 6, 5:28 PM · Restricted Project, Restricted Project
vabridgers added a comment to D127105: [analyzer] Fix null pointer deref in CastValueChecker.

I was able to find and add a covering test case. I understand the fix may not be "correct", but it does avoid the crash demonstrated by the test case.

Mon, Jun 6, 3:36 PM · Restricted Project, Restricted Project
vabridgers updated the diff for D127105: [analyzer] Fix null pointer deref in CastValueChecker.

add test case

Mon, Jun 6, 3:35 PM · Restricted Project, Restricted Project
vabridgers planned changes to D127105: [analyzer] Fix null pointer deref in CastValueChecker.

I know this will need a reproducer, and I'm working on that. That work is still in progress.

Mon, Jun 6, 11:40 AM · Restricted Project, Restricted Project
vabridgers requested review of D127105: [analyzer] Fix null pointer deref in CastValueChecker.
Mon, Jun 6, 5:39 AM · Restricted Project, Restricted Project

May 5 2022

vabridgers added a comment to D124349: [analyzer] Get direct binding for specific punned case.

Thanks @martong. I fixed the "typo" :/, landing. Best!

May 5 2022, 2:48 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D124349: [analyzer] Get direct binding for specific punned case.

fix a stupid leftover cut/paste mistake in the test case :/

May 5 2022, 2:47 AM · Restricted Project, Restricted Project

May 4 2022

vabridgers updated the diff for D124349: [analyzer] Get direct binding for specific punned case.

Address comments from @martong

May 4 2022, 12:33 PM · Restricted Project, Restricted Project
vabridgers added a comment to D124349: [analyzer] Get direct binding for specific punned case.

Thanks for the comments! Per our discussion, I'll create a different test case with a pinned target and add the additional test case to be sure we see expected behavior. Best!

May 4 2022, 11:34 AM · Restricted Project, Restricted Project

Apr 27 2022

vabridgers added a comment to D124349: [analyzer] Get direct binding for specific punned case.

polite ping to @NoQ and/or @martong. @steakhal is ok with this change, are you ok if I land this? Thanks!

Apr 27 2022, 3:38 AM · Restricted Project, Restricted Project

Apr 26 2022

vabridgers added a reviewer for D124349: [analyzer] Get direct binding for specific punned case: martong.
Apr 26 2022, 2:58 AM · Restricted Project, Restricted Project

Apr 25 2022

vabridgers updated the diff for D124349: [analyzer] Get direct binding for specific punned case.

update LIT per comments from @steakhal

Apr 25 2022, 1:36 AM · Restricted Project, Restricted Project
vabridgers added inline comments to D124349: [analyzer] Get direct binding for specific punned case.
Apr 25 2022, 1:30 AM · Restricted Project, Restricted Project

Apr 24 2022

vabridgers updated the diff for D124349: [analyzer] Get direct binding for specific punned case.

clang-format

Apr 24 2022, 12:16 PM · Restricted Project, Restricted Project
vabridgers requested review of D124349: [analyzer] Get direct binding for specific punned case.
Apr 24 2022, 12:14 PM · Restricted Project, Restricted Project

Apr 23 2022

vabridgers updated the diff for D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

add back amdgcn cases

Apr 23 2022, 2:45 PM · Restricted Project, Restricted Project
vabridgers retitled D123464: [analyzer] Clean checker options from DefaultBool to bool (NFC) from [analyzer] Clean checker options from bool to DefaultBool (NFC) to [analyzer] Clean checker options from DefaultBool to bool (NFC).
Apr 23 2022, 12:48 PM · Restricted Project, Restricted Project
vabridgers added a comment to D123464: [analyzer] Clean checker options from DefaultBool to bool (NFC).

Hi @steakhal, I believe I've addressed the comments. Please have a look and let me know if this is what you were after. Best!

Apr 23 2022, 7:36 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D123464: [analyzer] Clean checker options from DefaultBool to bool (NFC).

refactor patch to remove DefaultBool, replace with bool as suggested

Apr 23 2022, 7:34 AM · Restricted Project, Restricted Project
vabridgers added a comment to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

I believe all comments have been addressed. After discussion with @steakhal, we're leaning towards removing the DefaultBool class and refactoring in favor of the language native bool type - mainly because DefaultBool doesn't add anything. Minimal yet effective is usually better.

Apr 23 2022, 3:32 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

Update test cases, address comments

Apr 23 2022, 3:29 AM · Restricted Project, Restricted Project

Apr 10 2022

vabridgers requested review of D123464: [analyzer] Clean checker options from DefaultBool to bool (NFC).
Apr 10 2022, 5:48 AM · Restricted Project, Restricted Project

Apr 9 2022

vabridgers added a comment to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

The two small issues are addressed, I think the only outstanding issue is the question about the test case. Please let me know a preference and I'll implement accordingly. Best!

Apr 9 2022, 4:08 PM · Restricted Project, Restricted Project
vabridgers updated the diff for D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

update per @steakhal's latest comments

Apr 9 2022, 4:07 PM · Restricted Project, Restricted Project
vabridgers planned changes to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

Thanks for the the comments. I'll make the changes and resubmit. Please let me know your preferences for the test case (default vs pinned x86 or same).

Apr 9 2022, 1:46 PM · Restricted Project, Restricted Project
vabridgers added a comment to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

I believe all points have been addressed. Thanks for the comments.

Apr 9 2022, 2:46 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

update per @steakhal's comments

Apr 9 2022, 2:45 AM · Restricted Project, Restricted Project

Apr 8 2022

vabridgers planned changes to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.
Apr 8 2022, 2:46 PM · Restricted Project, Restricted Project
vabridgers added a comment to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

I'll address, thanks for the comments.

Apr 8 2022, 2:46 PM · Restricted Project, Restricted Project
vabridgers updated the diff for D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

clean up a few debug edits

Apr 8 2022, 7:25 AM · Restricted Project, Restricted Project
vabridgers retitled D122841: [analyzer] Add option for AddrSpace in core.NullDereference check from [analyzer] Consider all addrspaces in null dereference check to [analyzer] Add option for AddrSpace in core.NullDereference check.
Apr 8 2022, 7:23 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

add option, retain legacy behavior per comments. update rst

Apr 8 2022, 7:22 AM · Restricted Project, Restricted Project

Apr 6 2022

vabridgers added a comment to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

Ahhh, I see - thanks for the references and discussion. I'll craft a patch to comprehend the use case and user-facing option, and post for review. We'll see how it goes :)

Apr 6 2022, 5:37 AM · Restricted Project, Restricted Project

Mar 31 2022

vabridgers added a comment to D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.

@steakhal, good question. Digging into the change archaeology, I see this change was made by Anna Zaks in Jan 2016 - see commit header below.

Mar 31 2022, 4:59 PM · Restricted Project, Restricted Project
vabridgers requested review of D122841: [analyzer] Add option for AddrSpace in core.NullDereference check.
Mar 31 2022, 11:23 AM · Restricted Project, Restricted Project
vabridgers retitled D118050: [analyzer] Avoid checking addrspace pointers in cstring checker from [analyzer] Different address spaces cannot overlap to [analyzer] Avoid checking addrspace pointers in cstring checker.
Mar 31 2022, 8:06 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

make assert function void, update summary

Mar 31 2022, 8:05 AM · Restricted Project, Restricted Project
vabridgers planned changes to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

I need to make a few changes. Please hold off any comments until the next patch, coming soon.

Mar 31 2022, 7:39 AM · Restricted Project, Restricted Project
vabridgers added a comment to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

I added #ifndef NDEBUG around the assert since I'm not sure if downstream consumers that use different pointer sizes by address space will hit this assert. Our downstream target causes this assert to fire, so I will be continuing to find and fix these issues, submitting test cases as I can. Heck, we may even have to submit a mock target to properly suss these out :)

Mar 31 2022, 7:01 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

add NDEBUG around assert

Mar 31 2022, 6:58 AM · Restricted Project, Restricted Project

Mar 29 2022

vabridgers updated the diff for D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

rebase, check ci

Mar 29 2022, 4:41 PM · Restricted Project, Restricted Project
vabridgers added inline comments to D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".
Mar 29 2022, 3:07 PM · Restricted Project, Restricted Project
vabridgers updated the diff for D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".

fix typo in test - ready to land

Mar 29 2022, 3:06 PM · Restricted Project, Restricted Project

Mar 28 2022

vabridgers updated the diff for D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".

Come up with a more principaled fix, thanks @NoQ :)

Mar 28 2022, 6:11 PM · Restricted Project, Restricted Project
vabridgers added a comment to D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".

I think I got it, looks like we're losing the width information at line 685, 686 below.

Mar 28 2022, 5:00 PM · Restricted Project, Restricted Project
vabridgers added a comment to D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".

Ahhh, I see now :/

Mar 28 2022, 2:54 PM · Restricted Project, Restricted Project

Mar 26 2022

vabridgers added a comment to D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".

Apparently, it's up to an implementation to determine the specific relations that can be computed between different address spaces. Perhaps a better way to deal with this for now, to avoid crashes, is follow the DereferenceChecker model. That checker punts on checking relations with any pointers that have a address space. If a downstream compiler wants to compute relations between pointers with address spaces, they are certainly free to do that - but I get the instinct this might not be best to push upstream :/

Mar 26 2022, 4:47 PM · Restricted Project, Restricted Project
vabridgers added a comment to D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".

Hi @NoQ, good question :) When I looked into the existing SimpleSValBuilder.cpp code, I found a few places that did width modifications so I concluded this was the correct and accepted way to handle this. A few notes to help decide if my suggestion is correct or is there's a different concrete way to move forward. Looks like we get address space information in the AST, and it's up to the AST client to do the needful (whatever that is). We do get warnings and/or errors in some cases, but it seems this is a case where it's implied that the "void *" cast is same address space as the LHS of the comparison. I'll check the Embedded C Spec to see what it says about this.

Mar 26 2022, 4:28 PM · Restricted Project, Restricted Project

Mar 25 2022

vabridgers requested review of D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same".
Mar 25 2022, 3:37 PM · Restricted Project, Restricted Project

Mar 23 2022

vabridgers updated the diff for D122277: [analyzer] Fix crash in RangedConstraintManager.cpp.

update comment

Mar 23 2022, 1:27 AM · Restricted Project, Restricted Project

Mar 22 2022

vabridgers updated the diff for D122277: [analyzer] Fix crash in RangedConstraintManager.cpp.

remove assert that was commented out

Mar 22 2022, 5:40 PM · Restricted Project, Restricted Project
vabridgers requested review of D122277: [analyzer] Fix crash in RangedConstraintManager.cpp.
Mar 22 2022, 5:38 PM · Restricted Project, Restricted Project
vabridgers added inline comments to D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).
Mar 22 2022, 3:40 PM · Restricted Project, Restricted Project
vabridgers updated the diff for D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).

update per @NoQ's latest comments

Mar 22 2022, 3:39 PM · Restricted Project, Restricted Project
vabridgers added a comment to D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).

ping! @steakhal accepted, should we wait for @NoQ before landing? Thanks!

Mar 22 2022, 8:04 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).

rebase

Mar 22 2022, 8:02 AM · Restricted Project, Restricted Project

Mar 19 2022

vabridgers added inline comments to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).
Mar 19 2022, 1:41 PM · Restricted Project, Restricted Project
vabridgers updated the diff for D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

add updated test cases per comments from NoQ

Mar 19 2022, 1:40 PM · Restricted Project, Restricted Project
vabridgers added inline comments to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).
Mar 19 2022, 6:24 AM · Restricted Project, Restricted Project

Mar 18 2022

vabridgers added inline comments to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).
Mar 18 2022, 5:17 PM · Restricted Project, Restricted Project

Mar 4 2022

vabridgers added a comment to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

Is it ok to land this change? Or shall we continue to wait on @NoQ ?

Mar 4 2022, 4:07 PM · Restricted Project, Restricted Project
vabridgers added a comment to D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).

Is it ok to land this change? Or shall we continue to wait on @NoQ ?

Mar 4 2022, 4:05 PM · Restricted Project, Restricted Project

Mar 1 2022

Herald added a project to D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC): Restricted Project.

@NoQ - ping!

Mar 1 2022, 5:09 PM · Restricted Project, Restricted Project
Herald added a project to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC): Restricted Project.

@NoQ - ping!

Mar 1 2022, 5:09 PM · Restricted Project, Restricted Project

Feb 24 2022

vabridgers added inline comments to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.
Feb 24 2022, 1:09 AM · Restricted Project, Restricted Project

Feb 23 2022

vabridgers added a reviewer for D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC): steakhal.
Feb 23 2022, 2:21 AM · Restricted Project, Restricted Project

Feb 22 2022

vabridgers added a comment to D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).

I believe the comments have been addressed. Thank you - Vince

Feb 22 2022, 3:04 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).

Update per @steakhal comments

Feb 22 2022, 3:03 AM · Restricted Project, Restricted Project

Feb 18 2022

vabridgers requested review of D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC).
Feb 18 2022, 8:26 AM · Restricted Project, Restricted Project
vabridgers added inline comments to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).
Feb 18 2022, 5:53 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

refactor based on @steakhal comments

Feb 18 2022, 4:16 AM · Restricted Project, Restricted Project

Feb 17 2022

vabridgers retitled D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC) from [analyzer] Refactor makeNull to makeNullWithWidth to [analyzer] Refactor makeNull to makeNullWithWidth (NFC).
Feb 17 2022, 12:34 PM · Restricted Project, Restricted Project
vabridgers added a comment to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

I believe I've addressed all of Artem's comments thus far. This is a NFC patch, so will include no test cases. We detected these inconsistencies in getting NULL pointers in our downstream target, that supports 2 different pointer sizes depending on address space. That review is here, https://reviews.llvm.org/D118050, and is dependent upon these fixes (makeNull -> makeNullWithWidth refactoring). These two patches will be kept separate, with this patch reviewed and submitted first followed by https://reviews.llvm.org/D118050.

Feb 17 2022, 12:34 PM · Restricted Project, Restricted Project
vabridgers updated the diff for D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

Address NoQ comments

Feb 17 2022, 12:28 PM · Restricted Project, Restricted Project

Feb 13 2022

vabridgers added a comment to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

I explored some test cases, and the rabbit hole gets deeper :) Continuing to explore. Best

Feb 13 2022, 1:24 PM · Restricted Project, Restricted Project
vabridgers added a comment to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

steakhal performed systems testing across a large set of open source projects.

I'm curious if any findings there caused you to make changes in the patch. If so it'd be great to reduce them into test cases so that other people didn't make the same mistake when they edit your new code.

Feb 13 2022, 3:45 AM · Restricted Project, Restricted Project
vabridgers added a comment to D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).

Thanks for the comments. I'll address and revert back soon.

Feb 13 2022, 3:30 AM · Restricted Project, Restricted Project

Feb 11 2022

vabridgers updated the diff for D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

Update after makeNull fixes

Feb 11 2022, 4:23 PM · Restricted Project, Restricted Project
vabridgers requested review of D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC).
Feb 11 2022, 3:35 PM · Restricted Project, Restricted Project

Feb 1 2022

vabridgers added a comment to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

I think the comments have been addressed for now. Please let me know if I missed something, or anything else needs to be done (besides back out the change to SValBuilder.cpp when ready). Thanks for the comments. Best

Feb 1 2022, 8:02 AM · Restricted Project, Restricted Project
vabridgers added a comment to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

I think @steakhal will have a more comprehensive change to back out the makeNull() calls to makeNullWithWidth() calls. I'll back out the change to SValBuilder.cpp once that change is pushed. For now, this is my update. Thanks

Feb 1 2022, 8:00 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

Simplify assertion per comments.
Add a "temp" fix in SValBuilder that permits the additional
test cases to pass without crash

Feb 1 2022, 7:58 AM · Restricted Project, Restricted Project

Jan 31 2022

vabridgers added a comment to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

I took a run at the improvements, and the rabbit hole keeps getting deeper :/ @steakhal, I'll contact you offline to work out the problems. Best

Jan 31 2022, 2:20 AM · Restricted Project, Restricted Project

Jan 29 2022

vabridgers added a comment to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

Thanks for the comments, I'll address. Best

Jan 29 2022, 5:42 AM · Restricted Project, Restricted Project

Jan 26 2022

vabridgers added inline comments to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.
Jan 26 2022, 8:16 AM · Restricted Project, Restricted Project
vabridgers added a comment to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

I updated the test case after verifying I can reproduce the crash without the fix. I also experimented with adding a bitwidth check for the lhs and rhs loc parameters to evalBinOpLL, and verified this assert catches the negative (crash) case.

Jan 26 2022, 8:15 AM · Restricted Project, Restricted Project
vabridgers updated the summary of D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.
Jan 26 2022, 8:11 AM · Restricted Project, Restricted Project
vabridgers updated the diff for D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.
  • update test case
  • add initial Loc bitwidth check for evalBinOpLL for review
Jan 26 2022, 8:10 AM · Restricted Project, Restricted Project

Jan 25 2022

vabridgers added a comment to D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.

Good thoughts, I will try those things and get back to you.

Jan 25 2022, 2:48 AM · Restricted Project, Restricted Project

Jan 24 2022

vabridgers requested review of D118050: [analyzer] Avoid checking addrspace pointers in cstring checker.
Jan 24 2022, 9:05 AM · Restricted Project, Restricted Project

Oct 5 2021

vabridgers updated the diff for D110625: [analyzer] canonicalize special case of structure/pointer deref.

Refactor compare a little bit

Oct 5 2021, 11:14 AM · Restricted Project
vabridgers planned changes to D110625: [analyzer] canonicalize special case of structure/pointer deref.

I'm refactoring the code change a bit. I'll push another update soon. Thanks for the comments.

Oct 5 2021, 9:53 AM · Restricted Project

Oct 1 2021

vabridgers updated the diff for D110625: [analyzer] canonicalize special case of structure/pointer deref.

Use canonical types for comparison

Oct 1 2021, 7:29 AM · Restricted Project
vabridgers added a comment to D110625: [analyzer] canonicalize special case of structure/pointer deref.

I moved the test cases from ptr-arith.cpp to ptr-arith - using to typedef, and created an extra test case that uses const. I believe this may address all concerns discussed thus far? Please let me know if we need anything more and I'll get it done. Best!

Oct 1 2021, 2:11 AM · Restricted Project