Page MenuHomePhabricator

[yaml2obj] - Rename FileHeader::SH* fields.
ClosedPublic

Authored by grimar on Jul 14 2020, 6:03 AM.

Details

Summary

In D83482 we agreed to name e_* fields that are used for overriding
values (like e_phoff) as EPh* (e.g. EPhOff).

Currently we have a set of e_sh* fields that are named inconsistently
with this rule. This patch renames all of them.

Diff Detail

Event Timeline

grimar created this revision.Jul 14 2020, 6:03 AM
Herald added a project: Restricted Project. · View Herald Transcript
jhenderson accepted this revision.Jul 14 2020, 6:10 AM

LGTM, with request.

llvm/lib/ObjectYAML/ELFYAML.cpp
872–873

This assert extension might better belong in a separate patch, to avoid confusing issues.

This revision is now accepted and ready to land.Jul 14 2020, 6:10 AM
grimar marked an inline comment as done.Jul 14 2020, 6:12 AM
grimar added inline comments.
llvm/lib/ObjectYAML/ELFYAML.cpp
872–873

OK, I'll remove.

MaskRay accepted this revision.Jul 14 2020, 10:45 AM

(Honestly if we could start over, I would hope we just use lower-case elf.h variable names, e.g. e_phoff)

This revision was automatically updated to reflect the committed changes.