[Attributor] Unittest for Attributor

[bbn]

Summary

This patch introduces basic unittest interface for the Attributor and a simple test case for casting.

[jdoerfert]

LGTM. Merge it with D83172.

[asb]

This broke the build for -DBUILD_SHARED_LIBS=True. I've committed rG5282a6186c which fixes it for me.

[fhahn]

llvm/unittests/Transforms/IPO/AttributorTest.cpp

48

This seems to cause the following warning for the builder http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu

/home/buildbot/as-builder-4/llvm-clang-x86_64-expensive-checks-ubuntu/llvm-project/llvm/unittests/Transforms/IPO/AttributorTest.cpp:48:61: warning: cast from type ‘const llvm::AAIsDead*’ to type ‘llvm::AbstractAttribute*’ casts away qualifiers [-Wcast-qual]

[jdoerfert]

llvm/unittests/Transforms/IPO/AttributorTest.cpp

49

This slipped through. @bbn, please don't use this kind of type punning at all. if you need to remove a const, there is const_cast. I somehow doubt you need to remove the const at all.

[bbn]

Sorry, I will look into it and update soon.

[bbn]

I uploaded this patch D84532 to fix it.

llvm/unittests/Transforms/IPO/AttributorTest.cpp

+//===- AttributorTest.cpp - Attributor unit tests ------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===---------------------------------------------------------------------===//
+
+#include "llvm/Transforms/IPO/Attributor.h"
+#include "AttributorTestBase.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Analysis/CGSCCPassManager.h"
+#include "llvm/Analysis/CallGraphSCCPass.h"
+#include "llvm/Analysis/LoopAnalysisManager.h"
+#include "llvm/AsmParser/Parser.h"
+#include "llvm/Support/Allocator.h"
+#include "llvm/Testing/Support/Error.h"
+#include "llvm/Transforms/Utils/CallGraphUpdater.h"
+#include "gtest/gtest.h"
+#include <memory>
+
+namespace llvm {
+
+TEST_F(AttributorTestBase, TestCast) {
+  const char *ModuleString = R"(
+    define i32 @foo(i32 %a, i32 %b) {
+    entry:
+      %c = add i32 %a, %b
+      ret i32 %c
+    }
+  )";
+
+  Module &M = parseModule(ModuleString);
+
+  SetVector<Function *> Functions;
+  AnalysisGetter AG;
+  for (Function &F : M)
+    Functions.insert(&F);
+
+  CallGraphUpdater CGUpdater;
+  BumpPtrAllocator Allocator;
+  InformationCache InfoCache(M, AG, Allocator, nullptr);
+  Attributor A(Functions, InfoCache, CGUpdater);
+
+  Function *F = M.getFunction("foo");
+
+  AbstractAttribute *AA = (AbstractAttribute *)&(
+      A.getOrCreateAAFor<AAIsDead>(IRPosition::function(*F)));
+
+  EXPECT_TRUE(AA);
+
+  const auto *SFail = dyn_cast<AAAlign>(AA);
+  const auto *SSucc = dyn_cast<AAIsDead>(AA);
+
+  ASSERT_EQ(SFail, nullptr);
+  ASSERT_TRUE(SSucc);
+}
+
+} // namespace llvm
 No newline at end of file

llvm/unittests/Transforms/IPO/AttributorTestBase.h

+//===- llvm/unittest/Transforms/IPO/AttributorTestBase.h -----------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+/// \file
+/// This file defines an AttributorTestBase class, which provides helpers to
+/// parse a LLVM IR string and create Attributor
+//===----------------------------------------------------------------------===//
+#ifndef LLVM_UNITTESTS_TRANSFORMS_ATTRIBUTOR_TESTBASE_H
+#define LLVM_UNITTESTS_TRANSFORMS_ATTRIBUTOR_TESTBASE_H
+
+#include "llvm/Analysis/CGSCCPassManager.h"
+#include "llvm/Analysis/CallGraphSCCPass.h"
+#include "llvm/AsmParser/Parser.h"
+#include "llvm/IR/Module.h"
+#include "llvm/IR/PassManager.h"
+#include "llvm/Support/Allocator.h"
+#include "llvm/Testing/Support/Error.h"
+#include "llvm/Transforms/IPO/Attributor.h"
+#include "llvm/Transforms/Utils/CallGraphUpdater.h"
+#include "gtest/gtest.h"
+#include <memory>
+
+namespace llvm {
+
+/// Helper class to create a module from assembly string and an Attributor
+class AttributorTestBase : public testing::Test {
+protected:
+  std::unique_ptr<LLVMContext> Ctx;
+  std::unique_ptr<Module> M;
+
+  AttributorTestBase() : Ctx(new LLVMContext) {}
+
+  Module &parseModule(const char *ModuleString) {
+    SMDiagnostic Err;
+    M = parseAssemblyString(ModuleString, Err, *Ctx);
+    EXPECT_TRUE(M);
+    return *M;
+  }
+};
+
+} // namespace llvm
+
+#endif
 No newline at end of file

llvm/unittests/Transforms/IPO/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   Core
   Support
   IPO
   )
 
 add_llvm_unittest(IPOTests
   LowerTypeTests.cpp
   WholeProgramDevirt.cpp
+  AttributorTest.cpp
   )