Page MenuHomePhabricator

[llvm-readobj] - Stop using unwrapOrError() for all program_headers() calls.
ClosedPublic

Authored by grimar on Jul 10 2020, 6:23 AM.

Details

Summary

program_headers() returns the list of program headers. This change allows
to continue attempt of dumping when something is wrong with program headers.

Diff Detail

Event Timeline

grimar created this revision.Jul 10 2020, 6:23 AM
Herald added a project: Restricted Project. · View Herald Transcript
jhenderson accepted this revision.Jul 13 2020, 1:23 AM

LGTM, with a couple of suggestions.

llvm/test/tools/llvm-readobj/ELF/dynamic-tags.test
645

Here and below, perhaps worth an --implicit-check-not=warning:?

647

Nit: extra space for indent.

This revision is now accepted and ready to land.Jul 13 2020, 1:23 AM
This revision was automatically updated to reflect the committed changes.
grimar marked 2 inline comments as done.