Differential D83533

[Alignment][NFC] Update Bitcodewriter to use Align
ClosedPublic
Actions

Authored by gchatelet on Jul 9 2020, 11:30 PM.

Tags

Subscribers

Details

Reviewers

Commits

rGd9bbe85943f6: [Alignment][NFC] Update Bitcodewriter to use Align

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

gchatelet created this revision.Jul 9 2020, 11:30 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2020, 11:30 PM

Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript

courbet accepted this revision.Jul 9 2020, 11:47 PM

courbet added inline comments.

llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
2951	s/5/AlignField::NextBit/ ? (same below)

This revision is now accepted and ready to land.Jul 9 2020, 11:47 PM

Harbormaster completed remote builds in B63693: Diff 276921.Jul 10 2020, 12:28 AM

update reader as well and address comments

Remove newline in BitCodes.h

Harbormaster completed remote builds in B63705: Diff 276942.Jul 10 2020, 1:55 AM

Harbormaster completed remote builds in B63706: Diff 276943.Jul 10 2020, 1:57 AM

Closed by commit rGd9bbe85943f6: [Alignment][NFC] Update Bitcodewriter to use Align (authored by gchatelet). · Explain WhyJul 27 2020, 1:17 AM

This revision was automatically updated to reflect the committed changes.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

In D83533#2176877, @jyknight wrote:

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Oh absolutely, I'll push a fix ASAP.

In D83533#2176972, @gchatelet wrote:

In D83533#2176877, @jyknight wrote:

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Oh absolutely, I'll push a fix ASAP.

Pushed as rG754deffd11c733d709c3ed66d3b9a6b54d081474

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Bitcode/

Writer/

BitcodeWriter.cpp

40 lines

Diff 276921

llvm/lib/Bitcode/Writer/BitcodeWriter.cpp

Loading...