Page MenuHomePhabricator

[Alignment][NFC] Update Bitcodewriter to use Align
ClosedPublic

Authored by gchatelet on Jul 9 2020, 11:30 PM.

Diff Detail

Event Timeline

gchatelet created this revision.Jul 9 2020, 11:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2020, 11:30 PM
courbet accepted this revision.Jul 9 2020, 11:47 PM
courbet added inline comments.
llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
2955

s/5/AlignField::NextBit/ ? (same below)

This revision is now accepted and ready to land.Jul 9 2020, 11:47 PM
gchatelet updated this revision to Diff 276942.Jul 10 2020, 1:11 AM
  • update reader as well and address comments
gchatelet updated this revision to Diff 276943.Jul 10 2020, 1:12 AM
  • Remove newline in BitCodes.h
This revision was automatically updated to reflect the committed changes.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Oh absolutely, I'll push a fix ASAP.

I think this new header ought to go in include/llvm/Bitcode/, not Bitstream?

Oh absolutely, I'll push a fix ASAP.

Pushed as rG754deffd11c733d709c3ed66d3b9a6b54d081474