[PowerPC] Don't set use to RM for static rounding instructions

[qiucf]

Summary

Instructions x(v|s)r(d|s)pi[zmp]? and fri[npzm] use fixed rounding directions without referencing current rounding mode. This patch removes their use to RM in instructions definition.

[jsji]

Looks mostly good to me. But please add MIR tests for these.

eg:

   %0:vsfrc = COPY $f1
-  %1:vsfrc = nofpexcept XSRDPI %0:vsfrc
+  %1:vsfrc = nofpexcept XSRDPI %0:vsfrc, implicit $rm
   $f1 = COPY %1:vsfrc
   BLR8 implicit $lr8, implicit $rm, implicit $f1

[qiucf]

Dup of D81360

llvm/lib/Target/PowerPC/PPCInstrInfo.td

                         "fcmpu $crD, $fA, $fB", IIC_FPCompare>;
 }
 
 def FTDIV: XForm_17<63, 128, (outs crrc:$crD), (ins f8rc:$fA, f8rc:$fB),
                       "ftdiv $crD, $fA, $fB", IIC_FPCompare>;
 def FTSQRT: XForm_17a<63, 160, (outs crrc:$crD), (ins f8rc:$fB),
                       "ftsqrt $crD, $fB", IIC_FPCompare>;
 
-let Uses = [RM], mayRaiseFPException = 1 in {
-  let hasSideEffects = 0 in {
-  defm FCTIW  : XForm_26r<63, 14, (outs f8rc:$frD), (ins f8rc:$frB),
-                          "fctiw", "$frD, $frB", IIC_FPGeneral,
-                          []>;
-  defm FCTIWU  : XForm_26r<63, 142, (outs f8rc:$frD), (ins f8rc:$frB),
-                          "fctiwu", "$frD, $frB", IIC_FPGeneral,
-                          []>;
-  defm FCTIWZ : XForm_26r<63, 15, (outs f8rc:$frD), (ins f8rc:$frB),
-                          "fctiwz", "$frD, $frB", IIC_FPGeneral,
-                          [(set f64:$frD, (PPCfctiwz f64:$frB))]>;
-
-  defm FRSP   : XForm_26r<63, 12, (outs f4rc:$frD), (ins f8rc:$frB),
-                          "frsp", "$frD, $frB", IIC_FPGeneral,
-                          [(set f32:$frD, (any_fpround f64:$frB))]>;
-
+let mayRaiseFPException = 1, hasSideEffects = 0 in {
   let Interpretation64Bit = 1, isCodeGenOnly = 1 in
   defm FRIND  : XForm_26r<63, 392, (outs f8rc:$frD), (ins f8rc:$frB),
                           "frin", "$frD, $frB", IIC_FPGeneral,
                           [(set f64:$frD, (any_fround f64:$frB))]>;
   defm FRINS  : XForm_26r<63, 392, (outs f4rc:$frD), (ins f4rc:$frB),
                           "frin", "$frD, $frB", IIC_FPGeneral,
                           [(set f32:$frD, (any_fround f32:$frB))]>;
-  }
 
-  let hasSideEffects = 0 in {
   let Interpretation64Bit = 1, isCodeGenOnly = 1 in
   defm FRIPD  : XForm_26r<63, 456, (outs f8rc:$frD), (ins f8rc:$frB),
                           "frip", "$frD, $frB", IIC_FPGeneral,
                           [(set f64:$frD, (any_fceil f64:$frB))]>;
   defm FRIPS  : XForm_26r<63, 456, (outs f4rc:$frD), (ins f4rc:$frB),
                           "frip", "$frD, $frB", IIC_FPGeneral,
                           [(set f32:$frD, (any_fceil f32:$frB))]>;
+
   let Interpretation64Bit = 1, isCodeGenOnly = 1 in
   defm FRIZD  : XForm_26r<63, 424, (outs f8rc:$frD), (ins f8rc:$frB),
                           "friz", "$frD, $frB", IIC_FPGeneral,
                           [(set f64:$frD, (any_ftrunc f64:$frB))]>;
   defm FRIZS  : XForm_26r<63, 424, (outs f4rc:$frD), (ins f4rc:$frB),
                           "friz", "$frD, $frB", IIC_FPGeneral,
                           [(set f32:$frD, (any_ftrunc f32:$frB))]>;
+
   let Interpretation64Bit = 1, isCodeGenOnly = 1 in
   defm FRIMD  : XForm_26r<63, 488, (outs f8rc:$frD), (ins f8rc:$frB),
                           "frim", "$frD, $frB", IIC_FPGeneral,
                           [(set f64:$frD, (any_ffloor f64:$frB))]>;
   defm FRIMS  : XForm_26r<63, 488, (outs f4rc:$frD), (ins f4rc:$frB),
                           "frim", "$frD, $frB", IIC_FPGeneral,
                           [(set f32:$frD, (any_ffloor f32:$frB))]>;
+}
+
+let Uses = [RM], mayRaiseFPException = 1, hasSideEffects = 0 in {
+  defm FCTIW  : XForm_26r<63, 14, (outs f8rc:$frD), (ins f8rc:$frB),
+                          "fctiw", "$frD, $frB", IIC_FPGeneral,
+                          []>;
+  defm FCTIWU  : XForm_26r<63, 142, (outs f8rc:$frD), (ins f8rc:$frB),
+                          "fctiwu", "$frD, $frB", IIC_FPGeneral,
+                          []>;
+  defm FCTIWZ : XForm_26r<63, 15, (outs f8rc:$frD), (ins f8rc:$frB),
+                          "fctiwz", "$frD, $frB", IIC_FPGeneral,
+                          [(set f64:$frD, (PPCfctiwz f64:$frB))]>;
+
+  defm FRSP   : XForm_26r<63, 12, (outs f4rc:$frD), (ins f8rc:$frB),
+                          "frsp", "$frD, $frB", IIC_FPGeneral,
+                          [(set f32:$frD, (any_fpround f64:$frB))]>;
 
   defm FSQRT  : XForm_26r<63, 22, (outs f8rc:$frD), (ins f8rc:$frB),
                           "fsqrt", "$frD, $frB", IIC_FPSqrtD,
                           [(set f64:$frD, (any_fsqrt f64:$frB))]>;
   defm FSQRTS : XForm_26r<59, 22, (outs f4rc:$frD), (ins f4rc:$frB),
                           "fsqrts", "$frD, $frB", IIC_FPSqrtS,
                           [(set f32:$frD, (any_fsqrt f32:$frB))]>;
-  }
-  }
 }
 
 /// Note that FMR is defined as pseudo-ops on the PPC970 because they are
 /// often coalesced away and we don't want the dispatch group builder to think
 /// that they will fill slots (which could cause the load of a LSU reject to
 /// sneak into a d-group with a store).
 let hasSideEffects = 0, Predicates = [HasFPU] in
 defm FMR   : XForm_26r<63, 72, (outs f4rc:$frD), (ins f4rc:$frB),

llvm/lib/Target/PowerPC/PPCInstrVSX.td

let mayStore = 1, mayLoad = 0 in {
 
     def STXVW4X : XX1Form_memOp<31, 908,
                          (outs), (ins vsrc:$XT, memrr:$dst),
                          "stxvw4x $XT, $dst", IIC_LdStSTFD,
                          []>;
     }
   } // mayStore
 
+  // Rounding Instructions with static direction
+  let mayRaiseFPException = 1 in {
+    def XSRDPI : XX2Form<60, 73,
+                        (outs vsfrc:$XT), (ins vsfrc:$XB),
+                        "xsrdpi $XT, $XB", IIC_VecFP,
+                        [(set f64:$XT, (any_fround f64:$XB))]>;
+    def XSRDPIM : XX2Form<60, 121,
+                        (outs vsfrc:$XT), (ins vsfrc:$XB),
+                        "xsrdpim $XT, $XB", IIC_VecFP,
+                        [(set f64:$XT, (any_ffloor f64:$XB))]>;
+    def XSRDPIP : XX2Form<60, 105,
+                        (outs vsfrc:$XT), (ins vsfrc:$XB),
+                        "xsrdpip $XT, $XB", IIC_VecFP,
+                        [(set f64:$XT, (any_fceil f64:$XB))]>;
+    def XSRDPIZ : XX2Form<60, 89,
+                        (outs vsfrc:$XT), (ins vsfrc:$XB),
+                        "xsrdpiz $XT, $XB", IIC_VecFP,
+                        [(set f64:$XT, (any_ftrunc f64:$XB))]>;
+
+    def XVRDPI : XX2Form<60, 201,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrdpi $XT, $XB", IIC_VecFP,
+                        [(set v2f64:$XT, (any_fround v2f64:$XB))]>;
+    def XVRDPIM : XX2Form<60, 249,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrdpim $XT, $XB", IIC_VecFP,
+                        [(set v2f64:$XT, (any_ffloor v2f64:$XB))]>;
+    def XVRDPIP : XX2Form<60, 233,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrdpip $XT, $XB", IIC_VecFP,
+                        [(set v2f64:$XT, (any_fceil v2f64:$XB))]>;
+    def XVRDPIZ : XX2Form<60, 217,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrdpiz $XT, $XB", IIC_VecFP,
+                        [(set v2f64:$XT, (any_ftrunc v2f64:$XB))]>;
+
+    def XVRSPI : XX2Form<60, 137,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrspi $XT, $XB", IIC_VecFP,
+                        [(set v4f32:$XT, (any_fround v4f32:$XB))]>;
+    def XVRSPIM : XX2Form<60, 185,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrspim $XT, $XB", IIC_VecFP,
+                        [(set v4f32:$XT, (any_ffloor v4f32:$XB))]>;
+    def XVRSPIP : XX2Form<60, 169,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrspip $XT, $XB", IIC_VecFP,
+                        [(set v4f32:$XT, (any_fceil v4f32:$XB))]>;
+    def XVRSPIZ : XX2Form<60, 153,
+                        (outs vsrc:$XT), (ins vsrc:$XB),
+                        "xvrspiz $XT, $XB", IIC_VecFP,
+                        [(set v4f32:$XT, (any_ftrunc v4f32:$XB))]>;
+  } // mayRaiseException
+
   let Uses = [RM], mayRaiseFPException = 1 in {
   // Add/Mul Instructions
   let isCommutable = 1 in {
     def XSADDDP : XX3Form<60, 32,
                           (outs vsfrc:$XT), (ins vsfrc:$XA, vsfrc:$XB),
                           "xsadddp $XT, $XA, $XB", IIC_VecFP,
                           [(set f64:$XT, (any_fadd f64:$XA, f64:$XB))]>;
     def XSMULDP : XX3Form<60, 48,
def XVCVUXWDP : XX2Form<60, 232,
                       (outs vsrc:$XT), (ins vsrc:$XB),
                       "xvcvuxwdp $XT, $XB", IIC_VecFP,
                       [(set v2f64:$XT, (int_ppc_vsx_xvcvuxwdp v4i32:$XB))]>;
   def XVCVUXWSP : XX2Form<60, 168,
                       (outs vsrc:$XT), (ins vsrc:$XB),
                       "xvcvuxwsp $XT, $XB", IIC_VecFP,
                       [(set v4f32:$XT, (uint_to_fp v4i32:$XB))]>;
 
-  // Rounding Instructions
-  def XSRDPI : XX2Form<60, 73,
-                      (outs vsfrc:$XT), (ins vsfrc:$XB),
-                      "xsrdpi $XT, $XB", IIC_VecFP,
-                      [(set f64:$XT, (any_fround f64:$XB))]>;
+  // Rounding Instructions respecting current rounding mode
   def XSRDPIC : XX2Form<60, 107,
                       (outs vsfrc:$XT), (ins vsfrc:$XB),
                       "xsrdpic $XT, $XB", IIC_VecFP,
                       [(set f64:$XT, (any_fnearbyint f64:$XB))]>;
-  def XSRDPIM : XX2Form<60, 121,
-                      (outs vsfrc:$XT), (ins vsfrc:$XB),
-                      "xsrdpim $XT, $XB", IIC_VecFP,
-                      [(set f64:$XT, (any_ffloor f64:$XB))]>;
-  def XSRDPIP : XX2Form<60, 105,
-                      (outs vsfrc:$XT), (ins vsfrc:$XB),
-                      "xsrdpip $XT, $XB", IIC_VecFP,
-                      [(set f64:$XT, (any_fceil f64:$XB))]>;
-  def XSRDPIZ : XX2Form<60, 89,
-                      (outs vsfrc:$XT), (ins vsfrc:$XB),
-                      "xsrdpiz $XT, $XB", IIC_VecFP,
-                      [(set f64:$XT, (any_ftrunc f64:$XB))]>;
 
-  def XVRDPI : XX2Form<60, 201,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrdpi $XT, $XB", IIC_VecFP,
-                      [(set v2f64:$XT, (any_fround v2f64:$XB))]>;
   def XVRDPIC : XX2Form<60, 235,
                       (outs vsrc:$XT), (ins vsrc:$XB),
                       "xvrdpic $XT, $XB", IIC_VecFP,
                       [(set v2f64:$XT, (any_fnearbyint v2f64:$XB))]>;
-  def XVRDPIM : XX2Form<60, 249,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrdpim $XT, $XB", IIC_VecFP,
-                      [(set v2f64:$XT, (any_ffloor v2f64:$XB))]>;
-  def XVRDPIP : XX2Form<60, 233,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrdpip $XT, $XB", IIC_VecFP,
-                      [(set v2f64:$XT, (any_fceil v2f64:$XB))]>;
-  def XVRDPIZ : XX2Form<60, 217,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrdpiz $XT, $XB", IIC_VecFP,
-                      [(set v2f64:$XT, (any_ftrunc v2f64:$XB))]>;
 
-  def XVRSPI : XX2Form<60, 137,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrspi $XT, $XB", IIC_VecFP,
-                      [(set v4f32:$XT, (any_fround v4f32:$XB))]>;
   def XVRSPIC : XX2Form<60, 171,
                       (outs vsrc:$XT), (ins vsrc:$XB),
                       "xvrspic $XT, $XB", IIC_VecFP,
                       [(set v4f32:$XT, (any_fnearbyint v4f32:$XB))]>;
-  def XVRSPIM : XX2Form<60, 185,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrspim $XT, $XB", IIC_VecFP,
-                      [(set v4f32:$XT, (any_ffloor v4f32:$XB))]>;
-  def XVRSPIP : XX2Form<60, 169,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrspip $XT, $XB", IIC_VecFP,
-                      [(set v4f32:$XT, (any_fceil v4f32:$XB))]>;
-  def XVRSPIZ : XX2Form<60, 153,
-                      (outs vsrc:$XT), (ins vsrc:$XB),
-                      "xvrspiz $XT, $XB", IIC_VecFP,
-                      [(set v4f32:$XT, (any_ftrunc v4f32:$XB))]>;
 
   // Max/Min Instructions
   let isCommutable = 1 in {
   def XSMAXDP : XX3Form<60, 160,
                         (outs vsfrc:$XT), (ins vsfrc:$XA, vsfrc:$XB),
                         "xsmaxdp $XT, $XA, $XB", IIC_VecFP,
                         [(set vsfrc:$XT,
                               (int_ppc_vsx_xsmaxdp vsfrc:$XA, vsfrc:$XB))]>;