This is an archive of the discontinued LLVM Phabricator instance.

Differential D83339

[SVE] Remove calls to VectorType::getNumElements from AsmParserTest
ClosedPublic

Authored by ctetreau on Jul 7 2020, 1:07 PM.

Details

Reviewers
efriedma
c-rhodes
david-arm
kmclaughlin
fpetrogalli
sdesmalen
Commits
rGc17120a3a4c1: [SVE] Remove calls to VectorType::getNumElements from AsmParserTest

Diff Detail

Event Timeline

ctetreau created this revision.Jul 7 2020, 1:07 PM
Herald added a reviewer: efriedma. · View Herald TranscriptJul 7 2020, 1:07 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, psnobl, tschuett. · View Herald Transcript
ctetreau added reviewers: c-rhodes, david-arm, kmclaughlin, fpetrogalli, sdesmalen.Jul 7 2020, 1:09 PM
ctetreau added a child revision: D78127: [SVE] Mark VectorType::getNumElements() deprecated.
efriedma accepted this revision.Jul 7 2020, 1:51 PM

LGTM

This revision is now accepted and ready to land.Jul 7 2020, 1:51 PM
Closed by commit rGc17120a3a4c1: [SVE] Remove calls to VectorType::getNumElements from AsmParserTest (authored by ctetreau). · Explain WhyJul 7 2020, 2:56 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B63282: Diff 276189.Jul 7 2020, 4:24 PM
ctetreau removed a child revision: D78127: [SVE] Mark VectorType::getNumElements() deprecated.Aug 31 2020, 1:56 PM

Revision Contents

PathSize
llvm/
unittests/
AsmParser/
4 lines

Diff 276189

llvm/unittests/AsmParser/AsmParserTest.cpp

Show First 20 Lines • Show All 224 Lines • ▼ Show 20 LinesTEST(AsmParserTest, TypeWithSlotMappingParsing) {
} }
// Check we properly parse vector types. // Check we properly parse vector types.
Ty = parseType("<5 x i32>", Error, M, &Mapping); Ty = parseType("<5 x i32>", Error, M, &Mapping);
ASSERT_TRUE(Ty); ASSERT_TRUE(Ty);
ASSERT_TRUE(Ty->isVectorTy()); ASSERT_TRUE(Ty->isVectorTy());
// Check the details of the vector. // Check the details of the vector.
VectorType *VT = cast<VectorType>(Ty); auto *VT = cast<FixedVectorType>(Ty);
ASSERT_TRUE(VT->getNumElements() == 5); ASSERT_TRUE(VT->getNumElements() == 5);
ASSERT_TRUE(VT->getPrimitiveSizeInBits().getFixedSize() == 160); ASSERT_TRUE(VT->getPrimitiveSizeInBits().getFixedSize() == 160);
Ty = VT->getElementType(); Ty = VT->getElementType();
ASSERT_TRUE(Ty->isIntegerTy()); ASSERT_TRUE(Ty->isIntegerTy());
ASSERT_TRUE(Ty->getPrimitiveSizeInBits() == 32); ASSERT_TRUE(Ty->getPrimitiveSizeInBits() == 32);
// Opaque struct. // Opaque struct.
Ty = parseType("%opaque", Error, M, &Mapping); Ty = parseType("%opaque", Error, M, &Mapping);
▲ Show 20 Lines • Show All 115 Lines • ▼ Show 20 LinesTEST(AsmParserTest, TypeAtBeginningWithSlotMappingParsing) {
// Check we properly parse vector types. // Check we properly parse vector types.
Ty = parseTypeAtBeginning("<5 x i32>", Read, Error, M, &Mapping); Ty = parseTypeAtBeginning("<5 x i32>", Read, Error, M, &Mapping);
ASSERT_TRUE(Ty); ASSERT_TRUE(Ty);
ASSERT_TRUE(Ty->isVectorTy()); ASSERT_TRUE(Ty->isVectorTy());
ASSERT_TRUE(Read == 9); ASSERT_TRUE(Read == 9);
// Check the details of the vector. // Check the details of the vector.
VectorType *VT = cast<VectorType>(Ty); auto *VT = cast<FixedVectorType>(Ty);
ASSERT_TRUE(VT->getNumElements() == 5); ASSERT_TRUE(VT->getNumElements() == 5);
ASSERT_TRUE(VT->getPrimitiveSizeInBits().getFixedSize() == 160); ASSERT_TRUE(VT->getPrimitiveSizeInBits().getFixedSize() == 160);
Ty = VT->getElementType(); Ty = VT->getElementType();
ASSERT_TRUE(Ty->isIntegerTy()); ASSERT_TRUE(Ty->isIntegerTy());
ASSERT_TRUE(Ty->getPrimitiveSizeInBits() == 32); ASSERT_TRUE(Ty->getPrimitiveSizeInBits() == 32);
// Opaque struct. // Opaque struct.
Ty = parseTypeAtBeginning("%opaque", Read, Error, M, &Mapping); Ty = parseTypeAtBeginning("%opaque", Read, Error, M, &Mapping);
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines