This is an archive of the discontinued LLVM Phabricator instance.

DomTree: Add TreeNode type alias
AcceptedPublic

Authored by nhaehnle on Jul 2 2020, 2:09 PM.

Details

Summary

This should help reduce churn later on when we clean up the template
parameter to be a CfgTraitsT instead of a NodeT.

Change-Id: Id12289d381efbc015f65fe5549564f67a31189f4

Diff Detail

Event Timeline

nhaehnle created this revision.Jul 2 2020, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2020, 2:09 PM
Herald added a subscriber: wdng. · View Herald Transcript
RKSimon accepted this revision.Jul 3 2020, 1:28 AM

LGTM

This revision is now accepted and ready to land.Jul 3 2020, 1:28 AM
kuhar accepted this revision.Jul 6 2020, 7:55 PM
kuhar added a subscriber: kuhar.

LGTM

kuhar resigned from this revision.May 16 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 10:58 AM

@nhaehnle Sorry just trying to clean out my phab backlog - but whatever happened with this patch?

@nhaehnle Sorry just trying to clean out my phab backlog - but whatever happened with this patch?

I believe @sameerds is adopting this series

This change is not really on the path for what I am doing with convergence and uniformity. It relates to an old discussion about having a single interface to SSA-form IRs such as LLVM IR and MIR. Seems mostly harmless to commit if anyone has a use for it, but things like CycleInfo and the new UniformityAnalysis depend on SSAContext::DominatorTreeT instead. It's defined in SSAContext.h and MachineSSAContext.h for the two supported IRs.