Page MenuHomePhabricator
Differential D83090

DomTree: Add TreeNode type alias
AcceptedPublic
Actions

Authored by nhaehnle on Jul 2 2020, 2:09 PM.

Details

Reviewers
arsenm
RKSimon
mehdi_amini
courbet
kuhar
Commits
rGd0d1c416cb1e: Remove unneeded cl::ZeroOrMore for cl::list options
Summary

This should help reduce churn later on when we clean up the template
parameter to be a CfgTraitsT instead of a NodeT.

Change-Id: Id12289d381efbc015f65fe5549564f67a31189f4

Diff Detail

Event Timeline

nhaehnle created this revision.Jul 2 2020, 2:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 2 2020, 2:09 PM
Herald added a subscriber: wdng. · View Herald Transcript
nhaehnle added a parent revision: D83089: DomTree: Extract (mostly) read-only logic into type-erased base classes.Jul 2 2020, 2:12 PM
nhaehnle added a parent revision: D83092: DomTree: Add climbLhsUntilSiblings helper.
nhaehnle removed a parent revision: D83092: DomTree: Add climbLhsUntilSiblings helper.
nhaehnle added a child revision: D83092: DomTree: Add climbLhsUntilSiblings helper.
Harbormaster completed remote builds in B62759: Diff 275233.Jul 2 2020, 4:13 PM
RKSimon accepted this revision.Jul 3 2020, 1:28 AM

LGTM

This revision is now accepted and ready to land.Jul 3 2020, 1:28 AM
kuhar accepted this revision.Jul 6 2020, 7:55 PM
kuhar added a subscriber: kuhar.

LGTM

kuhar resigned from this revision.May 16 2022, 10:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 10:58 AM
Herald added a subscriber: jeroen.dobbelaere. · View Herald Transcript
trukhaav added a commit: rGd0d1c416cb1e: Remove unneeded cl::ZeroOrMore for cl::list options.Jun 5 2022, 12:28 AM
RKSimon added a comment.Sep 28 2022, 8:53 AM

@nhaehnle Sorry just trying to clean out my phab backlog - but whatever happened with this patch?

arsenm added a subscriber: sameerds.Sep 28 2022, 9:01 AM
In D83090#3821170, @RKSimon wrote:

@nhaehnle Sorry just trying to clean out my phab backlog - but whatever happened with this patch?

I believe @sameerds is adopting this series

sameerds added a comment.Sep 28 2022, 10:01 PM

This change is not really on the path for what I am doing with convergence and uniformity. It relates to an old discussion about having a single interface to SSA-form IRs such as LLVM IR and MIR. Seems mostly harmless to commit if anyone has a use for it, but things like CycleInfo and the new UniformityAnalysis depend on SSAContext::DominatorTreeT instead. It's defined in SSAContext.h and MachineSSAContext.h for the two supported IRs.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Support/
86 lines
2 lines

Diff 275233

View Options

llvm/include/llvm/Support/GenericDomTree.h

Loading...
View Options

llvm/include/llvm/Support/GenericDomTreeConstruction.h

Loading...