This is an archive of the discontinued LLVM Phabricator instance.

Differential D82841

[mlir] Fix case in MLIRGPUtoGPURuntimeTransforms
ClosedPublic

Authored by marbre on Jun 29 2020, 11:36 PM.

Details

Reviewers
whchung
ftynse
stephenneuendorffer
antiagainst
herhut
Commits
rG0f43fce78393: [mlir] Fix case in MLIRGPUtoGPURuntimeTransforms
Summary

This changes the casing of MLIRGPUtoGPURuntimeTransforms to be consistent
with other transform libraries.

Diff Detail

Event Timeline

marbre created this revision.Jun 29 2020, 11:36 PM
Herald added a reviewer: herhut. · View Herald TranscriptJun 29 2020, 11:36 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: msifontes, jurahul, Kayjukh and 14 others. · View Herald Transcript
herhut accepted this revision.Jun 30 2020, 12:51 AM

Thanks!

This revision is now accepted and ready to land.Jun 30 2020, 12:51 AM
Harbormaster completed remote builds in B62277: Diff 274341.Jun 30 2020, 1:35 AM
marbre added a comment.Jun 30 2020, 1:52 AM

Thanks for the review! I would appreciate if you could commit on my behalf.

Closed by commit rG0f43fce78393: [mlir] Fix case in MLIRGPUtoGPURuntimeTransforms (authored by marbre, committed by herhut). · Explain WhyJun 30 2020, 11:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
lib/
Conversion/
GPUCommon/
2 lines
test/
lib/
Transforms/
2 lines

Diff 274341

mlir/lib/Conversion/GPUCommon/CMakeLists.txt

if (MLIR_CUDA_CONVERSIONS_ENABLED) if (MLIR_CUDA_CONVERSIONS_ENABLED)
set(NVPTX_LIBS set(NVPTX_LIBS
NVPTXCodeGen NVPTXCodeGen
NVPTXDesc NVPTXDesc
NVPTXInfo NVPTXInfo
) )
endif() endif()
if (MLIR_ROCM_CONVERSIONS_ENABLED) if (MLIR_ROCM_CONVERSIONS_ENABLED)
set(AMDGPU_LIBS set(AMDGPU_LIBS
AMDGPUCodeGen AMDGPUCodeGen
AMDGPUDesc AMDGPUDesc
AMDGPUInfo AMDGPUInfo
) )
endif() endif()
add_mlir_conversion_library(MLIRGPUtoGPURuntimeTransforms add_mlir_conversion_library(MLIRGPUToGPURuntimeTransforms
ConvertLaunchFuncToRuntimeCalls.cpp ConvertLaunchFuncToRuntimeCalls.cpp
ConvertKernelFuncToBlob.cpp ConvertKernelFuncToBlob.cpp
DEPENDS DEPENDS
MLIRConversionPassIncGen MLIRConversionPassIncGen
intrinsics_gen intrinsics_gen
LINK_COMPONENTS LINK_COMPONENTS
Show All 12 Lines

mlir/test/lib/Transforms/CMakeLists.txt

Show All 33 Linesadd_mlir_library(MLIRTestTransforms
MLIRStandardOpsIncGen MLIRStandardOpsIncGen
MLIRTestVectorTransformPatternsIncGen MLIRTestVectorTransformPatternsIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRAffineOps MLIRAffineOps
MLIRAnalysis MLIRAnalysis
MLIREDSC MLIREDSC
MLIRGPU MLIRGPU
MLIRGPUtoGPURuntimeTransforms MLIRGPUToGPURuntimeTransforms
MLIRLinalgOps MLIRLinalgOps
MLIRLinalgTransforms MLIRLinalgTransforms
MLIRNVVMIR MLIRNVVMIR
MLIRSCF MLIRSCF
MLIRSCFTransforms MLIRSCFTransforms
MLIRGPU MLIRGPU
MLIRPass MLIRPass
MLIRROCDLIR MLIRROCDLIR
Show All 13 Lines