Page MenuHomePhabricator

whchung (Wen-Heng (Jack) Chung)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2015, 5:48 PM (291 w, 6 d)

Recent Activity

Mar 18 2021

whchung added a comment to D98447: [mlir] Remove mlir-rocm-runner.

Thanks for cleaning this up! Looks good in general but I also cannot test this. It would be nice if we had a builder for this. @whchung do you have a setup that could test this continuously or at least periodically to make sure it does not break?

Mar 18 2021, 4:26 PM · Restricted Project
whchung accepted D98447: [mlir] Remove mlir-rocm-runner.

The patch has been verified on ROCm 4.0.

Mar 18 2021, 3:44 PM · Restricted Project

Mar 12 2021

whchung added a comment to D98447: [mlir] Remove mlir-rocm-runner.

@csigg I would need your help advising me the proper way to configure it so I could test the patch. With the cmake command I use downstream I run into link errors aforementioned.

Mar 12 2021, 10:39 AM · Restricted Project
whchung added a comment to D98447: [mlir] Remove mlir-rocm-runner.

@csigg May I understand how you configure the build?

Mar 12 2021, 9:45 AM · Restricted Project
whchung added a comment to D98447: [mlir] Remove mlir-rocm-runner.

@csigg May I understand the goal for this changeset is to merge everything under mlir-cpu-runner?

Mar 12 2021, 6:09 AM · Restricted Project

Feb 5 2021

whchung committed rG04766c401ba5: [AMDGPU] Add Fiji target in fptosi/fptoui instruction-select MIR tests. (authored by whchung).
[AMDGPU] Add Fiji target in fptosi/fptoui instruction-select MIR tests.
Feb 5 2021, 9:34 AM
whchung closed D96061: [AMDGPU] Add Fiji target in fptosi/fptoui instruction-select MIR tests..
Feb 5 2021, 9:34 AM · Restricted Project

Feb 4 2021

whchung added inline comments to D95964: [AMDGPU] Add f16 to i1 CodeGen patterns..
Feb 4 2021, 12:36 PM · Restricted Project
whchung added inline comments to D95964: [AMDGPU] Add f16 to i1 CodeGen patterns..
Feb 4 2021, 10:19 AM · Restricted Project
whchung requested review of D96061: [AMDGPU] Add Fiji target in fptosi/fptoui instruction-select MIR tests..
Feb 4 2021, 10:18 AM · Restricted Project
whchung committed rG50578cf33922: [AMDGPU] Add f16 to i1 CodeGen patterns. (authored by whchung).
[AMDGPU] Add f16 to i1 CodeGen patterns.
Feb 4 2021, 9:44 AM
whchung closed D95964: [AMDGPU] Add f16 to i1 CodeGen patterns..
Feb 4 2021, 9:44 AM · Restricted Project

Feb 3 2021

whchung added a reviewer for D95964: [AMDGPU] Add f16 to i1 CodeGen patterns.: arsenm.
Feb 3 2021, 1:29 PM · Restricted Project
whchung updated the diff for D95964: [AMDGPU] Add f16 to i1 CodeGen patterns..

Add MIR-level tests.

Feb 3 2021, 1:28 PM · Restricted Project
whchung added a comment to D95964: [AMDGPU] Add f16 to i1 CodeGen patterns..

@arsenm Could you help me understand if my understanding is correct to fulfill your requirement of 'test globalisel'?

Feb 3 2021, 12:56 PM · Restricted Project
whchung added a reviewer for D95964: [AMDGPU] Add f16 to i1 CodeGen patterns.: kzhuravl.
Feb 3 2021, 12:05 PM · Restricted Project
whchung added a comment to D95964: [AMDGPU] Add f16 to i1 CodeGen patterns..

The patterns were found in some MLIR-based applications.

Feb 3 2021, 11:59 AM · Restricted Project
whchung requested review of D95964: [AMDGPU] Add f16 to i1 CodeGen patterns..
Feb 3 2021, 11:58 AM · Restricted Project

Oct 8 2020

whchung abandoned D79019: [mlir][llvm] allow mlir-translate carry custom triple and data layout..

@aartbik The patch is no longer necessary.

Oct 8 2020, 11:07 AM · Restricted Project, Restricted Project

Sep 21 2020

whchung accepted D88038: [AMDGPU] Adding mutex to guard lld::elf::link interface use.
Sep 21 2020, 11:41 AM · Restricted Project

Sep 16 2020

whchung accepted D87773: [AMDGPU] Bump to ROCm 3.7 dependency hip_hcc->amdhip64.
Sep 16 2020, 9:01 AM · Restricted Project
whchung accepted D87770: [AMDGPU] Fix ROCm unit test memref initialization.
Sep 16 2020, 8:50 AM · Restricted Project

Jun 22 2020

whchung committed rGb7c4912996d6: [mlir][mlir-rocm-runner] Remove compile-time warning. NFC. (authored by whchung).
[mlir][mlir-rocm-runner] Remove compile-time warning. NFC.
Jun 22 2020, 8:25 PM
whchung committed rG6bb4fc93c2fd: Fix a corner case in vector.shape_cast when the trailing dimensions are of size… (authored by whchung).
Fix a corner case in vector.shape_cast when the trailing dimensions are of size…
Jun 22 2020, 8:25 PM
whchung closed D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..
Jun 22 2020, 8:25 PM · Restricted Project
whchung closed D82333: [mlir][mlir-rocm-runner] Remove compile-time warning. NFC..
Jun 22 2020, 8:25 PM · Restricted Project
whchung updated the summary of D82333: [mlir][mlir-rocm-runner] Remove compile-time warning. NFC..
Jun 22 2020, 3:35 PM · Restricted Project
whchung created D82333: [mlir][mlir-rocm-runner] Remove compile-time warning. NFC..
Jun 22 2020, 3:35 PM · Restricted Project
whchung updated the diff for D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..

Remove an empty line.

Jun 22 2020, 3:03 PM · Restricted Project
whchung updated the diff for D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..

Update commit message.

Jun 22 2020, 3:03 PM · Restricted Project
whchung retitled D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1. from Fix a corner case in vector.shape_cast when the last dimension is of size 1. to Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..
Jun 22 2020, 3:03 PM · Restricted Project
whchung updated subscribers of D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..
Jun 22 2020, 3:03 PM · Restricted Project
whchung updated the diff for D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..

Address review comments by improve logic.

Jun 22 2020, 3:03 PM · Restricted Project
whchung added inline comments to D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..
Jun 22 2020, 12:54 PM · Restricted Project
whchung updated the diff for D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..

Address code review comments.

Jun 22 2020, 12:54 PM · Restricted Project
whchung created D82304: Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1..
Jun 22 2020, 8:02 AM · Restricted Project

Jun 11 2020

whchung committed rG7bfcb9120fcf: Use python3 in generate-test-checks.py. (authored by whchung).
Use python3 in generate-test-checks.py.
Jun 11 2020, 5:39 PM
whchung closed D81701: Use python3 in generate-test-checks.py..
Jun 11 2020, 5:39 PM · Restricted Project
whchung added a reviewer for D81701: Use python3 in generate-test-checks.py.: rriddle.
Jun 11 2020, 5:38 PM · Restricted Project
whchung created D81701: Use python3 in generate-test-checks.py..
Jun 11 2020, 5:38 PM · Restricted Project
whchung accepted D81663: [mlir][rocdl] Fixing breakage of dim operator from 904f91db.
Jun 11 2020, 9:53 AM · Restricted Project

Jun 8 2020

whchung accepted D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.

LGTM. @aartbik / @nicolasvasilache would you mind give this patch another round of review?

Jun 8 2020, 2:25 PM · Restricted Project
whchung added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 8 2020, 1:51 PM · Restricted Project
whchung added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 8 2020, 12:07 PM · Restricted Project
whchung closed D80766: [mlir][gpu] Fix logic error in D79508 computing number of private attributions..

This patch was landed in commit 603b974cf7103766a0e5e4a0320fedb7c4b570f9.

Jun 8 2020, 9:56 AM · Restricted Project, Restricted Project
whchung committed rG603b974cf710: [mlir][gpu] Fix logic error in D79508 computing number of private attributions. (authored by whchung).
[mlir][gpu] Fix logic error in D79508 computing number of private attributions.
Jun 8 2020, 5:58 AM

Jun 5 2020

whchung committed rG47073ccd4e78: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version. (authored by whchung).
[mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version.
Jun 5 2020, 8:36 PM
whchung closed D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..
Jun 5 2020, 8:36 PM · Restricted Project
whchung updated the diff for D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..

Fix typos in the commit log.

Jun 5 2020, 7:32 PM · Restricted Project
whchung retitled D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version. from [mlir][mlir-rocm-runner] Detech HIP version and AMD ISA version. to [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..
Jun 5 2020, 7:32 PM · Restricted Project
whchung updated the summary of D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..
Jun 5 2020, 7:32 PM · Restricted Project
whchung added a reviewer for D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version.: yaxunl.
Jun 5 2020, 5:54 PM · Restricted Project
whchung updated the diff for D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..

Revise HIP version detection logic to be more descriptive.

Jun 5 2020, 5:54 PM · Restricted Project
whchung retitled D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version. from [mlir][mlir-rocm-runner] Detech HIP version and set HSA code object version. to [mlir][mlir-rocm-runner] Detech HIP version and AMD ISA version..
Jun 5 2020, 5:21 PM · Restricted Project
whchung updated the diff for D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..

Add logic to detech AMD ISA version.

Jun 5 2020, 5:21 PM · Restricted Project
whchung updated the diff for D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..

Fix build error due to incorrect lint.

Jun 5 2020, 2:36 PM · Restricted Project
whchung created D81309: [mlir][mlir-rocm-runner] Detect HIP version and AMD ISA version..
Jun 5 2020, 2:36 PM · Restricted Project
whchung added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 5 2020, 2:03 PM · Restricted Project
whchung added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 5 2020, 2:02 PM · Restricted Project
whchung added inline comments to D81276: [mlir][rocdl] Adding vector to ROCDL dialect lowering.
Jun 5 2020, 2:02 PM · Restricted Project
whchung committed rG2fd6403a6d7a: [mlir][gpu] Introduce mlir-rocm-runner. (authored by whchung).
[mlir][gpu] Introduce mlir-rocm-runner.
Jun 5 2020, 7:47 AM
whchung closed D80676: [mlir][gpu] Introduce mlir-rocm-runner..
Jun 5 2020, 7:47 AM · Restricted Project, Restricted Project

Jun 4 2020

whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Remove NOLINT.

Jun 4 2020, 9:28 PM · Restricted Project, Restricted Project
whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Apply NOLINT.

Jun 4 2020, 7:38 AM · Restricted Project, Restricted Project

Jun 3 2020

whchung added a comment to D80676: [mlir][gpu] Introduce mlir-rocm-runner..

@jerryyin I've revised the commit based on your comments. Could you give this patch another around of review? Thanks.

Jun 3 2020, 1:46 PM · Restricted Project, Restricted Project
whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Address code review comments.

Jun 3 2020, 1:46 PM · Restricted Project, Restricted Project
whchung added inline comments to D80676: [mlir][gpu] Introduce mlir-rocm-runner..
Jun 3 2020, 1:46 PM · Restricted Project, Restricted Project

Jun 1 2020

whchung added a reviewer for D80676: [mlir][gpu] Introduce mlir-rocm-runner.: jerryyin.
Jun 1 2020, 12:25 PM · Restricted Project, Restricted Project
whchung updated the diff for D80766: [mlir][gpu] Fix logic error in D79508 computing number of private attributions..

Address code review comments.

Jun 1 2020, 12:25 PM · Restricted Project, Restricted Project
whchung updated the diff for D80766: [mlir][gpu] Fix logic error in D79508 computing number of private attributions..

Revise the fix and added positive and negative tests.

Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project
whchung updated the summary of D80766: [mlir][gpu] Fix logic error in D79508 computing number of private attributions..
Jun 1 2020, 9:06 AM · Restricted Project, Restricted Project

May 29 2020

whchung added inline comments to D80766: [mlir][gpu] Fix logic error in D79508 computing number of private attributions..
May 29 2020, 4:18 AM · Restricted Project, Restricted Project

May 28 2020

whchung updated the diff for D79019: [mlir][llvm] allow mlir-translate carry custom triple and data layout..

Rebase.

May 28 2020, 3:59 PM · Restricted Project, Restricted Project
whchung created D80766: [mlir][gpu] Fix logic error in D79508 computing number of private attributions..
May 28 2020, 3:59 PM · Restricted Project, Restricted Project
whchung added inline comments to D79508: [mlir][gpu] Refactor functions for workgroup and private buffer attributions..
May 28 2020, 3:58 PM · Restricted Project, Restricted Project
whchung added inline comments to D80676: [mlir][gpu] Introduce mlir-rocm-runner..
May 28 2020, 1:45 PM · Restricted Project, Restricted Project
whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

std::string -> StringRef.

May 28 2020, 12:08 PM · Restricted Project, Restricted Project
whchung accepted D80739: [mlir][GPU] Link relevant LLVM components in GPUCommon instead of test.
May 28 2020, 10:56 AM · Restricted Project
whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Fix build errors in a shared lib build.

May 28 2020, 10:56 AM · Restricted Project, Restricted Project
whchung added a comment to D80739: [mlir][GPU] Link relevant LLVM components in GPUCommon instead of test.

@ftynse Thanks for the patch. Wondering would it be a better idea to amend the text at: https://mlir.llvm.org/getting_started/ so -DBUILD_SHARED_LIBS=ON is always turned on?

May 28 2020, 10:56 AM · Restricted Project
whchung added a comment to D80734: [mlir][Vector] Fix vector.transfer alignment calculation.

Thanks for the patch. On the application I'm working on, the longest vector type would be vector<?x4>, plus I use scalarize-masked-mem-intrin in my pipeline so the issue addressed in this patch was not encountered on my targets before.

May 28 2020, 10:55 AM · Restricted Project
whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Add CMake checks to ensure lld is enabled building mlir-rocm-runner.

May 28 2020, 10:24 AM · Restricted Project, Restricted Project
whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Improve ROCm HIP library search logic.

May 28 2020, 10:23 AM · Restricted Project, Restricted Project
whchung updated the diff for D80676: [mlir][gpu] Introduce mlir-rocm-runner..

Tame clang-tidy.

May 28 2020, 10:23 AM · Restricted Project, Restricted Project
whchung committed rG061fb8eb2d9f: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic. (authored by whchung).
[mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic.
May 28 2020, 7:36 AM
whchung closed D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..
May 28 2020, 7:36 AM · Restricted Project, Restricted Project

May 27 2020

whchung added a comment to D80676: [mlir][gpu] Introduce mlir-rocm-runner..

This patch depends on D80142.

May 27 2020, 4:56 PM · Restricted Project, Restricted Project
whchung created D80676: [mlir][gpu] Introduce mlir-rocm-runner..
May 27 2020, 4:56 PM · Restricted Project, Restricted Project
whchung updated the diff for D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..

Remove unused headers.

May 27 2020, 2:43 PM · Restricted Project, Restricted Project
whchung added inline comments to D80167: [mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass..
May 27 2020, 2:42 PM · Restricted Project, Restricted Project
whchung added inline comments to D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..
May 27 2020, 2:10 PM · Restricted Project, Restricted Project
whchung updated the diff for D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..

Remove obsolete comment.

May 27 2020, 1:36 PM · Restricted Project, Restricted Project
whchung added inline comments to D79508: [mlir][gpu] Refactor functions for workgroup and private buffer attributions..
May 27 2020, 1:02 PM · Restricted Project, Restricted Project
whchung updated the diff for D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..

Revise the patch addressing code review comments.

May 27 2020, 1:02 PM · Restricted Project, Restricted Project

May 22 2020

whchung added a comment to D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..

@herhut I've revised the patch so ConvertGpuKernelToCubin pass is now ConvertGpuKernelToBlob and works on both CUDA and ROCm platform. Could you help review it once again? Thanks.

May 22 2020, 3:34 PM · Restricted Project, Restricted Project
whchung retitled D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic. from [mlir][gpu][rocdl] Introduce GPUToROCm conversion passes. to [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..
May 22 2020, 3:02 PM · Restricted Project, Restricted Project
whchung updated the diff for D80142: [mlir][gpu][mlir-cuda-runner] Refactor ConvertKernelFuncToCubin to be generic..

Rewrite the patch to make the pass be generic between CUDA+NVPTX and ROCm+AMDGPU.

May 22 2020, 3:02 PM · Restricted Project, Restricted Project

May 21 2020

whchung committed rG2cbbc266ec1e: [mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass. (authored by whchung).
[mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass.
May 21 2020, 7:31 AM
whchung closed D80167: [mlir][gpu] Refactor ConvertGpuLaunchFuncToCudaCalls pass..
May 21 2020, 7:31 AM · Restricted Project, Restricted Project

May 20 2020

whchung updated subscribers of D80343: [mlir][gpu] Fix CMake errors in case NVPTX is not enabled. NFC..

I only see this now, I already reverted the offending patch I think. In the future if you have a fix for a build failure, please land it directly without code review: it is more important to unbreak everyone ASAP (either through revert or hot fix).
You can always ping the original revision to indicate that you had to do that so that the original reviewer can take a look at it post-review.

Right now the best course of action is to squash this into your original patch and land it back (there is a comment from Richard in your original revision that should likely be addressed first).

May 20 2020, 10:01 PM · Restricted Project, Restricted Project