[llvm-install-name-tool] Guard isLoadCommandWithPayloadString

[sameerarora101]

Summary

isLoadCommandWithPayloadString is only used by asserts and is thus
never used in release mode. To avoid the warning `warning: unused
function 'isLoadCommandWithPayloadString'`, I have guarded the function
with #ifdef NDEBUG ... #endif

[gchatelet]

Thx!

[alexander-shaposhnikov]

Btw, this issue has already been fixed by https://github.com/llvm/llvm-project/commit/cc836950ab2a4309ae68d78a1b2330fd922fa3a2

[gchatelet]

In D82768#2121865, @alexshap wrote:

Btw, this issue has already been fixed by https://github.com/llvm/llvm-project/commit/cc836950ab2a4309ae68d78a1b2330fd922fa3a2

Then I think we can abandon this revision @sameerarora101

[sameerarora101]

ok thanks @gchatelet

llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp

 namespace llvm {
 namespace objcopy {
 namespace macho {
 
 using namespace object;
 using SectionPred = std::function<bool(const std::unique_ptr<Section> &Sec)>;
 using LoadCommandPred = std::function<bool(const LoadCommand &LC)>;
 
+#ifndef NDEBUG
 static bool isLoadCommandWithPayloadString(const LoadCommand &LC) {
   // TODO: Add support for LC_REEXPORT_DYLIB, LC_LOAD_UPWARD_DYLIB and
   // LC_LAZY_LOAD_DYLIB
   return LC.MachOLoadCommand.load_command_data.cmd == MachO::LC_RPATH ||
          LC.MachOLoadCommand.load_command_data.cmd == MachO::LC_ID_DYLIB ||
          LC.MachOLoadCommand.load_command_data.cmd == MachO::LC_LOAD_DYLIB ||
          LC.MachOLoadCommand.load_command_data.cmd == MachO::LC_LOAD_WEAK_DYLIB;
 }
+#endif
 
 static StringRef getLoadCommandPayloadString(const LoadCommand &LC) {
   assert(isLoadCommandWithPayloadString(LC) &&
          "unsupported load command encountered");
 
   return StringRef(reinterpret_cast<const char *>(LC.Payload.data()),
                    LC.Payload.size())
       .rtrim('\0');