This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SVE] Only support sizeless bfloat types if supported by subtarget
ClosedPublic

Authored by c-rhodes on Jun 24 2020, 12:28 PM.

Diff Detail

Event Timeline

c-rhodes created this revision.Jun 24 2020, 12:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2020, 12:28 PM
fpetrogalli accepted this revision.Jun 24 2020, 12:37 PM

Nit: the patch doesn't seem to have any dependencies on the other patches in the "Stack" tab. If that the case, please consider removing such dependencies.

Francesco

This revision is now accepted and ready to land.Jun 24 2020, 12:37 PM

Nit: the patch doesn't seem to have any dependencies on the other patches in the "Stack" tab. If that the case, please consider removing such dependencies.

Sorry I'm not sure what you mean? I've added 2 parent patches that address missing +bf16 guards on patterns in LLVM, I believe this should be able to land after those two patches are merged.

Nit: the patch doesn't seem to have any dependencies on the other patches in the "Stack" tab. If that the case, please consider removing such dependencies.

Sorry I'm not sure what you mean? I've added 2 parent patches that address missing +bf16 guards on patterns in LLVM, I believe this should be able to land after those two patches are merged.

This change doesn't seem to need those to patches. I think you can land it independently from them?

This change doesn't seem to need those to patches. I think you can land it independently from them?

The two patches add missing +bf16 guards to patterns that use this register class, the tests break when I introduce this without those patches.

c-rhodes updated this revision to Diff 273663.Jun 26 2020, 4:27 AM
c-rhodes retitled this revision from [AArch64][SVE] Only support nxv8bf16 if supported by subtarget to [AArch64][SVE] Only support sizeless bfloat types if supported by subtarget.

Changes:

  • Add nxv2bf16 and nxv4bf16.
This revision was automatically updated to reflect the committed changes.