This is an archive of the discontinued LLVM Phabricator instance.

Differential D82484

[Hexagon] llvm-objcopy check for SHN_HEXAGON_SCOMMON_1
ClosedPublic

Authored by sidneym on Jun 24 2020, 10:50 AM.

Details

Reviewers
bcain
kparzysz
MaskRay
grimar
• espindola
alexander-shaposhnikov
rupprecht
jhenderson
Commits
rGe5911de37722: [Hexagon][llvm-objcopy] Add missing check for SHN_HEXAGON_SCOMMON_1
Summary

Missing case SHN_HEXAGON_SCOMMON_1

Diff Detail

Event Timeline

sidneym created this revision.Jun 24 2020, 10:50 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJun 24 2020, 10:50 AM
Herald added a reviewer: alexander-shaposhnikov. · View Herald Transcript
Herald added a reviewer: rupprecht. · View Herald Transcript
Herald added a reviewer: jhenderson. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: abrachet, emaste. · View Herald Transcript
MaskRay accepted this revision.Jun 24 2020, 11:39 AM

You can change the subject to [Hexagon][llvm-objcopy] or [llvm-objcopy]

This revision is now accepted and ready to land.Jun 24 2020, 11:39 AM
alexander-shaposhnikov accepted this revision.Jun 24 2020, 12:32 PM
Harbormaster completed remote builds in B61588: Diff 273099.Jun 24 2020, 1:01 PM
Closed by commit rGe5911de37722: [Hexagon][llvm-objcopy] Add missing check for SHN_HEXAGON_SCOMMON_1 (authored by sidneym). · Explain WhyJun 24 2020, 5:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
ELF/
19 lines
tools/
llvm-objcopy/
ELF/
1 line

Diff 273206

llvm/test/tools/llvm-objcopy/ELF/common-symbol.test

# RUN: yaml2obj %s -o %t # RUN: yaml2obj %s -o %t
# RUN: llvm-objcopy %t %t2 # RUN: llvm-objcopy %t %t2
# RUN: llvm-readobj --symbols %t2 | FileCheck %s # RUN: llvm-readobj --symbols %t2 | FileCheck %s
!ELF !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_EXEC Type: ET_EXEC
Machine: EM_HEXAGON Machine: EM_HEXAGON
Symbols: Symbols:
- Name: test - Name: test
Index: SHN_COMMON Index: SHN_COMMON
Value: 0x1233
Binding: STB_GLOBAL
- Name: test1
Index: SHN_HEXAGON_SCOMMON
Value: 0x1234 Value: 0x1234
Binding: STB_GLOBAL Binding: STB_GLOBAL
- Name: test2 - Name: test2
Index: SHN_HEXAGON_SCOMMON Index: SHN_HEXAGON_SCOMMON_1
Value: 0x1235 Value: 0x1235
Binding: STB_GLOBAL Binding: STB_GLOBAL
- Name: test3 - Name: test3
Index: SHN_HEXAGON_SCOMMON_2 Index: SHN_HEXAGON_SCOMMON_2
Value: 0x1236 Value: 0x1236
Binding: STB_GLOBAL Binding: STB_GLOBAL
- Name: test4 - Name: test4
Index: SHN_HEXAGON_SCOMMON_4 Index: SHN_HEXAGON_SCOMMON_4
Show All 11 Lines
#CHECK-NEXT: Size: 0 #CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Local (0x0) #CHECK-NEXT: Binding: Local (0x0)
#CHECK-NEXT: Type: None (0x0) #CHECK-NEXT: Type: None (0x0)
#CHECK-NEXT: Other: 0 #CHECK-NEXT: Other: 0
#CHECK-NEXT: Section: Undefined (0x0) #CHECK-NEXT: Section: Undefined (0x0)
#CHECK-NEXT: } #CHECK-NEXT: }
#CHECK-NEXT: Symbol { #CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test #CHECK-NEXT: Name: test
#CHECK-NEXT: Value: 0x1234 #CHECK-NEXT: Value: 0x1233
#CHECK-NEXT: Size: 0 #CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Global (0x1) #CHECK-NEXT: Binding: Global (0x1)
#CHECK-NEXT: Type: None (0x0) #CHECK-NEXT: Type: None (0x0)
#CHECK-NEXT: Other: 0 #CHECK-NEXT: Other: 0
#CHECK-NEXT: Section: Common (0xFFF2) #CHECK-NEXT: Section: Common (0xFFF2)
#CHECK-NEXT: } #CHECK-NEXT: }
#CHECK-NEXT: Symbol { #CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test1
#CHECK-NEXT: Value: 0x1234
#CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Global (0x1)
#CHECK-NEXT: Type: None (0x0)
#CHECK-NEXT: Other: 0
#CHECK-NEXT: Section: Processor Specific (0xFF00)
#CHECK-NEXT: }
#CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test2 #CHECK-NEXT: Name: test2
#CHECK-NEXT: Value: 0x1235 #CHECK-NEXT: Value: 0x1235
#CHECK-NEXT: Size: 0 #CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Global (0x1) #CHECK-NEXT: Binding: Global (0x1)
#CHECK-NEXT: Type: None (0x0) #CHECK-NEXT: Type: None (0x0)
#CHECK-NEXT: Other: 0 #CHECK-NEXT: Other: 0
#CHECK-NEXT: Section: Processor Specific (0xFF00) #CHECK-NEXT: Section: Processor Specific (0xFF01)
#CHECK-NEXT: } #CHECK-NEXT: }
#CHECK-NEXT: Symbol { #CHECK-NEXT: Symbol {
#CHECK-NEXT: Name: test3 #CHECK-NEXT: Name: test3
#CHECK-NEXT: Value: 0x1236 #CHECK-NEXT: Value: 0x1236
#CHECK-NEXT: Size: 0 #CHECK-NEXT: Size: 0
#CHECK-NEXT: Binding: Global (0x1) #CHECK-NEXT: Binding: Global (0x1)
#CHECK-NEXT: Type: None (0x0) #CHECK-NEXT: Type: None (0x0)
#CHECK-NEXT: Other: 0 #CHECK-NEXT: Other: 0
Show All 21 Lines

llvm/tools/llvm-objcopy/ELF/Object.cpp

Show First 20 Lines • Show All 602 Lines • ▼ Show 20 Linesstatic bool isValidReservedSectionIndex(uint16_t Index, uint16_t Machine) {
if (Machine == EM_AMDGPU) { if (Machine == EM_AMDGPU) {
return Index == SHN_AMDGPU_LDS; return Index == SHN_AMDGPU_LDS;
} }
if (Machine == EM_HEXAGON) { if (Machine == EM_HEXAGON) {
switch (Index) { switch (Index) {
case SHN_HEXAGON_SCOMMON: case SHN_HEXAGON_SCOMMON:
case SHN_HEXAGON_SCOMMON_1:
case SHN_HEXAGON_SCOMMON_2: case SHN_HEXAGON_SCOMMON_2:
case SHN_HEXAGON_SCOMMON_4: case SHN_HEXAGON_SCOMMON_4:
case SHN_HEXAGON_SCOMMON_8: case SHN_HEXAGON_SCOMMON_8:
return true; return true;
} }
} }
return false; return false;
} }
▲ Show 20 Lines • Show All 1,763 Lines • Show Last 20 Lines