[OpenMP][Tests] Fix/Mark compatibilty for GCC

[protze.joachim]

Summary

Some of the newly added tests are not compatible with GCC as test compiler.

runtime/test/ompt/tasks/dependences.c

is reverted to the old pre 63a3c5925 test (without mutexinoutset)

runtime/test/ompt/tasks/dependences_mtxinoutset.c

This test is the 63a3c5925 version of dependences.c, is not compatible with gcc and needs clang-9+

runtime/test/ompt/worksharing/for/runtime*.c

These tests use GOMP_parallel_loop_maybe_nonmonotonic_runtime starting with gcc-9

tools/multiplex/tests/*

These tests use the master construct. GCC does not generate events for that -> expect to fail

[ronlieb]

LGTM, would like Saiyed and Johannes to review and approve

[protze.joachim]

I found another issue with this test (addressing Saiyedul's error). I'll post an updated patch in a minute

[protze.joachim]

The intention was to check the return address for the first two tasks. Unfortunately, the CHECK did not capture the return address of the second task creation, but instead compared to the return address of the first task.

[saiislam]

LGTM. Thank you!
Please link any ongoing/future effort to enable support for gcc-9/10 for the failing tests, as and when it materializes.

Please wait for @jdoerfert 's review.

[protze.joachim]

Sorry, in my previous update I missed to include the other changes (diff to the wrong commit)

Now, I also added compatibility flags for gcc-10

[Hahnfeld]

The summary also talks about tools/multiplex/tests/*, is that information obsolete?

openmp/runtime/test/ompt/tasks/dependences_mtxinoutset.c

3–6

I would put the comment in front of the UNSUPPORTED and possibly split into gcc and clang-4, .... Also can we rename the test file to the full mutexinoutset? That's two additional characters, but easier to search for.

[protze.joachim]

Addressed @Hahnfeld 's comments

[Hahnfeld]

LGTM

openmp/runtime/test/ompt/tasks/dependences_mtxinoutset.c

 // RUN: %libomp-compile-and-run | %sort-threads | FileCheck %s
 // REQUIRES: ompt
 // UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8
 
 // GCC does not pass in mutexinoutset
 // clang 9 introduced codegen for mutexinoutset
 
 #include "callback.h"
 #include <omp.h>
 #include <math.h>
 #include <unistd.h>
 
 int main() {
   int x = 0;

 // CHECK: {{^}}[[MASTER_ID]]: task level 0: parallel_id=[[PARALLEL_ID]],
 // CHECK-SAME: task_id=[[IMPLICIT_TASK_ID]], exit_frame=[[EXIT]],
 // CHECK-SAME: reenter_frame=[[NULL]]
 
 // CHECK: {{^}}[[MASTER_ID]]: ompt_event_task_create:
 // CHECK-SAME: parent_task_id={{[0-9]+}}, parent_task_frame.exit=[[EXIT]],
 // CHECK-SAME: parent_task_frame.reenter={{0x[0-f]+}},
 // CHECK-SAME: new_task_id=[[SECOND_TASK:[0-f]+]], codeptr_ra={{0x[0-f]+}},
+// CHECK-SAME: codeptr_ra=[[RETURN_ADDRESS:0x[0-f]+]]{{[0-f][0-f]}},
 // CHECK-SAME: task_type=ompt_task_explicit=4, has_dependences=yes
 
 // CHECK: {{^}}[[MASTER_ID]]: ompt_event_dependences:
 // CHECK-SAME: task_id=[[SECOND_TASK]], deps=[([[ADDRX]],
 // CHECK-SAME: ompt_dependence_type_mutexinoutset)], ndeps=1
 
 // CHECK: {{^}}[[MASTER_ID]]: ompt_event_task_dependence_pair:
 // CHECK-SAME: first_task_id=[[FIRST_TASK]], second_task_id=[[SECOND_TASK]]