This is an archive of the discontinued LLVM Phabricator instance.

Differential D82038

[flang] Fix out-of-tree builds
ClosedPublic

Authored by tskeith on Jun 17 2020, 11:56 AM.

Details

Reviewers
klausler
PeteSteinfeld
jdoerfert
DavidTruby
Commits
rGf392b75fd853: [flang] Fix out-of-tree builds
Summary

Replace two MLIR dependencies with MLIRLinalgOps.

Diff Detail

Event Timeline

tskeith created this revision.Jun 17 2020, 11:56 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJun 17 2020, 11:56 AM
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, stephenneuendorffer, rriddle, mgorny. · View Herald Transcript
klausler accepted this revision.Jun 17 2020, 11:57 AM
This revision is now accepted and ready to land.Jun 17 2020, 11:57 AM
PeteSteinfeld accepted this revision.Jun 17 2020, 12:04 PM

I ran cmake with this patch and got no errors. Thanks, Tim!

Closed by commit rGf392b75fd853: [flang] Fix out-of-tree builds (authored by tskeith). · Explain WhyJun 17 2020, 12:24 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B60676: Diff 271434!Jun 17 2020, 12:25 PM
schweitz added a subscriber: schweitz.Jun 17 2020, 1:20 PM

Not the correct change. See https://reviews.llvm.org/D82050

Revision Contents

PathSize
flang/
lib/
Lower/
3 lines

Diff 271447

flang/lib/Lower/CMakeLists.txt

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error -Wno-unused-parameter") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-error -Wno-unused-parameter")
add_flang_library(FortranLower add_flang_library(FortranLower
ComplexExpr.cpp ComplexExpr.cpp
ConvertType.cpp ConvertType.cpp
DoLoopHelper.cpp DoLoopHelper.cpp
Mangler.cpp Mangler.cpp
OpenMP.cpp OpenMP.cpp
PFTBuilder.cpp PFTBuilder.cpp
DEPENDS DEPENDS
FIROpsIncGen FIROpsIncGen
MLIROpAsmInterfaceIncGen
MLIRControlFlowInterfaces MLIRControlFlowInterfaces
MLIRLinalgStructuredOpsInterfaceIncGen MLIRLinalgOps
LINK_COMPONENTS LINK_COMPONENTS
Support Support
) )